jared/cc-os
Watch
1
0
Fork
You've already forked cc-os
 0
Code Issues 378 Pull requests Projects Releases Packages Wiki Activity

os-adr: adr-new and adr-init run through Adr::CLI command classes with an Invocation; cli_test runs in-process #640

New issue
Closed
opened 2026-09-23 13:04:55 +00:00 by jared · 3 comments
jared commented 2026-09-23 13:04:55 +00:00
Owner
Copy link

Map: #631
Blocked by #638

Problem

Child of #631. Uses the seam shape that #638 records in its ADR. Prerequisite: .sdlc/project.yaml has no os-adr target, so implementation-open --target os-adr cannot open this ticket until a target is added (code_path plugins/os-adr/lib, test_path plugins/os-adr/tests, test_command ruby plugins/os-adr/tests/all.rb).

Observed

plugins/os-adr/tests/cli_test.rb forks ruby bin/adr-new (4 tests, stdin JSON) and ruby bin/adr-init (2 tests). Both bins hold their logic inline: they read Dir.pwd, ARGV, and $stdin, and fail with abort. The whole os-adr suite takes 0.6 s (2026-09-23).

Reproduce

cd plugins/os-adr && ruby tests/cli_test.rb

Expected

One prose sentence: Adr::CLI::New and Adr::CLI::Init take an Invocation and argv, return an exit status, and write only to the invocation streams; the bins only build the Invocation.

Origin

  • Trigger: decomposition of #631, 2026-09-23 (user-decided split)
  • Improvised this session: none
  • Chain: 6 forks ← CLI logic inline in bin/adr-new and bin/adr-init (DESIGN)
  • Root candidate: this ticket
  • Where: plugins/os-adr/bin/adr-new; plugins/os-adr/bin/adr-init; plugins/os-adr/tests/cli_test.rb
  • Session: 5bb052ff-ddf2-4d47-a283-d00d071e9b79
  • Transcript: /home/jared/.claude/projects/-home-jared-dev-cc-os/5bb052ff-ddf2-4d47-a283-d00d071e9b79.jsonl

Owner sketch

module Adr
  Invocation = Data.define(:cwd, :stdin, :stdout, :stderr, :env)   # lib/adr/invocation.rb
  module CLI
    class New                                                       # lib/adr/cli/new.rb
      def initialize(invocation)
      def run(argv)
    end
    class Init                                                      # lib/adr/cli/init.rb
      def initialize(invocation)
      def run(argv)
    end
  end
end

Acceptance criteria

  1. Given an initialized root and JSON input on invocation.stdin, when Adr::CLI::New#run(["--root", root]) runs, then the new numbered ADR path is on invocation.stdout and the index lists it.
  2. Given input without a title, when New runs, then adr-new: 'title' is required is on invocation.stderr and the status is nonzero.
  3. Given a root with no docs/adr/, when New runs, then invocation.stderr names adr-init and the status is nonzero.
  4. Given no --root argument, when New runs, then it writes under invocation.cwd.
  5. Given a root with .os-adr/suppress, when Adr::CLI::Init#run(["--root", root]) runs, then docs/adr/ and its index exist, the suppress file is gone, and the ADR dir path is on stdout.
  6. Given the real bin/adr-new, when it runs as a subprocess on an initialized temp root, then it exits 0 and prints the new ADR path.
  7. Given the real bin/adr-init, when it runs as a subprocess on a temp root, then it exits 0.

Approach

  • Replace abort with a stderr line plus a returned status of 1. Convert the six existing tests in place, including the supersession test.
  • Out of scope: adr-find, adr-detect, adr-migrate (no tests fork them).
  • ADRs to respect: ADR-0195 (one constant per file), ADR-0025 (lib/adr.rb require_relative manifest), ADR-0123 (thin bin). Adopting Thor is out of scope.
    Required work:
  1. Move bin/adr-new and bin/adr-init's logic into Adr::CLI::New/Adr::CLI::Init behind an Invocation, replacing abort with a stderr line and a returned status. (check: ! grep -n abort plugins/os-adr/bin/adr-new plugins/os-adr/bin/adr-init)
  2. Convert the 6 existing tests in cli_test.rb in place to call the new CLI classes in-process. (proven by AC 1, AC 2, AC 3, AC 5)
  3. Keep bin/adr-new and bin/adr-init runnable as real subprocesses that exit 0. (proven by AC 6, AC 7)
  4. Add the os-adr target to .sdlc/project.yaml before ticket open. (check: grep -n os-adr .sdlc/project.yaml)

Structural follow-through

  • Add the os-adr target to .sdlc/project.yaml before open (prerequisite, see Context).
  • One History row in docs/implementation-status/os-adr.md.
Map: #631 Blocked by #638 ## Problem Child of #631. Uses the seam shape that #638 records in its ADR. Prerequisite: .sdlc/project.yaml has no `os-adr` target, so `implementation-open --target os-adr` cannot open this ticket until a target is added (code_path plugins/os-adr/lib, test_path plugins/os-adr/tests, test_command `ruby plugins/os-adr/tests/all.rb`). ## Observed plugins/os-adr/tests/cli_test.rb forks `ruby bin/adr-new` (4 tests, stdin JSON) and `ruby bin/adr-init` (2 tests). Both bins hold their logic inline: they read `Dir.pwd`, `ARGV`, and `$stdin`, and fail with `abort`. The whole os-adr suite takes 0.6 s (2026-09-23). ## Reproduce ``` cd plugins/os-adr && ruby tests/cli_test.rb ``` ## Expected One prose sentence: `Adr::CLI::New` and `Adr::CLI::Init` take an Invocation and argv, return an exit status, and write only to the invocation streams; the bins only build the Invocation. ## Origin - Trigger: decomposition of #631, 2026-09-23 (user-decided split) - Improvised this session: none - Chain: 6 forks ← CLI logic inline in bin/adr-new and bin/adr-init (DESIGN) - Root candidate: this ticket - Where: plugins/os-adr/bin/adr-new; plugins/os-adr/bin/adr-init; plugins/os-adr/tests/cli_test.rb - Session: 5bb052ff-ddf2-4d47-a283-d00d071e9b79 - Transcript: /home/jared/.claude/projects/-home-jared-dev-cc-os/5bb052ff-ddf2-4d47-a283-d00d071e9b79.jsonl ## Owner sketch ```ruby module Adr Invocation = Data.define(:cwd, :stdin, :stdout, :stderr, :env) # lib/adr/invocation.rb module CLI class New # lib/adr/cli/new.rb def initialize(invocation) def run(argv) end class Init # lib/adr/cli/init.rb def initialize(invocation) def run(argv) end end end ``` ## Acceptance criteria 1. Given an initialized root and JSON input on `invocation.stdin`, when `Adr::CLI::New#run(["--root", root])` runs, then the new numbered ADR path is on `invocation.stdout` and the index lists it. 2. Given input without a title, when New runs, then `adr-new: 'title' is required` is on `invocation.stderr` and the status is nonzero. 3. Given a root with no docs/adr/, when New runs, then `invocation.stderr` names adr-init and the status is nonzero. 4. Given no `--root` argument, when New runs, then it writes under `invocation.cwd`. 5. Given a root with .os-adr/suppress, when `Adr::CLI::Init#run(["--root", root])` runs, then docs/adr/ and its index exist, the suppress file is gone, and the ADR dir path is on stdout. 6. Given the real bin/adr-new, when it runs as a subprocess on an initialized temp root, then it exits 0 and prints the new ADR path. 7. Given the real bin/adr-init, when it runs as a subprocess on a temp root, then it exits 0. ## Approach - Replace `abort` with a stderr line plus a returned status of 1. Convert the six existing tests in place, including the supersession test. - Out of scope: adr-find, adr-detect, adr-migrate (no tests fork them). - ADRs to respect: ADR-0195 (one constant per file), ADR-0025 (lib/adr.rb require_relative manifest), ADR-0123 (thin bin). Adopting Thor is out of scope. Required work: 1. Move `bin/adr-new` and `bin/adr-init`'s logic into `Adr::CLI::New`/`Adr::CLI::Init` behind an `Invocation`, replacing `abort` with a stderr line and a returned status. (check: `! grep -n abort plugins/os-adr/bin/adr-new plugins/os-adr/bin/adr-init`) 2. Convert the 6 existing tests in cli_test.rb in place to call the new CLI classes in-process. (proven by AC 1, AC 2, AC 3, AC 5) 3. Keep bin/adr-new and bin/adr-init runnable as real subprocesses that exit 0. (proven by AC 6, AC 7) 4. Add the os-adr target to .sdlc/project.yaml before ticket open. (check: `grep -n os-adr .sdlc/project.yaml`) ## Structural follow-through - Add the os-adr target to .sdlc/project.yaml before open (prerequisite, see Context). - One History row in docs/implementation-status/os-adr.md.
jared commented 2026-09-23 20:34:47 +00:00
Author
Owner
Copy link

Body before Required-work migration, 2026-09-23

Map: #631
Blocked by #638

Problem

Child of #631. Uses the seam shape that #638 records in its ADR. Prerequisite: .sdlc/project.yaml has no os-adr target, so implementation-open --target os-adr cannot open this ticket until a target is added (code_path plugins/os-adr/lib, test_path plugins/os-adr/tests, test_command ruby plugins/os-adr/tests/all.rb).

Observed

plugins/os-adr/tests/cli_test.rb forks ruby bin/adr-new (4 tests, stdin JSON) and ruby bin/adr-init (2 tests). Both bins hold their logic inline: they read Dir.pwd, ARGV, and $stdin, and fail with abort. The whole os-adr suite takes 0.6 s (2026-09-23).

Reproduce

cd plugins/os-adr && ruby tests/cli_test.rb

Expected

One prose sentence: Adr::CLI::New and Adr::CLI::Init take an Invocation and argv, return an exit status, and write only to the invocation streams; the bins only build the Invocation.

Origin

  • Trigger: decomposition of #631, 2026-09-23 (user-decided split)
  • Improvised this session: none
  • Chain: 6 forks ← CLI logic inline in bin/adr-new and bin/adr-init (DESIGN)
  • Root candidate: this ticket
  • Where: plugins/os-adr/bin/adr-new; plugins/os-adr/bin/adr-init; plugins/os-adr/tests/cli_test.rb
  • Session: 5bb052ff-ddf2-4d47-a283-d00d071e9b79
  • Transcript: /home/jared/.claude/projects/-home-jared-dev-cc-os/5bb052ff-ddf2-4d47-a283-d00d071e9b79.jsonl

Owner sketch

module Adr
  Invocation = Data.define(:cwd, :stdin, :stdout, :stderr, :env)   # lib/adr/invocation.rb
  module CLI
    class New                                                       # lib/adr/cli/new.rb
      def initialize(invocation)
      def run(argv)
    end
    class Init                                                      # lib/adr/cli/init.rb
      def initialize(invocation)
      def run(argv)
    end
  end
end

Acceptance criteria

  1. Given an initialized root and JSON input on invocation.stdin, when Adr::CLI::New#run(["--root", root]) runs, then the new numbered ADR path is on invocation.stdout and the index lists it.
  2. Given input without a title, when New runs, then adr-new: 'title' is required is on invocation.stderr and the status is nonzero.
  3. Given a root with no docs/adr/, when New runs, then invocation.stderr names adr-init and the status is nonzero.
  4. Given no --root argument, when New runs, then it writes under invocation.cwd.
  5. Given a root with .os-adr/suppress, when Adr::CLI::Init#run(["--root", root]) runs, then docs/adr/ and its index exist, the suppress file is gone, and the ADR dir path is on stdout.
  6. Given the real bin/adr-new, when it runs as a subprocess on an initialized temp root, then it exits 0 and prints the new ADR path.
  7. Given the real bin/adr-init, when it runs as a subprocess on a temp root, then it exits 0.

Approach

  • Replace abort with a stderr line plus a returned status of 1. Convert the six existing tests in place, including the supersession test.
  • Out of scope: adr-find, adr-detect, adr-migrate (no tests fork them).
  • ADRs to respect: ADR-0195 (one constant per file), ADR-0025 (lib/adr.rb require_relative manifest), ADR-0123 (thin bin). Adopting Thor is out of scope.

Structural follow-through

  • Add the os-adr target to .sdlc/project.yaml before open (prerequisite, see Context).
  • One History row in docs/implementation-status/os-adr.md.
Body before Required-work migration, 2026-09-23 Map: #631 Blocked by #638 ## Problem Child of #631. Uses the seam shape that #638 records in its ADR. Prerequisite: .sdlc/project.yaml has no `os-adr` target, so `implementation-open --target os-adr` cannot open this ticket until a target is added (code_path plugins/os-adr/lib, test_path plugins/os-adr/tests, test_command `ruby plugins/os-adr/tests/all.rb`). ## Observed plugins/os-adr/tests/cli_test.rb forks `ruby bin/adr-new` (4 tests, stdin JSON) and `ruby bin/adr-init` (2 tests). Both bins hold their logic inline: they read `Dir.pwd`, `ARGV`, and `$stdin`, and fail with `abort`. The whole os-adr suite takes 0.6 s (2026-09-23). ## Reproduce ``` cd plugins/os-adr && ruby tests/cli_test.rb ``` ## Expected One prose sentence: `Adr::CLI::New` and `Adr::CLI::Init` take an Invocation and argv, return an exit status, and write only to the invocation streams; the bins only build the Invocation. ## Origin - Trigger: decomposition of #631, 2026-09-23 (user-decided split) - Improvised this session: none - Chain: 6 forks ← CLI logic inline in bin/adr-new and bin/adr-init (DESIGN) - Root candidate: this ticket - Where: plugins/os-adr/bin/adr-new; plugins/os-adr/bin/adr-init; plugins/os-adr/tests/cli_test.rb - Session: 5bb052ff-ddf2-4d47-a283-d00d071e9b79 - Transcript: /home/jared/.claude/projects/-home-jared-dev-cc-os/5bb052ff-ddf2-4d47-a283-d00d071e9b79.jsonl ## Owner sketch ```ruby module Adr Invocation = Data.define(:cwd, :stdin, :stdout, :stderr, :env) # lib/adr/invocation.rb module CLI class New # lib/adr/cli/new.rb def initialize(invocation) def run(argv) end class Init # lib/adr/cli/init.rb def initialize(invocation) def run(argv) end end end ``` ## Acceptance criteria 1. Given an initialized root and JSON input on `invocation.stdin`, when `Adr::CLI::New#run(["--root", root])` runs, then the new numbered ADR path is on `invocation.stdout` and the index lists it. 2. Given input without a title, when New runs, then `adr-new: 'title' is required` is on `invocation.stderr` and the status is nonzero. 3. Given a root with no docs/adr/, when New runs, then `invocation.stderr` names adr-init and the status is nonzero. 4. Given no `--root` argument, when New runs, then it writes under `invocation.cwd`. 5. Given a root with .os-adr/suppress, when `Adr::CLI::Init#run(["--root", root])` runs, then docs/adr/ and its index exist, the suppress file is gone, and the ADR dir path is on stdout. 6. Given the real bin/adr-new, when it runs as a subprocess on an initialized temp root, then it exits 0 and prints the new ADR path. 7. Given the real bin/adr-init, when it runs as a subprocess on a temp root, then it exits 0. ## Approach - Replace `abort` with a stderr line plus a returned status of 1. Convert the six existing tests in place, including the supersession test. - Out of scope: adr-find, adr-detect, adr-migrate (no tests fork them). - ADRs to respect: ADR-0195 (one constant per file), ADR-0025 (lib/adr.rb require_relative manifest), ADR-0123 (thin bin). Adopting Thor is out of scope. ## Structural follow-through - Add the os-adr target to .sdlc/project.yaml before open (prerequisite, see Context). - One History row in docs/implementation-status/os-adr.md.
jared commented 2026-09-24 01:51:13 +00:00
Author
Owner
Copy link

Work started via /os-sdlc:implement on branch ticket-640 (worktree .claude/worktrees/ticket-640).

Work started via /os-sdlc:implement on branch ticket-640 (worktree .claude/worktrees/ticket-640).
jared commented 2026-09-24 02:11:16 +00:00
Author
Owner
Copy link

Resolution

Done: Adr::CLI::New and Adr::CLI::Init take an Invocation and argv, return an exit status, and write only to the invocation streams; bin/adr-new and bin/adr-init only build the Invocation; cli_test.rb runs in-process with no forks.

Evidence: Branch ticket-640 via os-sdlc implementation 17 (dispatches 189-200, three test-writer/reviewer rounds, all gates pass). os-adr suite: 50 runs, 168 assertions, 0 failures.

Follow-ups: none

## Resolution **Done:** Adr::CLI::New and Adr::CLI::Init take an Invocation and argv, return an exit status, and write only to the invocation streams; bin/adr-new and bin/adr-init only build the Invocation; cli_test.rb runs in-process with no forks. **Evidence:** Branch ticket-640 via os-sdlc implementation 17 (dispatches 189-200, three test-writer/reviewer rounds, all gates pass). os-adr suite: 50 runs, 168 assertions, 0 failures. **Follow-ups:** none
jared closed this issue 2026-09-24 02:11:16 +00:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
ticket-1337
No results found.
Labels
Clear labels   
P0
Priority 0 — drop everything

  
P1
Priority 1 — next up

  
P2
Priority 2 — normal

  
P3
Priority 3 — someday

  
bug
Something is broken

  
category/code-change
Ticket category

  
category/cross-repo
Ticket category

  
category/eval-run
Ticket category

  
category/investigation
Ticket category

  
category/no-test-target
Ticket category

  
category/owner-ruling
Ticket category

  
category/prose-artifact
Ticket category

  
category/recurring-chore
Ticket category

  
category/structure

   
category/umbrella
Ticket category

  
crc-refactor
CRC refactor run work record; exempt from the ticket-skeptic

  
create
Ticket creates something new

  
delete
Ticket removes something

  
enhancement
New feature or improvement

  
filed-by/agent

   
filed-by/user

   
frozen
Pre-reset backlog freeze 2026-08-16; do not work unless rediscovered by a live run

  
lint-rule
Ticket proposes/modifies a lint rule or cop

  
needs-info
Waiting on reporter for more information

  
needs-triage
Maintainer needs to evaluate this issue

  
next
Human-curated next up — AI never applies or removes

  
plugin/cc-architect
Scope: the cc-architect plugin

  
plugin/os
Scope: the os plugin

  
plugin/os-adr
Scope: the os-adr plugin

  
plugin/os-aidd-lint
Scope: the os-aidd-lint plugin

  
plugin/os-backlog
Scope: the os-backlog plugin

  
plugin/os-context
Scope: the os-context plugin

  
plugin/os-doc-hygiene
Scope: the os-doc-hygiene plugin

  
plugin/os-sdlc
Scope: the os-sdlc plugin

  
plugin/os-vault
Scope: the os-vault plugin

  
project/cc-os
Parent-scope: cc-os repo-wide, not specific to one plugin

  
ready-for-agent
Triage complete; an agent can pick this up

  
ready-for-human
Human-owned; never picked up autonomously

  
recurring
Recurring flavor: occurrence outcomes commented, never closed by AI

  
review
Shipped semi work awaiting human sign-off

  
rule-proposal
A rule change that survived the gate; Jared reads these when he chooses

  
update
Ticket updates something existing

  
waiting
Blocked; blocker named in a comment

  
wayfinder:grilling

   
wayfinder:map

   
wayfinder:map
wayfinder map ticket

  
wayfinder:research

   
wayfinder:task

   
wayfinder:task
wayfinder map child: task

  
wontfix
Will not be actioned

  
worklist/deviations
Deviation incidents from skill/pipeline runs — evidence pile for correcting the owning artifact

  
worklist/lint-rule
Proposed os-sdlc or os-aidd-lint rule

  
worklist/new-implement-build
Updated implementation harness (ast-grep + stepper)

No labels
P0
P1
P2
P3
bug
category/code-change
category/cross-repo
category/eval-run
category/investigation
category/no-test-target
category/owner-ruling
category/prose-artifact
category/recurring-chore
category/structure
category/umbrella
crc-refactor
create
delete
enhancement
filed-by/agent
filed-by/user
frozen
lint-rule
needs-info
needs-triage
next
plugin/cc-architect
plugin/os
plugin/os-adr
plugin/os-aidd-lint
plugin/os-backlog
plugin/os-context
plugin/os-doc-hygiene
plugin/os-sdlc
plugin/os-vault
project/cc-os
ready-for-agent
ready-for-human
recurring
review
rule-proposal
update
waiting
wayfinder:grilling
wayfinder:map
wayfinder:map
wayfinder:research
wayfinder:task
wayfinder:task
wontfix
worklist/deviations
worklist/lint-rule
worklist/new-implement-build
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
jared/cc-os#640
No description provided.