Give the code/test path convention one owner: Project::Layout [capture]

jared commented

2026-09-14 13:47:17 +00:00

Owner

Context

Responsibility audit run 13 on plugins/os-sdlc/lib/os_sdlc/project.rb (analysis: .sdlc/tmp/responsibility-audit/13-project-rb-reaudit/analysis.yaml, uncommitted). Capability: code/test path convention. Project#tests_for knows the mirrored and unnamespaced test naming and the scenario glob. Four other objects decide "is this a test path" with their own string form.
Callers that would delegate: Project#tests_for; Project::Changes#code_paths/#test_paths; ScopePolicy#test_path?; GreenAssertFailureSidecar#under_test_path?; LintWorklistTarget#code_dir.

Observed

lib/os_sdlc/project.rb:93         code_relative = code_file.delete_prefix("#{code_path}/")
lib/os_sdlc/project.rb:123        mirrored = "#{test_path}/#{code_relative}"
lib/os_sdlc/project.rb:124        unnamespaced = "#{test_path}/#{code_relative.split('/', 2).last}"
lib/os_sdlc/project.rb:129        candidate.sub(/_test\.rb\z/, '_*_test.rb')
lib/os_sdlc/project/changes.rb:32 "#{@project.test_path}/"
lib/os_sdlc/project/changes.rb:45 "#{@project.code_path}/"
lib/os_sdlc/scope_policy.rb:54    (test_path? via regex on @test_path)
lib/os_sdlc/green_assert_failure_sidecar.rb:54 @test_path && failing_path.match?(%r{(^|/)#{Regexp.escape(@test_path)}(/|$)})
lib/os_sdlc/lint_worklist_target.rb:74 code_dir = File.join(root, @project.code_path)

delete_prefix at project.rb:93 does not anchor: a path outside code_path passes through and yields candidates like test/bin/foo_test.rb.

Reproduce

cd plugins/os-sdlc && ruby -Ilib -e 'require "os_sdlc/project"; p OsSdlc::Project.new(name: "x", root: "/tmp").tests_for("bin/foo.rb")'

Expected

def test_tests_for_refuses_a_path_outside_code_path
  layout = OsSdlc::Project::Layout.new(project)
  assert_raises(ArgumentError) { layout.tests_for("bin/foo.rb") }
end

def test_test_predicate_uses_the_configured_test_path
  layout = OsSdlc::Project::Layout.new(project_with(test_path: "spec"))
  assert layout.test?("spec/foo_spec.rb")
  refute layout.test?("test/foo_test.rb")
end

Illustration

# illustration, not spec
class Project::Layout                       # lib/os_sdlc/project/layout.rb
  def initialize(project) = @project = project

  def code?(path) = path.start_with?(code_prefix)
  def test?(path) = path.start_with?(test_prefix)

  def tests_for(code_file)                  # raises unless code?(code_file)
    ...                                     # mirrored, unnamespaced, scenario glob
  end
end

Origin

Trigger: /os-sdlc:responsibility-audit run 13 on plugins/os-sdlc/lib/os_sdlc/project.rb, 2026-09-14
Improvised this session: none
Chain: four path-classification rules ← convention has no owner ← tests_for placed on Project (DESIGN, ADR-0174)
Root candidate: this ticket
Where: lib/os_sdlc/project.rb
Session: 23a382aa-f78e-495f-9cbd-0934e163b37d
Transcript: /home/jared/.claude/projects/-home-jared-dev-cc-os/23a382aa-f78e-495f-9cbd-0934e163b37d.jsonl

Tasks

Add Project::Layout at lib/os_sdlc/project/layout.rb with code?, test?, tests_for.
tests_for raises ArgumentError for a path outside code_path.
test? and code? honor a non-default test_path and code_path.
Project#tests_for delegates to Project::Layout.

Acceptance criteria

Project::Layout.new(project).tests_for("bin/foo.rb") raises ArgumentError.
Project::Layout.new(project).tests_for("lib/os_sdlc/foo.rb") returns the same list Project#tests_for returned before this change.
Project::Layout.new(project).test?("spec/x_spec.rb") is true when test_path is spec.

Structural follow-through

Applied by hand or /os-sdlc:code-write after implementation_complete, before commit:

Project::Changes#code_paths/#test_paths call layout.code?/layout.test?.
ScopePolicy#test_path?, GreenAssertFailureSidecar#under_test_path?, LintWorklistTarget#code_dir delegate to Project::Layout.
Check: rg -n 'test_path}/|code_path}/' plugins/os-sdlc/lib returns only project/layout.rb.

ADR case

Amends ADR-0174 (Project#tests_for moves to Project::Layout; Project keeps the attributes per ADR-0074). Create the amending ADR with /os-adr:create when this ticket lands. ADR-0156 (ScopePolicy owns role and scope rules) is unchanged: ScopePolicy keeps the policy and asks Layout the path question.

Batch

Map: #570. Position 3 of 4. Follows #573. Followed by #572. Map: maps/poodr-ticket-implementation.yaml.

## Context Responsibility audit run 13 on plugins/os-sdlc/lib/os_sdlc/project.rb (analysis: .sdlc/tmp/responsibility-audit/13-project-rb-reaudit/analysis.yaml, uncommitted). Capability: code/test path convention. `Project#tests_for` knows the mirrored and unnamespaced test naming and the scenario glob. Four other objects decide "is this a test path" with their own string form. Callers that would delegate: `Project#tests_for`; `Project::Changes#code_paths`/`#test_paths`; `ScopePolicy#test_path?`; `GreenAssertFailureSidecar#under_test_path?`; `LintWorklistTarget#code_dir`. ## Observed ``` lib/os_sdlc/project.rb:93 code_relative = code_file.delete_prefix("#{code_path}/") lib/os_sdlc/project.rb:123 mirrored = "#{test_path}/#{code_relative}" lib/os_sdlc/project.rb:124 unnamespaced = "#{test_path}/#{code_relative.split('/', 2).last}" lib/os_sdlc/project.rb:129 candidate.sub(/_test\.rb\z/, '_*_test.rb') lib/os_sdlc/project/changes.rb:32 "#{@project.test_path}/" lib/os_sdlc/project/changes.rb:45 "#{@project.code_path}/" lib/os_sdlc/scope_policy.rb:54 (test_path? via regex on @test_path) lib/os_sdlc/green_assert_failure_sidecar.rb:54 @test_path && failing_path.match?(%r{(^|/)#{Regexp.escape(@test_path)}(/|$)}) lib/os_sdlc/lint_worklist_target.rb:74 code_dir = File.join(root, @project.code_path) ``` `delete_prefix` at project.rb:93 does not anchor: a path outside `code_path` passes through and yields candidates like `test/bin/foo_test.rb`. ## Reproduce ``` cd plugins/os-sdlc && ruby -Ilib -e 'require "os_sdlc/project"; p OsSdlc::Project.new(name: "x", root: "/tmp").tests_for("bin/foo.rb")' ``` ## Expected ```ruby def test_tests_for_refuses_a_path_outside_code_path layout = OsSdlc::Project::Layout.new(project) assert_raises(ArgumentError) { layout.tests_for("bin/foo.rb") } end def test_test_predicate_uses_the_configured_test_path layout = OsSdlc::Project::Layout.new(project_with(test_path: "spec")) assert layout.test?("spec/foo_spec.rb") refute layout.test?("test/foo_test.rb") end ``` ## Illustration ```ruby # illustration, not spec class Project::Layout # lib/os_sdlc/project/layout.rb def initialize(project) = @project = project def code?(path) = path.start_with?(code_prefix) def test?(path) = path.start_with?(test_prefix) def tests_for(code_file) # raises unless code?(code_file) ... # mirrored, unnamespaced, scenario glob end end ``` ## Origin - Trigger: /os-sdlc:responsibility-audit run 13 on plugins/os-sdlc/lib/os_sdlc/project.rb, 2026-09-14 - Improvised this session: none - Chain: four path-classification rules ← convention has no owner ← `tests_for` placed on `Project` (DESIGN, ADR-0174) - Root candidate: this ticket - Where: lib/os_sdlc/project.rb - Session: 23a382aa-f78e-495f-9cbd-0934e163b37d - Transcript: /home/jared/.claude/projects/-home-jared-dev-cc-os/23a382aa-f78e-495f-9cbd-0934e163b37d.jsonl ## Tasks - [ ] Add `Project::Layout` at lib/os_sdlc/project/layout.rb with `code?`, `test?`, `tests_for`. - [ ] `tests_for` raises `ArgumentError` for a path outside `code_path`. - [ ] `test?` and `code?` honor a non-default `test_path` and `code_path`. - [ ] `Project#tests_for` delegates to `Project::Layout`. ## Acceptance criteria - `Project::Layout.new(project).tests_for("bin/foo.rb")` raises `ArgumentError`. - `Project::Layout.new(project).tests_for("lib/os_sdlc/foo.rb")` returns the same list `Project#tests_for` returned before this change. - `Project::Layout.new(project).test?("spec/x_spec.rb")` is true when `test_path` is `spec`. ## Structural follow-through Applied by hand or `/os-sdlc:code-write` after `implementation_complete`, before commit: - `Project::Changes#code_paths`/`#test_paths` call `layout.code?`/`layout.test?`. - `ScopePolicy#test_path?`, `GreenAssertFailureSidecar#under_test_path?`, `LintWorklistTarget#code_dir` delegate to `Project::Layout`. - Check: `rg -n 'test_path}/|code_path}/' plugins/os-sdlc/lib` returns only project/layout.rb. ## ADR case Amends ADR-0174 (`Project#tests_for` moves to `Project::Layout`; `Project` keeps the attributes per ADR-0074). Create the amending ADR with /os-adr:create when this ticket lands. ADR-0156 (ScopePolicy owns role and scope rules) is unchanged: ScopePolicy keeps the policy and asks Layout the path question. ## Batch Map: #570. Position 3 of 4. Follows #573. Followed by #572. Map: maps/poodr-ticket-implementation.yaml.

jared added the

plugin/os-sdlc

filed-by/user

labels

2026-09-14 13:47:17 +00:00

jared referenced this issue

2026-09-14 13:48:16 +00:00

Replace the lint_config default sentinel with Project::LintConfig [capture] #573

jared referenced this issue

2026-09-14 13:48:16 +00:00

Give the .sdlc artifact directory one owner: Project::ArtifactDir [capture] #572

jared added the

wayfinder:task

labels

2026-09-14 13:48:21 +00:00

jared referenced this issue

2026-09-14 13:48:30 +00:00

Responsibility-refactor batch 2 on project.rb from re-audit run 12 #570

jared referenced this issue

2026-09-14 14:46:24 +00:00

Responsibility-refactor batch 2 on project.rb from re-audit run 12 #570

jared commented

2026-09-14 14:46:36 +00:00

Author

Owner

Work started via /os-sdlc:responsibility-refactor batch 2 (map #570). Branch: ticket-574, worktree .claude/worktrees/ticket-574, map poodr-ticket-implementation.yaml.

jared commented

2026-09-14 15:04:49 +00:00

Author

Owner

Resolution

Done: Project::Layout (project/layout.rb) owns code?, test?, code_prefix, test_prefix, tests_for; tests_for raises ArgumentError for a path outside code_path; Layout::TestCandidates resolves existing → scenario-split → HarnessError. Project#tests_for and Project::Changes delegate. ADR-0180 amends ADR-0174.

Evidence: Merged to main a26ebb3 (code 4ca0e83). Suite 1228 runs, 0 failures; rubocop clean on 5 touched files; pre-tool-use hook smoke test still denies; rg for inline test_path}/ and code_path}/ under lib returns only project/layout.rb. Pipeline: 7 dispatches, 594 s, ended implementation_failed verdict:error. Cause: the gate could not map tests/project_layout_test.rb to project/layout.rb (harness test-mapping gap, same family as #535), and the accepted tests plus one existing test (project_tests_for_test.rb) encoded the old unanchored behavior. Hand-finished: moved the test to tests/project/layout_test.rb, rewrote inputs to anchored paths, extracted TestCandidates to satisfy the ParameterThreaded cop. No contract-auditor/refactorer rounds ran. Position 3 of 4 on map #570.

Follow-ups: Structural follow-through partially applied by decision recorded in ADR-0180: ScopePolicy#test_path? and GreenAssertFailureSidecar#under_test_path? keep segment-match regexes (absolute and subtree-relative inputs); LintWorklistTarget#code_dir is a join, not a classification. No ticket: the re-audit after #572 decides whether these still read as duplicate classification. Harness gap (gate cannot map an unnamespaced test file for a nested class) is covered by #535's family; not re-filed.

## Resolution **Done:** Project::Layout (project/layout.rb) owns code?, test?, code_prefix, test_prefix, tests_for; tests_for raises ArgumentError for a path outside code_path; Layout::TestCandidates resolves existing → scenario-split → HarnessError. Project#tests_for and Project::Changes delegate. ADR-0180 amends ADR-0174. **Evidence:** Merged to main a26ebb3 (code 4ca0e83). Suite 1228 runs, 0 failures; rubocop clean on 5 touched files; pre-tool-use hook smoke test still denies; rg for inline test_path}/ and code_path}/ under lib returns only project/layout.rb. Pipeline: 7 dispatches, 594 s, ended implementation_failed verdict:error. Cause: the gate could not map tests/project_layout_test.rb to project/layout.rb (harness test-mapping gap, same family as #535), and the accepted tests plus one existing test (project_tests_for_test.rb) encoded the old unanchored behavior. Hand-finished: moved the test to tests/project/layout_test.rb, rewrote inputs to anchored paths, extracted TestCandidates to satisfy the ParameterThreaded cop. No contract-auditor/refactorer rounds ran. Position 3 of 4 on map #570. **Follow-ups:** Structural follow-through partially applied by decision recorded in ADR-0180: ScopePolicy#test_path? and GreenAssertFailureSidecar#under_test_path? keep segment-match regexes (absolute and subtree-relative inputs); LintWorklistTarget#code_dir is a join, not a classification. No ticket: the re-audit after #572 decides whether these still read as duplicate classification. Harness gap (gate cannot map an unnamespaced test file for a nested class) is covered by #535's family; not re-filed.

jared closed this issue

2026-09-14 15:04:49 +00:00

jared referenced this issue

2026-09-14 15:04:50 +00:00

Responsibility-refactor batch 2 on project.rb from re-audit run 12 #570

jared referenced this issue from a commit

2026-09-14 15:34:06 +00:00

refactor(os-sdlc): Project::Layout owns the code/test path convention; tests_for refuses paths outside code_path (#574)

jared referenced this issue from a commit

2026-09-14 15:34:06 +00:00

docs(adr): ADR-0180 Project::Layout owns the code/test path convention (#574)

jared referenced this issue from a commit