project.rb: pass target: in BriefFacts#project; keep false values in Project.upsert

jared commented

2026-09-13 23:18:03 +00:00

Owner

Context

Responsibility audit of project.rb on 2026-09-13 found two guard defects that move no ownership. Batch position 1 of 4. Runs first. The map ticket names the order.

Observed

BriefFacts#project calls Project::Source.for(implementation) without target:. GateCommands#project passes it. The fallback becomes Project.load(root, target: nil), which raises TargetSelectionError on any targets-shaped project.
Project.upsert drops a false value, so commit_on_complete: false can never be written or cleared.

plugins/os-sdlc/lib/os_sdlc/runner/brief_facts.rb:32   Project::Source.for(implementation)
plugins/os-sdlc/lib/os_sdlc/project.rb:110             h[key.to_s] = value if value

Reproduce

cd plugins/os-sdlc && ruby -Ilib -e 'require "os_sdlc"; p OsSdlc::Project.upsert(Dir.pwd, commit_on_complete: false)'

Then inspect .sdlc/project.yaml: no commit_on_complete key is written.

Expected

def test_upsert_writes_false_values
  Project.upsert(dir, commit_on_complete: false)
  assert_equal false, YAML.safe_load_file(Project.yaml_path(dir))["commit_on_complete"]
end

def test_brief_facts_project_passes_target
  # BriefFacts#project on a targets-shaped project with a bound target does not raise TargetSelectionError
end

Tasks

Failing test: upsert keeps a false value
Fix project.rb:110 to unless value.nil?
Failing test: BriefFacts#project on a targets-shaped project with a bound target
Pass target: in brief_facts.rb:32 the same way GateCommands does

Acceptance criteria

Both tests green; full suite green
ADR case: completes ADR-0169 (target: required on every load). No ADR work.

Origin

Trigger: /os-sdlc:responsibility-audit plugins/os-sdlc/lib/os_sdlc/project.rb on 2026-09-13; analysis at .sdlc/tmp/responsibility-audit/2026-09-13-project/analysis.yaml
Improvised this session: none
Chain: mixed responsibilities in OsSdlc::Project ← DESIGN (plugins/os-sdlc/lib/os_sdlc/project.rb, ADR-0055/0074/0088/0169/0174)
Root candidate: this ticket
Where: OsSdlc::Project, plugins/os-sdlc/lib/os_sdlc/project.rb
Session: c72ac6a8-cb89-4b97-904d-155babd2a7a2
Transcript: /home/jared/.claude/projects/-home-jared-dev-cc-os/c72ac6a8-cb89-4b97-904d-155babd2a7a2.jsonl

Map: #568 ## Context Responsibility audit of `project.rb` on 2026-09-13 found two guard defects that move no ownership. Batch position 1 of 4. Runs first. The map ticket names the order. ## Observed `BriefFacts#project` calls `Project::Source.for(implementation)` without `target:`. `GateCommands#project` passes it. The fallback becomes `Project.load(root, target: nil)`, which raises `TargetSelectionError` on any targets-shaped project. `Project.upsert` drops a false value, so `commit_on_complete: false` can never be written or cleared. ``` plugins/os-sdlc/lib/os_sdlc/runner/brief_facts.rb:32 Project::Source.for(implementation) plugins/os-sdlc/lib/os_sdlc/project.rb:110 h[key.to_s] = value if value ``` ## Reproduce ``` cd plugins/os-sdlc && ruby -Ilib -e 'require "os_sdlc"; p OsSdlc::Project.upsert(Dir.pwd, commit_on_complete: false)' ``` Then inspect `.sdlc/project.yaml`: no `commit_on_complete` key is written. ## Expected ```ruby def test_upsert_writes_false_values Project.upsert(dir, commit_on_complete: false) assert_equal false, YAML.safe_load_file(Project.yaml_path(dir))["commit_on_complete"] end def test_brief_facts_project_passes_target # BriefFacts#project on a targets-shaped project with a bound target does not raise TargetSelectionError end ``` ## Tasks - [ ] Failing test: upsert keeps a false value - [ ] Fix `project.rb:110` to `unless value.nil?` - [ ] Failing test: `BriefFacts#project` on a targets-shaped project with a bound target - [ ] Pass `target:` in `brief_facts.rb:32` the same way `GateCommands` does ## Acceptance criteria - Both tests green; full suite green - ADR case: completes ADR-0169 (`target:` required on every load). No ADR work. ## Origin - Trigger: `/os-sdlc:responsibility-audit plugins/os-sdlc/lib/os_sdlc/project.rb` on 2026-09-13; analysis at `.sdlc/tmp/responsibility-audit/2026-09-13-project/analysis.yaml` - Improvised this session: none - Chain: mixed responsibilities in `OsSdlc::Project` ← DESIGN (`plugins/os-sdlc/lib/os_sdlc/project.rb`, ADR-0055/0074/0088/0169/0174) - Root candidate: this ticket - Where: `OsSdlc::Project`, `plugins/os-sdlc/lib/os_sdlc/project.rb` - Session: c72ac6a8-cb89-4b97-904d-155babd2a7a2 - Transcript: /home/jared/.claude/projects/-home-jared-dev-cc-os/c72ac6a8-cb89-4b97-904d-155babd2a7a2.jsonl

jared added the

ready-for-agent

plugin/os-sdlc

filed-by/user

labels

2026-09-13 23:18:03 +00:00

jared referenced this issue

2026-09-13 23:19:10 +00:00

Map: responsibility-refactor batch 1 on project.rb (#564 #565 #566 #567) #568

jared added the

wayfinder:task

labels

2026-09-13 23:19:20 +00:00

jared referenced this issue

2026-09-13 23:19:27 +00:00

Fold Project::CandidateTestPaths into Project#tests_for with an anchored prefix strip (completes ADR-0174) #565

jared commented

2026-09-13 23:20:13 +00:00

Author

Owner

Work started via /os-sdlc:implement on branch ticket-564 (worktree). Map: #568.

jared commented

2026-09-13 23:47:43 +00:00

Author

Owner

Resolution

Done: Project.upsert keeps false values (present_attrs uses unless value.nil?). BriefFacts accepts target: through an Options Data and passes it to Project::Source.for; StartSubagent passes implementation.target.

Evidence: Pipeline implementation 1 complete: 14 dispatches, 2 contract-auditor retries, suite 1207 runs 0 failures. Commit on branch ticket-564, merged to main via worktree finish. Tests: project_test#test_upsert_writes_a_false_attribute_value_instead_of_dropping_it, brief_facts_project_source_test#test_code_changes_does_not_raise_target_selection_error_for_a_bound_target.

Follow-ups: none. Deviation: the pipeline left StartSubagent, the only production builder of BriefFacts, without a target; wired by hand after implementation_complete, suite and lint green.

## Resolution **Done:** Project.upsert keeps false values (present_attrs uses unless value.nil?). BriefFacts accepts target: through an Options Data and passes it to Project::Source.for; StartSubagent passes implementation.target. **Evidence:** Pipeline implementation 1 complete: 14 dispatches, 2 contract-auditor retries, suite 1207 runs 0 failures. Commit on branch ticket-564, merged to main via worktree finish. Tests: project_test#test_upsert_writes_a_false_attribute_value_instead_of_dropping_it, brief_facts_project_source_test#test_code_changes_does_not_raise_target_selection_error_for_a_bound_target. **Follow-ups:** none. Deviation: the pipeline left StartSubagent, the only production builder of BriefFacts, without a target; wired by hand after implementation_complete, suite and lint green.

jared closed this issue

2026-09-13 23:47:43 +00:00

jared referenced this issue

2026-09-13 23:48:43 +00:00

Map: responsibility-refactor batch 1 on project.rb (#564 #565 #566 #567) #568

jared referenced this issue from a commit

2026-09-13 23:48:49 +00:00

fix(os-sdlc): BriefFacts takes target: and StartSubagent passes it; Project.upsert keeps false values (#564)

jared referenced this issue

2026-09-14 05:59:44 +00:00

Map: responsibility-refactor batch 1 on project.rb (#564 #565 #566 #567) #568

jared referenced this issue