Wire non-blocking ticket progress and terminal comments into the os-sdlc runner #517

New issue

Open

opened 2026-08-26 20:34:54 +00:00 by jared · 2 comments

jared commented

2026-08-26 20:34:54 +00:00

Owner

Context

Replaces #436 (shrunken scope after 2026-08-26 code-probe assessment). The escalation redesign (ADR-0152, #513) plus SKILL.md orchestrator instructions now cover the blocked-drive case, but ticket-writing is prose-only: TeaTracker#blocker_comment and #add_waiting_label (plugins/os-sdlc/lib/os_sdlc/runner/tea_tracker.rb:22-37) are dead code, and a true crash (no orchestrator turn) leaves the ticket silent. User direction 2026-08-26: progress history back to the ticket as work proceeds, and comments must never block the pipeline.

Tasks

Decide comment granularity: per agent increment vs per gate/terminal event (user leans per-increment plus a close comment with commit reference and summary)
Wire TeaTracker (or successor) into Implementation.fail!/escalate! and increment landings — best-effort: tracker unreachable or no real ticket (ad-hoc/investigative work) → warn or skip, never raise, never block the drive
Close path posts commit reference + summary on the worked ticket
Pull ticket comments (not just body) at implementation-open — verify current behavior first (#500 shipped body-at-open; confirm whether comments are included) and add --comments if absent
Tests for comment paths including unreachable-tracker and no-ticket fallbacks

Acceptance criteria

A failed or escalated implementation leaves a durable trace on its real ticket when the tracker is reachable
Tracker unavailability or ticketless work never fails or blocks a drive
Implementation-open brief includes existing ticket comments

Origin

Trigger: 2026-08-26 blocking-ticket assessment of #436; code-probe evidence that TeaTracker methods are never called and crash paths leave no ticket trace
Improvised this session: none
Chain: silent ticket on abort/crash ← ticket-writing delegated to orchestrator prose only (skills/implement/SKILL.md:108-113) ← TeaTracker wired nowhere (tea_tracker.rb:22-37) ← DESIGN (ADR-0131 era, predates ADR-0152 escalation redesign)
Root candidate: this ticket

## Context Replaces #436 (shrunken scope after 2026-08-26 code-probe assessment). The escalation redesign (ADR-0152, #513) plus SKILL.md orchestrator instructions now cover the blocked-drive case, but ticket-writing is prose-only: TeaTracker#blocker_comment and #add_waiting_label (plugins/os-sdlc/lib/os_sdlc/runner/tea_tracker.rb:22-37) are dead code, and a true crash (no orchestrator turn) leaves the ticket silent. User direction 2026-08-26: progress history back to the ticket as work proceeds, and comments must never block the pipeline. ## Tasks - [ ] Decide comment granularity: per agent increment vs per gate/terminal event (user leans per-increment plus a close comment with commit reference and summary) - [ ] Wire TeaTracker (or successor) into Implementation.fail!/escalate! and increment landings — best-effort: tracker unreachable or no real ticket (ad-hoc/investigative work) → warn or skip, never raise, never block the drive - [ ] Close path posts commit reference + summary on the worked ticket - [ ] Pull ticket comments (not just body) at implementation-open — verify current behavior first (#500 shipped body-at-open; confirm whether comments are included) and add --comments if absent - [ ] Tests for comment paths including unreachable-tracker and no-ticket fallbacks ## Acceptance criteria - [ ] A failed or escalated implementation leaves a durable trace on its real ticket when the tracker is reachable - [ ] Tracker unavailability or ticketless work never fails or blocks a drive - [ ] Implementation-open brief includes existing ticket comments ## Origin - Trigger: 2026-08-26 blocking-ticket assessment of #436; code-probe evidence that TeaTracker methods are never called and crash paths leave no ticket trace - Improvised this session: none - Chain: silent ticket on abort/crash ← ticket-writing delegated to orchestrator prose only (skills/implement/SKILL.md:108-113) ← TeaTracker wired nowhere (tea_tracker.rb:22-37) ← DESIGN (ADR-0131 era, predates ADR-0152 escalation redesign) - Root candidate: this ticket

jared added the

plugin/os-sdlc

label

2026-08-26 20:34:54 +00:00

jared referenced this issue

2026-08-26 20:35:01 +00:00

Make abort mark the ticket blocked with clear details (fail-loud follow-through) #436

jared added the

category/investigation

label

2026-10-10 13:32:10 +00:00

jared commented

2026-10-18 18:59:02 +00:00

Author

Owner

The code this ticket cites is gone: plugins/os-sdlc/lib/os_sdlc/runner/tea_tracker.rb (TeaTracker#blocker_comment, #add_waiting_label) no longer exists after the move to forgejo-api (ADR-0257). The need remains: non-blocking progress and terminal comments on the ticket from the runner. Restate the ticket against the forgejo-api adapter.

jared commented

2026-10-18 19:44:07 +00:00

Author

Owner

Scope restated 2026-10-18 against the forgejo-api adapter (ADR-0257). Met: the CLI can post comments (os-backlog comment N --body, plugins/os-backlog/bin/os-backlog). Unmet: the os-sdlc runner never posts. OsSdlc::Tracker::Forgejo#blocker_comment and #add_waiting_label (plugins/os-sdlc/lib/os_sdlc/tracker/forgejo.rb:22-30) now use the forgejo gem but have no caller outside tests; Tracker::Backlog (tracker/backlog.rb:23-25) defines both as no-ops. So a failed or escalated implementation still leaves no trace on its ticket. The tasks and acceptance criteria in the body stand, except the tea_tracker.rb references: read them as tracker/forgejo.rb and tracker/backlog.rb. Task 1 (comment granularity) is still undecided.