Reviewer handoff gathers ticket, tests, diff, and gate results from the db #493

New issue

Open

opened 2026-08-23 17:48:23 +00:00 by jared · 0 comments

jared commented

2026-08-23 17:48:23 +00:00

Owner

Context

Decision from the 2026-08-23 #476 session: the reviewer should receive a complete, fresh evidence package assembled locally — ticket brief (db, faster than Forgejo), the test-writer's test list, the round's diff, and test/lint gate results — rather than gathering these itself. The programmer's gates (see diff-test/lint/suite ticket) guarantee green before handoff, so the runner can assemble everything at dispatch time, likely as an enrich step or a starting-gate <dispatch_id>-style gather command. Design is directional; shape the exact mechanism during decomposition.

Tasks

Decide mechanism: extend the enrich pipeline (reviewer node already has enrich: [ticket_brief, gate_results]) vs a runner gather command the reviewer invokes.
Include the round diff and the diffed-file contents in the reviewer's package.
Ensure gate results in the package are from the settled (green) programmer round, not stale.
Consider the same diff enrichment for the programmer's brief (test-writer diff + files).

Acceptance criteria

A reviewer dispatch contains ticket, test list, diff, and green gate evidence with no tracker or test-suite calls by the reviewer.

Origin

Trigger: #476 grilling session 2026-08-23, gate redesign discussion.
Improvised this session: none.
Chain: reviewer self-gathers evidence ← enrich set limited to ticket_brief + gate_results (poodr-implementation.yaml:86, 101) ← DESIGN (enrich vocabulary built for gate feedback, not evidence packages).
Root candidate: this ticket.

## Context Decision from the 2026-08-23 #476 session: the reviewer should receive a complete, fresh evidence package assembled locally — ticket brief (db, faster than Forgejo), the test-writer's test list, the round's diff, and test/lint gate results — rather than gathering these itself. The programmer's gates (see diff-test/lint/suite ticket) guarantee green before handoff, so the runner can assemble everything at dispatch time, likely as an enrich step or a `starting-gate <dispatch_id>`-style gather command. Design is directional; shape the exact mechanism during decomposition. ## Tasks - [ ] Decide mechanism: extend the enrich pipeline (reviewer node already has enrich: [ticket_brief, gate_results]) vs a runner gather command the reviewer invokes. - [ ] Include the round diff and the diffed-file contents in the reviewer's package. - [ ] Ensure gate results in the package are from the settled (green) programmer round, not stale. - [ ] Consider the same diff enrichment for the programmer's brief (test-writer diff + files). ## Acceptance criteria - [ ] A reviewer dispatch contains ticket, test list, diff, and green gate evidence with no tracker or test-suite calls by the reviewer. ## Origin - Trigger: #476 grilling session 2026-08-23, gate redesign discussion. - Improvised this session: none. - Chain: reviewer self-gathers evidence ← enrich set limited to ticket_brief + gate_results (poodr-implementation.yaml:86, 101) ← DESIGN (enrich vocabulary built for gate feedback, not evidence packages). - Root candidate: this ticket.

jared added the

plugin/os-sdlc

label

2026-08-23 17:48:23 +00:00

jared referenced this issue

2026-08-23 17:48:46 +00:00

Decide target resolution for the session-less os-sdlc CLI (red-assert/green-assert TargetFlag) #476

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

jared/cc-os#493

No description provided.

Rows
Columns