Delete prose-wording assertions from the 8 os-sdlc agent tests #485

New issue

Closed

opened 2026-08-23 13:48:25 +00:00 by jared · 2 comments

jared commented

2026-08-23 13:48:25 +00:00

Owner

Context

All 8 plugins/os-sdlc/tests/*_agent_test.rb files (code_probe, behavior_verifier, change_interpreter, contract_auditor, message_tracer, refactorer, seam_designer, test_reviewer) regex-match exact description prose (e.g. /single job/i); any meaning-preserving reword breaks them. Origin investigation confirmed a one-off pattern introduced in commit 4317a4d (ticket #352) and copied 7 times — no template or rule instructs it, so no guardrail is wanted, just deletion. 4 of these tests currently fail after intentional description trims.

Tasks

In each of the 8 files, delete assertions matching sentence wording of description/instruction prose.
Keep frontmatter contract checks (model:, color:, tools/skill grants) and output-schema token checks (e.g. /verdict:/, /BEHAVIOR:/, enum tokens).
Run the suite; confirm the 4 current description-test failures are gone and no others appear.

Acceptance criteria

suite green with respect to agent tests; no assert on prose wording remains.

Origin

Trigger: manual full-suite run of plugins/os-sdlc tests on 2026-08-23 (77.9s, 1 failure) prompting a root-cause probe session
Improvised: none (user hand-trimmed descriptions; failures left red)
Chain: red agent tests ← prose-coupled assertions ← one-off copied test pattern from commit 4317a4d — IMPROVISATION (commit 4317a4d, ticket #352)
Root candidate: this ticket

## Context All 8 plugins/os-sdlc/tests/*_agent_test.rb files (code_probe, behavior_verifier, change_interpreter, contract_auditor, message_tracer, refactorer, seam_designer, test_reviewer) regex-match exact description prose (e.g. /single job/i); any meaning-preserving reword breaks them. Origin investigation confirmed a one-off pattern introduced in commit 4317a4d (ticket #352) and copied 7 times — no template or rule instructs it, so no guardrail is wanted, just deletion. 4 of these tests currently fail after intentional description trims. ## Tasks - [ ] In each of the 8 files, delete assertions matching sentence wording of description/instruction prose. - [ ] Keep frontmatter contract checks (model:, color:, tools/skill grants) and output-schema token checks (e.g. /verdict:/, /BEHAVIOR:/, enum tokens). - [ ] Run the suite; confirm the 4 current description-test failures are gone and no others appear. ## Acceptance criteria suite green with respect to agent tests; no assert on prose wording remains. ## Origin - Trigger: manual full-suite run of plugins/os-sdlc tests on 2026-08-23 (77.9s, 1 failure) prompting a root-cause probe session - Improvised: none (user hand-trimmed descriptions; failures left red) - Chain: red agent tests ← prose-coupled assertions ← one-off copied test pattern from commit 4317a4d — IMPROVISATION (commit 4317a4d, ticket #352) - Root candidate: this ticket

jared added the

plugin/os-sdlc

labels

2026-08-23 13:48:25 +00:00

jared commented

2026-08-23 14:36:49 +00:00

Author

Owner

Work started: deleting prose-wording assertions per agreed bright-line rule (batch session 2026-08-23).

jared commented

2026-08-23 14:38:47 +00:00

Author

Owner

Resolution

Done: Deleted all prose-wording assertions from the 8 os-sdlc agent test files per the agreed bright-line rule: only frontmatter contract checks and output-schema token checks remain.

Evidence: Commit 4ff66cc: 8 files changed, 268 deletions, 0 additions. Targeted runs of all 8 agent test files green; the 4 previously-red files (behavior_verifier, contract_auditor, message_tracer, test_reviewer) now pass.

Follow-ups: none

## Resolution **Done:** Deleted all prose-wording assertions from the 8 os-sdlc agent test files per the agreed bright-line rule: only frontmatter contract checks and output-schema token checks remain. **Evidence:** Commit 4ff66cc: 8 files changed, 268 deletions, 0 additions. Targeted runs of all 8 agent test files green; the 4 previously-red files (behavior_verifier, contract_auditor, message_tracer, test_reviewer) now pass. **Follow-ups:** none

jared closed this issue

2026-08-23 14:38:47 +00:00

jared referenced this issue from a commit

2026-08-23 18:31:46 +00:00

docs(os-sdlc): trim agent descriptions to benefit-led one-liners

jared referenced this issue from a commit

2026-08-23 18:31:46 +00:00

chore(os-sdlc): add frozen_string_literal pragmas and scoped parser warning filter

jared referenced this issue from a commit

2026-08-23 18:31:46 +00:00

test(os-sdlc): delete prose-wording assertions from agent tests (#485)