Build #438 slice 5: fail edges, LoopLedger bounds, error-node routing

jared commented

2026-08-20 14:32:01 +00:00

Owner

Parent

#438 (map-driven os-sdlc runner build spec). Design: docs/os-sdlc-rebuild/map-runner-design.md. Settled decisions + guard-manifest process: docs/os-sdlc-rebuild/interface-sketches.md.

Pre-build gate

First step before any code: run the seam-design pass per docs/os-sdlc-rebuild/seam-design-prompt.md to produce this slice's interface sketch. The sketch is the guard manifest: any class, public method, or signature change beyond it → stop, comment on this ticket, do not write it.

What to build

Routing follows fail edges per the map; per-edge loop bounds act as anti-infinite-loop traversal guards (never implementation retries — ADR-0133); an exhausted bound routes loudly to the map-declared error node, which itself routes per the map. No skippable vocabulary anywhere. Sketch-time decision to settle: the ledger lives in NextStep per the amended design doc (D4 — spend! is a write), reconciling the stale Router-constructor comment in the slice-4 sketch.

Acceptance criteria

A fail verdict follows the map's fail edge
Bound exhaustion routes to the error node with a loud, named payload (red test)
Error node routes onward per its own map edges to the failed terminal
No skip/skippable vocabulary in code, payloads, or docs touched by this slice

Blocked by

#443

Origin

Trigger: /to-tickets decomposition of #438 (2026-08-20, user-directed)
Improvised this session: none
Chain: DESIGN (docs/os-sdlc-rebuild/map-runner-design.md, docs/os-sdlc-rebuild/interface-sketches.md, ADR-0133/0134/0135)
Root candidate: #438

## Parent #438 (map-driven os-sdlc runner build spec). Design: docs/os-sdlc-rebuild/map-runner-design.md. Settled decisions + guard-manifest process: docs/os-sdlc-rebuild/interface-sketches.md. ## Pre-build gate First step before any code: run the seam-design pass per docs/os-sdlc-rebuild/seam-design-prompt.md to produce this slice's interface sketch. The sketch is the guard manifest: any class, public method, or signature change beyond it → stop, comment on this ticket, do not write it. ## What to build Routing follows fail edges per the map; per-edge loop bounds act as anti-infinite-loop traversal guards (never implementation retries — ADR-0133); an exhausted bound routes loudly to the map-declared error node, which itself routes per the map. No skippable vocabulary anywhere. Sketch-time decision to settle: the ledger lives in NextStep per the amended design doc (D4 — spend! is a write), reconciling the stale Router-constructor comment in the slice-4 sketch. ## Acceptance criteria - [ ] A fail verdict follows the map's fail edge - [ ] Bound exhaustion routes to the error node with a loud, named payload (red test) - [ ] Error node routes onward per its own map edges to the failed terminal - [ ] No skip/skippable vocabulary in code, payloads, or docs touched by this slice ## Blocked by - #443 ## Origin - Trigger: /to-tickets decomposition of #438 (2026-08-20, user-directed) - Improvised this session: none - Chain: DESIGN (docs/os-sdlc-rebuild/map-runner-design.md, docs/os-sdlc-rebuild/interface-sketches.md, ADR-0133/0134/0135) - Root candidate: #438

jared added the

plugin/os-sdlc

ready-for-agent

labels

2026-08-20 14:32:01 +00:00

jared referenced this issue

2026-08-20 14:32:16 +00:00

Build #438 slice 6: coding map replaces the toy map #445

jared referenced this issue

2026-08-20 21:03:07 +00:00

Build #438 slice 4: next routes the map (tracer bullet) #443

jared commented

2026-08-20 21:57:15 +00:00

Author

Owner

Work started: slice 5 via the TDD loop, branch build/438-slice-5 to follow. User gave tracer go after slice 4; seam-design pass running first per the pre-build gate, covering the two carried questions (routing-only agent: null nodes; implementation_failed terminal ownership) plus the loop ledger deferred from D4.

jared commented

2026-08-20 22:31:03 +00:00

Author

Owner

Resolution

Done: Slice 5 built TDD-first on build/438-slice-5, merged to main at 7a4865f. LoopLedger spends bounded map edges per (implementation, from_node, verdict) with rows only for bounded edges (D27, schema 10 edge_spends, failed_step renamed failed_reason); exhaustion re-routes through the node's error edge via the existing Router seam (D26); routing-only agent:null nodes transit in the same next call, never dispatched (D24); RoutingApplier owns Implementation.fail! with named reasons like bound_exhausted:node/verdict (D28/D30); repeated next after failure is byte-identical idempotent (D29); dead-pocket validation relaxed to every-node-reaches-a-terminal (OQ1-A, amending D1) with dead_pocket.yaml rewritten; escalation-node shape deferred to slice 6 (OQ2-A).

Evidence: ruby -Ilib tests/all.rb: 842 runs, 2151 assertions, 0 failures (verified by orchestrator). rubocop zero offenses on all 11 dirty files, no disables. New loop_ledger_test.rb (6), bounded_loop.yaml exhaustion walk incl. named-reason terminal payload and no-new-rows repeat.

Follow-ups: Slice-6 seam pass owes the escalation-node shape (OQ2-A deferral) and the first real coding map + AgentVerdict. map-runner-design.md §1.6 stale pseudocode (route arity, spend!(position), map.error_decision) is owned by the slice-7 doc sweep. No new tickets filed; both owners are existing #438 child tickets.

## Resolution **Done:** Slice 5 built TDD-first on build/438-slice-5, merged to main at 7a4865f. LoopLedger spends bounded map edges per (implementation, from_node, verdict) with rows only for bounded edges (D27, schema 10 edge_spends, failed_step renamed failed_reason); exhaustion re-routes through the node's error edge via the existing Router seam (D26); routing-only agent:null nodes transit in the same next call, never dispatched (D24); RoutingApplier owns Implementation.fail! with named reasons like bound_exhausted:node/verdict (D28/D30); repeated next after failure is byte-identical idempotent (D29); dead-pocket validation relaxed to every-node-reaches-a-terminal (OQ1-A, amending D1) with dead_pocket.yaml rewritten; escalation-node shape deferred to slice 6 (OQ2-A). **Evidence:** ruby -Ilib tests/all.rb: 842 runs, 2151 assertions, 0 failures (verified by orchestrator). rubocop zero offenses on all 11 dirty files, no disables. New loop_ledger_test.rb (6), bounded_loop.yaml exhaustion walk incl. named-reason terminal payload and no-new-rows repeat. **Follow-ups:** Slice-6 seam pass owes the escalation-node shape (OQ2-A deferral) and the first real coding map + AgentVerdict. map-runner-design.md §1.6 stale pseudocode (route arity, spend!(position), map.error_decision) is owned by the slice-7 doc sweep. No new tickets filed; both owners are existing #438 child tickets.

jared closed this issue

2026-08-20 22:31:03 +00:00

jared referenced this issue from a commit

2026-08-21 13:42:57 +00:00

feat(os-sdlc): bounded loops and failure terminals (#444)

jared referenced this issue from a commit

2026-08-21 13:42:57 +00:00

docs(os-sdlc): history row for #438 slice 5 (#444)