os-sdlc: green-assert failure log cached on artifact is never refreshed on later failures #306

New issue

Closed

opened 2026-08-07 11:35:27 +00:00 by jared · 1 comment

jared commented

2026-08-07 11:35:27 +00:00

Owner

Context

Surfaced during the /os-sdlc:implement run for #300: the first green-assert failure's log tail is stored on artifact.yml and embedded in retry briefs, but a second, different green-assert failure did not replace it — the round-2 test-writer brief embedded the round-1 log (752 runs / 5 failures) instead of the current one (756 runs / 2 failures), while the ADR-0098 sidecar green-assert-failure.json WAS current. Fix: refresh the stored failure-log text on every failed green-assert, not just the first.

## Context Surfaced during the /os-sdlc:implement run for #300: the first green-assert failure's log tail is stored on artifact.yml and embedded in retry briefs, but a second, different green-assert failure did not replace it — the round-2 test-writer brief embedded the round-1 log (752 runs / 5 failures) instead of the current one (756 runs / 2 failures), while the ADR-0098 sidecar green-assert-failure.json WAS current. Fix: refresh the stored failure-log text on every failed green-assert, not just the first.

jared added the

label

2026-08-07 11:35:27 +00:00

jared commented

2026-08-07 11:51:07 +00:00

Author

Owner

Resolution

Done: Green-assert retry briefs read failure output from the ADR-0098 sidecar (rewritten on every failed run) instead of the shell-redirected log file that could lag a round behind.

Evidence: Commit 9446f79 on main; failing test reproduced two-round staleness then went green; suite 751 runs / 0 failures; rubocop clean.

Follow-ups: red-assert and ac-lint retries still read their shell-redirected .log files and could lag the same way if the dispatcher misnames the redirect — surfaced to user, not filed (only occurs on dispatcher error; medium-low likelihood).

## Resolution **Done:** Green-assert retry briefs read failure output from the ADR-0098 sidecar (rewritten on every failed run) instead of the shell-redirected log file that could lag a round behind. **Evidence:** Commit 9446f79 on main; failing test reproduced two-round staleness then went green; suite 751 runs / 0 failures; rubocop clean. **Follow-ups:** red-assert and ac-lint retries still read their shell-redirected .log files and could lag the same way if the dispatcher misnames the redirect — surfaced to user, not filed (only occurs on dispatcher error; medium-low likelihood).

jared closed this issue

2026-08-07 11:51:07 +00:00

jared referenced this issue

2026-08-07 12:15:57 +00:00

os-sdlc shard-plan: code_files heuristic resolves to tests/test_helper.rb instead of production files #300

jared referenced this issue from a commit

2026-08-09 13:15:36 +00:00

Fix green-assert retry briefs to read from sidecar