jared/cc-os

Watch

Fork 0

os-sdlc: review-packet shows '(no changes)' diff for untracked new files; duplicate gate-log lines #265

New issue

Closed

opened 2026-08-04 17:10:21 +00:00 by jared · 3 comments

jared commented

2026-08-04 17:10:21 +00:00

Owner

Observed during cc-plugins ticket #52: the review packet's diff section printed "(no changes)" even though the ticket created 13 new (untracked, uncommitted) files under the renderer subproject — the reviewer had to read files directly, losing the packet's provenance guarantee. Likely the packet diffs tracked changes only; it should include untracked files (e.g. git add -N or --include-untracked equivalent). Separately, the gate log showed a duplicated "green-assert iteration=1" line.

Discoverer: /home/jared/dev/cc-plugins, session f5ddde9c-d7ed-4bda-bc17-a955aa39cec3, 2026-08-04. Reviewer flagged packet provenance gap live during ticket 52.

jared added the

bug

ready-for-agent

update

labels

2026-08-04 17:27:07 +00:00

jared commented

2026-08-04 17:27:14 +00:00

Author

Owner

Triage: diff claim confirmed — bin/os-sdlc:881 runs plain git diff HEAD, so untracked new files are invisible and an all-new-files ticket prints '(no changes)'. Duplicate green-assert gate-log line NOT reproducible in code (single write site, run_gate at bin/os-sdlc:91-97); scope this ticket to the diff fix, treat the log dupe as unconfirmed.

Triage: diff claim confirmed — bin/os-sdlc:881 runs plain `git diff HEAD`, so untracked new files are invisible and an all-new-files ticket prints '(no changes)'. Duplicate green-assert gate-log line NOT reproducible in code (single write site, run_gate at bin/os-sdlc:91-97); scope this ticket to the diff fix, treat the log dupe as unconfirmed.

jared referenced this issue

2026-08-04 17:38:48 +00:00

os-sdlc: bring bin/ scripts under lint coverage (bin/os-sdlc is 1075 unlinted lines) [capture] #267

jared commented

2026-08-04 17:39:19 +00:00

Author

Owner

Work started: review-packet diff to include untracked files, bin/os-sdlc + lib extraction

jared commented

2026-08-04 17:47:18 +00:00

Author

Owner

Resolution

Done: Review-packet diff now includes untracked new files: extracted OsSdlc::ReviewPacketDiff (tracked git diff HEAD + per-file git diff --no-index vs /dev/null for untracked, tmp excluded, fully non-mutating), wired into bin/os-sdlc. Gate-log-duplicate half not reproducible in code — excluded from scope per triage comment.

Evidence: plugins/os-sdlc/lib/os_sdlc/review_packet_diff.rb + tests/review_packet_diff_test.rb + bin-level regression test in tests/hardening_preflight_review_packet_test.rb; suite 600 runs 0 failures; rubocop clean on touched files.

Follow-ups: gate-log duplicate line left unconfirmed — reopen or refile only if observed again live; test-helper with_git_repo duplication dropped as trivial

## Resolution **Done:** Review-packet diff now includes untracked new files: extracted OsSdlc::ReviewPacketDiff (tracked git diff HEAD + per-file git diff --no-index vs /dev/null for untracked, tmp excluded, fully non-mutating), wired into bin/os-sdlc. Gate-log-duplicate half not reproducible in code — excluded from scope per triage comment. **Evidence:** plugins/os-sdlc/lib/os_sdlc/review_packet_diff.rb + tests/review_packet_diff_test.rb + bin-level regression test in tests/hardening_preflight_review_packet_test.rb; suite 600 runs 0 failures; rubocop clean on touched files. **Follow-ups:** gate-log duplicate line left unconfirmed — reopen or refile only if observed again live; test-helper with_git_repo duplication dropped as trivial

jared closed this issue

2026-08-04 17:47:18 +00:00

jared referenced this issue from a commit

2026-08-04 17:51:20 +00:00

Extract review packet diff logic and establish lint-fixer agent

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

jared/cc-os#265

No description provided.

Rows
Columns