Lint#resolve_config_path has the same missing-.rubocop.yml failure shape fixed in AutocorrectPrepass (#229) #235

New issue

Closed

opened 2026-08-02 15:02:04 +00:00 by jared · 2 comments

jared commented

2026-08-02 15:02:04 +00:00

Owner

plugins/os-sdlc/lib/os_sdlc/lint.rb resolve_config_path points rubocop at a possibly-missing .rubocop.yml, same shape as the pre-#229 AutocorrectPrepass bug. Consider routing it through the LintWorklistRubocopConfig merged chain (ADR-0082). Also worth an end-to-end CLI fixture for autocorrect against a project with no .rubocop.yml anywhere.

jared commented

2026-08-02 21:09:24 +00:00

Author

Owner

Fourth rediscovery, 2026-08-02, during #236 pipeline run: os-sdlc lint 236 --target os-sdlc reported 710 offenses / 78 files (near-stock cops) while rubocop --config plugins/os-sdlc/.rubocop.yml plugins/os-sdlc/lib on the same files reports 0. Cause confirmed: lint_command never passes project.lint_config; Lint#call has no param for it; resolve_config_path prefers root .rubocop.yml. grep confirms lint_config is read nowhere outside project.rb. Incident class also covers #196/#215/#229; fix direction: single config authority (extend LintWorklistRubocopConfig, fold lint_config into chain) + ADR.

Fourth rediscovery, 2026-08-02, during #236 pipeline run: `os-sdlc lint 236 --target os-sdlc` reported 710 offenses / 78 files (near-stock cops) while `rubocop --config plugins/os-sdlc/.rubocop.yml plugins/os-sdlc/lib` on the same files reports 0. Cause confirmed: lint_command never passes project.lint_config; Lint#call has no param for it; resolve_config_path prefers root .rubocop.yml. grep confirms lint_config is read nowhere outside project.rb. Incident class also covers #196/#215/#229; fix direction: single config authority (extend LintWorklistRubocopConfig, fold lint_config into chain) + ADR.

jared commented

2026-08-03 12:42:33 +00:00

Author

Owner

Fixed and merged to main (26a7a49). Lint routes through LintWorklistRubocopConfig; Project#resolved_lint_config is the single resolver; custom lint_config wins outright, missing explicit config fails loud. Reviewer (opus) APPROVE. Post-merge verification: lint gate now 0 offenses on the same 78 files that showed 710. ADR-0091 records the decision.

Fixed and merged to main (26a7a49). Lint routes through LintWorklistRubocopConfig; Project#resolved_lint_config is the single resolver; custom lint_config wins outright, missing explicit config fails loud. Reviewer (opus) APPROVE. Post-merge verification: lint gate now 0 offenses on the same 78 files that showed 710. ADR-0091 records the decision.

jared closed this issue

2026-08-03 12:42:35 +00:00

jared referenced this issue

2026-08-03 13:04:15 +00:00

Retire custom_lint_config? sentinel string-compare in LintWorklistRubocopConfig #238

jared referenced this issue from a commit

2026-08-03 13:52:17 +00:00

Route Lint through LintWorklistRubocopConfig single config authority (#235)

jared referenced this issue from a commit

2026-08-03 13:52:17 +00:00

Record ADR-0091 and #235 fix in os-sdlc status leaf

jared referenced this issue