reviewer charter: dropped-noun disclosure, mandatory judgment-residue section, lint-induced-test flagging

jared commented

2026-08-01 14:06:09 +00:00

Owner

Migrated from jared/os-sdlc#23 (repo being retired).

Problem

Run 3's pipeline reviewer approved with, verbatim (records/run-18/18.yml, reviewer_verdict_raw):

Verification notes (scope: spec fidelity and test relevance only):
...

Every interpretive choice that could have hidden a fail-open gap is disclosed

Both council members rejected parts of this: two interpretive choices were NOT disclosed (ticket said "persisted history" — shipped in-memory only, silently; ticket said "CLI/class" — shipped class-only, silently), and the reviewer scoped itself away from the judgment-facet review the standards doc assigns it ("the reviewer polices the choices within them").

Charter additions (judgment residue, not lint rules)

Dropped-noun disclosure check: for every load-bearing noun in the ticket, either the run implements it, a disclosure records the interpretive choice to drop/narrow it, or the reviewer flags it. Silence is a finding.
Judgment-residue section is mandatory: the verdict must contain a disposition on design judgment (SRP, dependency injection, public-interface width). "Scope: spec fidelity only" self-limitation is not permitted.
Lint-induced tests are flagged, not endorsed: a test added solely to satisfy a lint is reported as such, including whether the lint demand looked like a false positive.

Provenance

Council review of run 3, 2026-07-21 — convergent (Fable findings 1/7/8 + verdict section; Codex findings 2/3/6). Records: records/run-18/.

Current state check (2026-08-01)

plugins/os-sdlc/agents/reviewer.md (model: opus) currently covers only a narrower version of item 1: it requires disclosure of undisclosed fail-open defaults, not general dropped/narrowed load-bearing nouns. Items 2 (mandatory judgment-residue section: SRP/DI/public-interface width) and 3 (lint-induced tests flagged) are absent from the current charter. Update plugins/os-sdlc/agents/reviewer.md to add the missing dropped-noun generalization plus the two missing sections.

Related: cc-os#197 (pipeline hardening spec) does not touch the reviewer's judgment charter — this is a separate, non-overlapping change to agents/reviewer.md.

Migrated from jared/os-sdlc#23 (repo being retired). ## Problem Run 3's pipeline reviewer approved with, verbatim (records/run-18/18.yml, reviewer_verdict_raw): Verification notes (scope: spec fidelity and test relevance only): ... - Every interpretive choice that could have hidden a fail-open gap is disclosed Both council members rejected parts of this: two interpretive choices were NOT disclosed (ticket said "persisted history" — shipped in-memory only, silently; ticket said "CLI/class" — shipped class-only, silently), and the reviewer scoped itself away from the judgment-facet review the standards doc assigns it ("the reviewer polices the choices within them"). ## Charter additions (judgment residue, not lint rules) 1. **Dropped-noun disclosure check:** for every load-bearing noun in the ticket, either the run implements it, a disclosure records the interpretive choice to drop/narrow it, or the reviewer flags it. Silence is a finding. 2. **Judgment-residue section is mandatory:** the verdict must contain a disposition on design judgment (SRP, dependency injection, public-interface width). "Scope: spec fidelity only" self-limitation is not permitted. 3. **Lint-induced tests are flagged, not endorsed:** a test added solely to satisfy a lint is reported as such, including whether the lint demand looked like a false positive. ## Provenance Council review of run 3, 2026-07-21 — convergent (Fable findings 1/7/8 + verdict section; Codex findings 2/3/6). Records: records/run-18/. ## Current state check (2026-08-01) plugins/os-sdlc/agents/reviewer.md (model: opus) currently covers only a narrower version of item 1: it requires disclosure of undisclosed fail-open defaults, not general dropped/narrowed load-bearing nouns. Items 2 (mandatory judgment-residue section: SRP/DI/public-interface width) and 3 (lint-induced tests flagged) are absent from the current charter. Update plugins/os-sdlc/agents/reviewer.md to add the missing dropped-noun generalization plus the two missing sections. Related: cc-os#197 (pipeline hardening spec) does not touch the reviewer's judgment charter — this is a separate, non-overlapping change to agents/reviewer.md.

jared added the

labels

2026-08-01 16:38:38 +00:00

jared commented

2026-08-01 16:45:27 +00:00

Author

Owner

This was generated by AI during triage.

Keeping — items 2/3 are genuinely absent from plugins/os-sdlc/agents/reviewer.md. One addition for the implementer: item 2 ("scope: spec fidelity only is not permitted") cannot be fixed by editing the charter body alone — reviewer.md's own frontmatter description says "spec fidelity and test relevance only," and that description is what's registered/propagated for the subagent. Update the frontmatter description alongside the body, or the self-limitation will persist.

> *This was generated by AI during triage.* Keeping — items 2/3 are genuinely absent from plugins/os-sdlc/agents/reviewer.md. One addition for the implementer: item 2 ("scope: spec fidelity only is not permitted") cannot be fixed by editing the charter body alone — reviewer.md's own frontmatter description says "spec fidelity and test relevance only," and that description is what's registered/propagated for the subagent. Update the frontmatter description alongside the body, or the self-limitation will persist.

jared referenced this issue

2026-08-01 20:47:30 +00:00

Reviewer charter: flag lint-induced tests (split from #199, awaiting incident) #228

jared commented

2026-08-01 20:47:49 +00:00

Author

Owner

Items 1+2 (dropped-noun disclosure + design-judgment scope, incl. frontmatter description fix) being implemented as a direct charter prose edit on branch worktree-lint-cop-ticket-triage. Item 3 split to #228.

jared commented

2026-08-01 20:54:23 +00:00

Author

Owner

Items 1+2 shipped: charter prose edit merged to main (commits 07263c0 + 4b59461, merge 19b281c), aidd-lint clean, plugins refreshed. Item 3 tracked in #228.

Items 1+2 shipped: charter prose edit merged to main (commits 07263c0 + 4b59461, merge 19b281c), aidd-lint clean, plugins refreshed. Item 3 tracked in #228.

jared closed this issue

2026-08-01 20:54:26 +00:00

jared referenced this issue from a commit

2026-08-01 21:32:50 +00:00

Widen os-sdlc reviewer charter to design judgment (#199 items 1-2)

jared referenced this issue from a commit

2026-08-01 21:32:50 +00:00

Merge lint-cop-ticket-triage: reviewer charter widened to design judgment (#199)