Move Crc NamespaceDefinitions and ParameterTypes::ArgumentType onto CodeShape #1733

New issue

Open

opened 2026-11-12 21:37:46 +00:00 by jared · 1 comment

jared commented

2026-11-12 21:37:46 +00:00

Owner

Problem

Crc::Definitions and Detector::ParameterTypes::ArgumentType each carry another copy of the nesting rule and the definition table (#1718). Blocked by #1729.

Observed

crc/definitions/namespace_definitions.rb:15-37 qualifies names recursively and does not handle Class.new or Data; it reads one file at a time. detector/parameter_types/argument_type.rb:39 is the latest copy of the nesting rule.

Reproduce

n/a: design finding from the ast inventory of this session (2026-11-12, plugins/os-sdlc/lib).

Approach

Not decided; the takedown designs it. Both read from CodeShape and delete their own copy.

Required work: none beyond the acceptance criteria.

Origin

Trigger: split of #1718 by Jared (rulings 145 and 146 in docs/decisions/rulings.tsv, 2026-11-12) after takedown run docs/takedown/1718-20261112-160038/ failed green-suite; parent #1718
Improvised this session: none
Chain: two more copies of the nesting rule ← no object owns facts read from parsed Ruby code, so each detector, lint check, and cop writes its own copy ← DESIGN (#1718; docs/system-design-format/README.md:242)
Root candidate: none found; searched Crc NamespaceDefinitions, ParameterTypes ArgumentType, nesting rule
Where: plugins/os-sdlc/lib/os_sdlc/crc/definitions/namespace_definitions.rb, detector/parameter_types/argument_type.rb
Session: 784c0808-1e40-4296-8f93-77c40ca419c2
Transcript: /home/jared/.claude/projects/-home-jared-dev-cc-os-plugins-os-sdlc/784c0808-1e40-4296-8f93-77c40ca419c2.jsonl

VERDICT: CREATE
REASON: Jared ruled the split of #1718 (ruling 146); the backlog search found no open ticket with the same mechanism.

## Problem `Crc::Definitions` and `Detector::ParameterTypes::ArgumentType` each carry another copy of the nesting rule and the definition table (#1718). Blocked by #1729. ## Observed `crc/definitions/namespace_definitions.rb:15-37` qualifies names recursively and does not handle `Class.new` or `Data`; it reads one file at a time. `detector/parameter_types/argument_type.rb:39` is the latest copy of the nesting rule. ## Reproduce n/a: design finding from the ast inventory of this session (2026-11-12, `plugins/os-sdlc/lib`). ## Approach Not decided; the takedown designs it. Both read from `CodeShape` and delete their own copy. Required work: none beyond the acceptance criteria. ## Origin - Trigger: split of #1718 by Jared (rulings 145 and 146 in `docs/decisions/rulings.tsv`, 2026-11-12) after takedown run `docs/takedown/1718-20261112-160038/` failed green-suite; parent #1718 - Improvised this session: none - Chain: two more copies of the nesting rule ← no object owns facts read from parsed Ruby code, so each detector, lint check, and cop writes its own copy ← DESIGN (#1718; `docs/system-design-format/README.md:242`) - Root candidate: none found; searched Crc NamespaceDefinitions, ParameterTypes ArgumentType, nesting rule - Where: `plugins/os-sdlc/lib/os_sdlc/crc/definitions/namespace_definitions.rb`, `detector/parameter_types/argument_type.rb` - Session: 784c0808-1e40-4296-8f93-77c40ca419c2 - Transcript: /home/jared/.claude/projects/-home-jared-dev-cc-os-plugins-os-sdlc/784c0808-1e40-4296-8f93-77c40ca419c2.jsonl VERDICT: CREATE REASON: Jared ruled the split of #1718 (ruling 146); the backlog search found no open ticket with the same mechanism.

jared added the

plugin/os-sdlc

filed-by/user

category/code-change

labels

2026-11-12 21:37:46 +00:00

jared referenced this issue

2026-11-12 21:38:00 +00:00

Give constant names one owner: definitions, lexical resolution, and reference sites #1718

jared referenced this issue

2026-11-12 21:49:03 +00:00

Add CodeShape::Definitions and move the ConceptCycleCheck::References definition table onto it #1741