Write the missing tests for 322 os-sdlc survivors in project, collaborator_pass, and the other small directories #1664
Labels
No labels
P0
P1
P2
P3
bug
category/code-change
category/cross-repo
category/eval-run
category/investigation
category/no-test-target
category/owner-ruling
category/prose-artifact
category/recurring-chore
category/structure
category/umbrella
crc-refactor
create
delete
enhancement
filed-by/agent
filed-by/user
frozen
lint-rule
needs-info
needs-triage
next
plugin/cc-architect
plugin/os
plugin/os-adr
plugin/os-aidd-lint
plugin/os-backlog
plugin/os-context
plugin/os-doc-hygiene
plugin/os-sdlc
plugin/os-vault
project/cc-os
ready-for-agent
ready-for-human
recurring
review
rule-proposal
update
waiting
wayfinder:grilling
wayfinder:map
wayfinder:map
wayfinder:research
wayfinder:task
wayfinder:task
wontfix
worklist/deviations
worklist/lint-rule
worklist/new-implement-build
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
jared/cc-os#1664
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Problem
The second mutation pass (2026-11-09) left 322 survivors in 113 files under lib/os_sdlc/ (project/, collaborator_pass/, detector/, tracker/, boot/ outside inputs.rb, fast_gate/, dispatch/, ticket_shape/, and the top-level files). No test kills them. A survivor means a changed behavior that the suite does not see. Ruling 100 puts a unit test for
lib/os_sdlc/<path>.rbattest/os_sdlc/<path>_test.rb.Observed
The pass ran
bin/os-sdlc-mutation-pass run .on main at38b3284d0.docs/research/mutation-testing/2026-11-09-second-pass/survivors.mdlists each survivor with its original and mutated text. This ticket takes the groups thatsurvivors.mdclasses asmissing test. Each line below gives the file, its survivor count, and the mutation kinds.lib/os_sdlc/collaborator_pass/ticket_draft/approach.rb(12): condition_false 4, return_nil 4, condition_true 2, statement_removal 2lib/os_sdlc/project/codebase.rb(12): condition_true 5, statement_removal 4, return_nil 2, comparison 1lib/os_sdlc/boot/inputs/detector_argv.rb(8): condition_false 2, condition_true 2, return_nil 2, comparison 1, statement_removal 1lib/os_sdlc/project/config/document.rb(8): condition_true 4, statement_removal 2, boolean_literal 1, return_nil 1lib/os_sdlc/step_result.rb(8): return_nil 7, comparison 1lib/os_sdlc/tracker/issue_source/tracker_lookup.rb(8): condition_true 4, statement_removal 3, boolean_literal 1lib/os_sdlc/db.rb(7): statement_removal 4, condition_false 2, return_nil 1lib/os_sdlc/project/config_command.rb(7): return_nil 2, statement_removal 2, boolean_literal 1, condition_false 1, condition_true 1lib/os_sdlc/ticket_shape/fence_stack.rb(7): comparison 2, condition_true 2, condition_false 1, return_nil 1, statement_removal 1lib/os_sdlc/collaborator_pass/recipe_check/target_rules.rb(6): return_nil 3, condition_false 1, condition_true 1, statement_removal 1lib/os_sdlc/project/config.rb(6): return_nil 3, condition_false 2, statement_removal 1lib/os_sdlc/boot.rb(5): statement_removal 2, boolean_connector 1, condition_true 1, return_nil 1lib/os_sdlc/boot/inputs/crc_argv.rb(5): condition_true 2, boolean_connector 1, boolean_literal 1, statement_removal 1lib/os_sdlc/collaborator_pass/recipe_check/object_rules.rb(5): return_nil 2, condition_false 1, condition_true 1, statement_removal 1lib/os_sdlc/detector/error_lineage/definitions.rb(5): boolean_connector 2, condition_true 1, return_nil 1, statement_removal 1lib/os_sdlc/dispatch/brief/facts.rb(5): condition_false 2, boolean_literal 1, return_nil 1, statement_removal 1lib/os_sdlc/handoff.rb(5): return_nil 3, condition_true 2lib/os_sdlc/retired_test.rb(5): boolean_literal 1, condition_false 1, condition_true 1, return_nil 1, statement_removal 1lib/os_sdlc/ruby_file_check.rb(5): return_nil 2, boolean_literal 1, condition_false 1, statement_removal 1lib/os_sdlc/tracker/backlog/ticket_fetch.rb(5): statement_removal 3, condition_true 2lib/os_sdlc/violations.rb(5): return_nil 4, boolean_literal 1lib/os_sdlc/agent.rb(4): condition_false 2, statement_removal 2lib/os_sdlc/collaborator_pass/concept_brief.rb(4): comparison 1, condition_false 1, condition_true 1, return_nil 1lib/os_sdlc/collaborator_pass/recipe_check/sharpen_rules.rb(4): arithmetic 4lib/os_sdlc/collaborator_pass/shape_progress.rb(4): condition_false 2, comparison 1, statement_removal 1lib/os_sdlc/detector/holders/visitor.rb(4): condition_true 3, return_nil 1lib/os_sdlc/detector/reach_through/parent_answers.rb(4): boolean_connector 1, condition_true 1, return_nil 1, statement_removal 1lib/os_sdlc/detector/signal_section.rb(4): condition_false 2, return_nil 1, statement_removal 1lib/os_sdlc/dispatch.rb(4): return_nil 2, condition_true 1, statement_removal 1lib/os_sdlc/fast_gate/cop_check.rb(4): return_nil 2, boolean_connector 1, comparison 1lib/os_sdlc/handoff_content/mutation.rb(4): boolean_connector 1, boolean_literal 1, condition_true 1, statement_removal 1lib/os_sdlc/mutation_test/mutineer_runner/report/row.rb(4): boolean_connector 2, comparison 1, return_nil 1lib/os_sdlc/project/config_check.rb(4): statement_removal 2, condition_false 1, condition_true 1lib/os_sdlc/tracker/backlog/comments_fetch.rb(4): statement_removal 2, condition_true 1, return_nil 1lib/os_sdlc/collaborator_pass/command/delta_check.rb(3): condition_true 1, return_nil 1, statement_removal 1lib/os_sdlc/collaborator_pass/recipe_check/subject_rules.rb(3): condition_true 1, return_nil 1, statement_removal 1lib/os_sdlc/collaborator_pass/recipe_check/text_rules.rb(3): boolean_connector 1, condition_true 1, return_nil 1lib/os_sdlc/detector/error_lineage/lineage.rb(3): comparison 2, condition_true 1lib/os_sdlc/detector/holders/class_name.rb(3): boolean_connector 2, condition_true 1lib/os_sdlc/dispatch/brief/objections_digest.rb(3): condition_true 1, return_nil 1, statement_removal 1lib/os_sdlc/fast_gate/new_offense_report.rb(3): condition_false 1, condition_true 1, statement_removal 1lib/os_sdlc/handoff_content.rb(3): condition_true 1, return_nil 1, statement_removal 1lib/os_sdlc/objection.rb(3): return_nil 2, boolean_literal 1lib/os_sdlc/project/config_command/error_message.rb(3): condition_false 1, return_nil 1, statement_removal 1lib/os_sdlc/project/root.rb(3): condition_true 1, return_nil 1, statement_removal 1lib/os_sdlc/ticket_shape/required_work/check.rb(3): condition_false 1, condition_true 1, statement_removal 1lib/os_sdlc/verdict.rb(3): return_nil 3lib/os_sdlc/agent/transcript_usage.rb(2): condition_true 1, statement_removal 1lib/os_sdlc/boot/arguments.rb(2): boolean_literal 1, statement_removal 1lib/os_sdlc/collaborator_pass/command/prescribe_brief.rb(2): condition_true 1, statement_removal 1lib/os_sdlc/collaborator_pass/command/stop_check.rb(2): condition_true 1, statement_removal 1lib/os_sdlc/collaborator_pass/concept_brief/owners.rb(2): condition_false 1, statement_removal 1lib/os_sdlc/collaborator_pass/recipe.rb(2): condition_true 1, statement_removal 1lib/os_sdlc/collaborator_pass/recipe_check.rb(2): condition_true 1, statement_removal 1lib/os_sdlc/collaborator_pass/run_directory.rb(2): boolean_connector 1, boolean_literal 1lib/os_sdlc/collaborator_pass/subcommand.rb(2): condition_true 1, statement_removal 1lib/os_sdlc/db/mirror_tickle/commit_hook.rb(2): condition_false 1, statement_removal 1lib/os_sdlc/detector/error_lineage/rows.rb(2): arithmetic 1, return_nil 1lib/os_sdlc/detector/holders/site_offenses.rb(2): condition_true 2lib/os_sdlc/detector/lessons.rb(2): arithmetic 1, return_nil 1lib/os_sdlc/detector/reach_through/noise.rb(2): comparison 1, return_nil 1lib/os_sdlc/detector/reach_through/parents.rb(2): boolean_connector 1, negation_removal 1lib/os_sdlc/dispatch/brief.rb(2): boolean_literal 1, condition_false 1lib/os_sdlc/dispatch/usage.rb(2): condition_true 1, statement_removal 1lib/os_sdlc/fast_gate/rubocop.rb(2): return_nil 1, statement_removal 1lib/os_sdlc/fast_gate/suite_check.rb(2): boolean_connector 1, condition_true 1lib/os_sdlc/project/setup.rb(2): statement_removal 2lib/os_sdlc/report/ticket_growth.rb(2): boolean_literal 1, comparison 1lib/os_sdlc/suite/candidates.rb(2): condition_true 1, statement_removal 1lib/os_sdlc/suite_output/wall_time.rb(2): comparison 1, condition_true 1lib/os_sdlc/ticket_shape/section.rb(2): boolean_literal 1, return_nil 1lib/os_sdlc/tracker/backlog.rb(2): boolean_literal 1, statement_removal 1lib/os_sdlc/tracker/backlog/project_show.rb(2): condition_true 1, statement_removal 1lib/os_sdlc/boot/argv_option.rb(1): boolean_literal 1lib/os_sdlc/boot/inputs/fast_gate_argv.rb(1): boolean_connector 1lib/os_sdlc/collaborator_pass/command/record_ruling.rb(1): statement_removal 1lib/os_sdlc/collaborator_pass/command/ticket_body.rb(1): statement_removal 1lib/os_sdlc/collaborator_pass/prescription_brief.rb(1): return_nil 1lib/os_sdlc/collaborator_pass/recipe_check/delta_rules.rb(1): condition_true 1lib/os_sdlc/collaborator_pass/rulings.rb(1): boolean_literal 1lib/os_sdlc/collaborator_pass/source_snippet.rb(1): condition_true 1lib/os_sdlc/collaborator_pass/ticket_draft/owner_sketch.rb(1): return_nil 1lib/os_sdlc/collaborator_pass/ticket_draft/problem.rb(1): condition_true 1lib/os_sdlc/correction_round.rb(1): return_nil 1lib/os_sdlc/db/mirror_tickle.rb(1): return_nil 1lib/os_sdlc/db/timestamp_stamping.rb(1): return_nil 1lib/os_sdlc/detector/code_excerpt.rb(1): boolean_literal 1lib/os_sdlc/detector/error_lineage.rb(1): boolean_literal 1lib/os_sdlc/detector/error_lineage/method_names.rb(1): return_nil 1lib/os_sdlc/detector/error_lineage/scope.rb(1): condition_false 1lib/os_sdlc/detector/holders/entries.rb(1): boolean_connector 1lib/os_sdlc/detector/holders/row.rb(1): boolean_literal 1lib/os_sdlc/detector/holders/verdict.rb(1): comparison 1lib/os_sdlc/dispatch/brief_lookup.rb(1): statement_removal 1lib/os_sdlc/dispatch/subagent_start.rb(1): statement_removal 1lib/os_sdlc/fast_gate/changed_files.rb(1): boolean_connector 1lib/os_sdlc/fast_gate/failure_entry.rb(1): return_nil 1lib/os_sdlc/fast_gate/new_offense_check.rb(1): condition_false 1lib/os_sdlc/fast_gate/new_offense_report/options.rb(1): boolean_connector 1lib/os_sdlc/handoff_content/malformed_error.rb(1): return_nil 1lib/os_sdlc/lesson.rb(1): return_nil 1lib/os_sdlc/lesson/catalog/cop_key.rb(1): boolean_connector 1lib/os_sdlc/lesson/relay.rb(1): condition_false 1lib/os_sdlc/mutation_test/ledger.rb(1): boolean_literal 1lib/os_sdlc/mutation_test/scope.rb(1): condition_true 1lib/os_sdlc/process_io/outcome.rb(1): condition_false 1lib/os_sdlc/project/changes.rb(1): boolean_literal 1lib/os_sdlc/project/snapshot.rb(1): condition_false 1lib/os_sdlc/project/target.rb(1): condition_false 1lib/os_sdlc/project/unconfigured.rb(1): return_nil 1lib/os_sdlc/report/run.rb(1): return_nil 1lib/os_sdlc/ticket_shape.rb(1): condition_true 1lib/os_sdlc/tracker/issue_source/forgejo.rb(1): return_nil 1Reproduce
n/a: the survivors come from a whole pass. Verify with a targeted run:
bin/os-sdlc-mutation-pass run <files> --no-matrix.Approach
For each file listed, write the missing paired test at
test/os_sdlc/<lib path>_test.rb(ruling 100). The test must kill each survivor of that file. When a survivor shows dead code (a branch no caller reaches), delete the code if no caller needs it, and write no test for it. When a survivor is equivalent (the mutant has the same behavior), rule it equivalent in a comment on this ticket with the reason. Then verify with a targeted--no-matrixrun over the files of this ticket. Do not run a whole pass.Required work: none beyond the acceptance criteria.
Acceptance criteria
--no-matrixMutineer run on the files listed in this ticket, when the run ends, then no survivor remains except ones that this ticket rules equivalent with a reason.Origin
docs/research/mutation-testing/2026-11-09-second-pass/)VERDICT: CREATE (ticket-skeptic, 2026-11-09): no open ticket covers these survivors.
Add from the pass 2 harness fix (
e2098232): after the Boot::Commands::TABLE fix, boot/inputs.rb keeps 10 real survivors with missing tests: brief:24 x2, place_design:33 x2, subagent_start:41, subagent_stop:50 x2, ticket_growth:96, system_model_shapes:132 x2. Also lesson.rb: Lesson#after:35 return_nil survives and Lesson.from:8 times out. Confirm the 127 harness kills in boot/inputs.rb at the next whole pass.Resolution
Done: The 106 live files (322 survivors, 16 groups) went through the survivor loop. New paired tests kill the real survivors. Ruling 107 deleted code that did no work in 9 lib files. 20 survivors are ruled equivalent in .sdlc/mutation-rulings.tsv.
Evidence: main
b6c214a7d(tests, deletions, rulings) and7cd98c79e(History row). Verify packet over all 16 groups with every killing test from pass.json: 46 survivors of 1773 before the last round; after it the 25 real survivors are killed (packet 0 of 177) and 21 harness-unreachable mutants remain. ruby test/all.rb: 4780 runs, 0 failures, 0 errors.Follow-ups: #1691 owns the 20 dataset_module mutants and the Db.bind! freeze mutant 4ff3bd77b909 (comments posted 2026-11-11). #1683 owns the uncovered mutants. #1679 covers the brief test command that runs only the first file. No other follow-ups.