Write the missing tests for 127 os-sdlc survivors in implementation #1662

New issue

Closed

opened 2026-11-09 22:13:18 +00:00 by jared · 1 comment

jared commented

2026-11-09 22:13:18 +00:00

Owner

Problem

The second mutation pass (2026-11-09) left 127 survivors in 33 files under lib/os_sdlc/implementation/ and implementation.rb. No test kills them. A survivor means a changed behavior that the suite does not see. Ruling 100 puts a unit test for lib/os_sdlc/<path>.rb at test/os_sdlc/<path>_test.rb.

Observed

The pass ran bin/os-sdlc-mutation-pass run . on main at 38b3284d0. docs/research/mutation-testing/2026-11-09-second-pass/survivors.md lists each survivor with its original and mutated text. This ticket takes the groups that survivors.md classes as missing test. Each line below gives the file, its survivor count, and the mutation kinds.

lib/os_sdlc/implementation/mutation_check.rb (17): condition_true 5, return_nil 5, statement_removal 3, boolean_connector 2, condition_false 2
lib/os_sdlc/implementation/reroute.rb (9): return_nil 5, boolean_literal 2, comparison 2
lib/os_sdlc/implementation/completion_intake.rb (8): boolean_literal 3, return_nil 3, condition_false 1, statement_removal 1
lib/os_sdlc/implementation/commit/message.rb (7): condition_false 2, condition_true 2, boolean_literal 1, return_nil 1, statement_removal 1
lib/os_sdlc/implementation/completion_intake/lookup.rb (7): condition_true 3, return_nil 2, condition_false 1, statement_removal 1
lib/os_sdlc/implementation.rb (6): return_nil 5, boolean_literal 1
lib/os_sdlc/implementation/completion_intake/transcript_stamp.rb (6): condition_true 3, statement_removal 3
lib/os_sdlc/implementation/commit/item.rb (5): boolean_literal 2, condition_false 1, condition_true 1, statement_removal 1
lib/os_sdlc/implementation/dispatch_entries.rb (5): arithmetic 1, boolean_connector 1, boolean_literal 1, condition_false 1, statement_removal 1
lib/os_sdlc/implementation/objection_intake.rb (5): return_nil 3, statement_removal 2
lib/os_sdlc/implementation/completion_intake/role_check.rb (4): condition_true 2, return_nil 1, statement_removal 1
lib/os_sdlc/implementation/duration.rb (4): condition_false 1, condition_true 1, return_nil 1, statement_removal 1
lib/os_sdlc/implementation/raised_objection.rb (4): boolean_connector 2, condition_true 1, statement_removal 1
lib/os_sdlc/implementation/reroute/check.rb (4): return_nil 2, condition_false 1, statement_removal 1
lib/os_sdlc/implementation/reroute/draft.rb (4): statement_removal 2, condition_false 1, condition_true 1
lib/os_sdlc/implementation/targeting.rb (4): boolean_connector 1, condition_false 1, condition_true 1, statement_removal 1
lib/os_sdlc/implementation/open.rb (3): condition_true 2, statement_removal 1
lib/os_sdlc/implementation/reroute_intake.rb (3): boolean_literal 1, condition_false 1, statement_removal 1
lib/os_sdlc/implementation/transition.rb (3): return_nil 2, boolean_literal 1
lib/os_sdlc/implementation/goalpost_check.rb (2): boolean_connector 1, return_nil 1
lib/os_sdlc/implementation/loop_ledger.rb (2): condition_false 1, statement_removal 1
lib/os_sdlc/implementation/next_step.rb (2): condition_true 1, statement_removal 1
lib/os_sdlc/implementation/report.rb (2): boolean_literal 2
lib/os_sdlc/implementation/stall_watch.rb (2): comparison 1, return_nil 1
lib/os_sdlc/implementation/commit.rb (1): boolean_literal 1
lib/os_sdlc/implementation/completion_intake/blank_handoff_recording.rb (1): boolean_literal 1
lib/os_sdlc/implementation/completion_intake/role_mismatch_error.rb (1): statement_removal 1
lib/os_sdlc/implementation/completion_payload.rb (1): statement_removal 1
lib/os_sdlc/implementation/edge_selection.rb (1): boolean_literal 1
lib/os_sdlc/implementation/edge_spend.rb (1): return_nil 1
lib/os_sdlc/implementation/escalation_payload.rb (1): return_nil 1
lib/os_sdlc/implementation/landing.rb (1): return_nil 1
lib/os_sdlc/implementation/open_payload.rb (1): boolean_literal 1

Reproduce

n/a: the survivors come from a whole pass. Verify with a targeted run: bin/os-sdlc-mutation-pass run <files> --no-matrix.

Approach

For each file listed, write the missing paired test at test/os_sdlc/<lib path>_test.rb (ruling 100). The test must kill each survivor of that file. When a survivor shows dead code (a branch no caller reaches), delete the code if no caller needs it, and write no test for it. When a survivor is equivalent (the mutant has the same behavior), rule it equivalent in a comment on this ticket with the reason. Then verify with a targeted --no-matrix run over the files of this ticket. Do not run a whole pass.

Required work: none beyond the acceptance criteria.

Acceptance criteria

Given a targeted --no-matrix Mutineer run on the files listed in this ticket, when the run ends, then no survivor remains except ones that this ticket rules equivalent with a reason.
Given a file that has a deleted dead-code candidate, when the suite runs, then it is green and no caller of the deleted code remains.

Origin

Trigger: second whole-codebase mutation pass, 2026-11-09 (docs/research/mutation-testing/2026-11-09-second-pass/)
Improvised this session: none
Chain: survivors ← no paired unit test for the file ← tests were written at the pipeline level, and the unit test per file (ruling 100) was never added ← DESIGN (ruling 100)
Root candidate: none found; searched survivor, mutation, mutant, missing test, implementation
Where: lib/os_sdlc/implementation/ and implementation.rb
Session: bc5ad309-36b7-4fe5-a67f-1d90187242eb
Transcript: /home/jared/.claude/projects/-home-jared-dev-cc-os-plugins-os-sdlc/bc5ad309-36b7-4fe5-a67f-1d90187242eb.jsonl

VERDICT: CREATE (ticket-skeptic, 2026-11-09): no open ticket covers these survivors.

## Problem The second mutation pass (2026-11-09) left 127 survivors in 33 files under lib/os_sdlc/implementation/ and implementation.rb. No test kills them. A survivor means a changed behavior that the suite does not see. Ruling 100 puts a unit test for `lib/os_sdlc/<path>.rb` at `test/os_sdlc/<path>_test.rb`. ## Observed The pass ran `bin/os-sdlc-mutation-pass run .` on main at 38b3284d0. `docs/research/mutation-testing/2026-11-09-second-pass/survivors.md` lists each survivor with its original and mutated text. This ticket takes the groups that `survivors.md` classes as `missing test`. Each line below gives the file, its survivor count, and the mutation kinds. - `lib/os_sdlc/implementation/mutation_check.rb` (17): condition_true 5, return_nil 5, statement_removal 3, boolean_connector 2, condition_false 2 - `lib/os_sdlc/implementation/reroute.rb` (9): return_nil 5, boolean_literal 2, comparison 2 - `lib/os_sdlc/implementation/completion_intake.rb` (8): boolean_literal 3, return_nil 3, condition_false 1, statement_removal 1 - `lib/os_sdlc/implementation/commit/message.rb` (7): condition_false 2, condition_true 2, boolean_literal 1, return_nil 1, statement_removal 1 - `lib/os_sdlc/implementation/completion_intake/lookup.rb` (7): condition_true 3, return_nil 2, condition_false 1, statement_removal 1 - `lib/os_sdlc/implementation.rb` (6): return_nil 5, boolean_literal 1 - `lib/os_sdlc/implementation/completion_intake/transcript_stamp.rb` (6): condition_true 3, statement_removal 3 - `lib/os_sdlc/implementation/commit/item.rb` (5): boolean_literal 2, condition_false 1, condition_true 1, statement_removal 1 - `lib/os_sdlc/implementation/dispatch_entries.rb` (5): arithmetic 1, boolean_connector 1, boolean_literal 1, condition_false 1, statement_removal 1 - `lib/os_sdlc/implementation/objection_intake.rb` (5): return_nil 3, statement_removal 2 - `lib/os_sdlc/implementation/completion_intake/role_check.rb` (4): condition_true 2, return_nil 1, statement_removal 1 - `lib/os_sdlc/implementation/duration.rb` (4): condition_false 1, condition_true 1, return_nil 1, statement_removal 1 - `lib/os_sdlc/implementation/raised_objection.rb` (4): boolean_connector 2, condition_true 1, statement_removal 1 - `lib/os_sdlc/implementation/reroute/check.rb` (4): return_nil 2, condition_false 1, statement_removal 1 - `lib/os_sdlc/implementation/reroute/draft.rb` (4): statement_removal 2, condition_false 1, condition_true 1 - `lib/os_sdlc/implementation/targeting.rb` (4): boolean_connector 1, condition_false 1, condition_true 1, statement_removal 1 - `lib/os_sdlc/implementation/open.rb` (3): condition_true 2, statement_removal 1 - `lib/os_sdlc/implementation/reroute_intake.rb` (3): boolean_literal 1, condition_false 1, statement_removal 1 - `lib/os_sdlc/implementation/transition.rb` (3): return_nil 2, boolean_literal 1 - `lib/os_sdlc/implementation/goalpost_check.rb` (2): boolean_connector 1, return_nil 1 - `lib/os_sdlc/implementation/loop_ledger.rb` (2): condition_false 1, statement_removal 1 - `lib/os_sdlc/implementation/next_step.rb` (2): condition_true 1, statement_removal 1 - `lib/os_sdlc/implementation/report.rb` (2): boolean_literal 2 - `lib/os_sdlc/implementation/stall_watch.rb` (2): comparison 1, return_nil 1 - `lib/os_sdlc/implementation/commit.rb` (1): boolean_literal 1 - `lib/os_sdlc/implementation/completion_intake/blank_handoff_recording.rb` (1): boolean_literal 1 - `lib/os_sdlc/implementation/completion_intake/role_mismatch_error.rb` (1): statement_removal 1 - `lib/os_sdlc/implementation/completion_payload.rb` (1): statement_removal 1 - `lib/os_sdlc/implementation/edge_selection.rb` (1): boolean_literal 1 - `lib/os_sdlc/implementation/edge_spend.rb` (1): return_nil 1 - `lib/os_sdlc/implementation/escalation_payload.rb` (1): return_nil 1 - `lib/os_sdlc/implementation/landing.rb` (1): return_nil 1 - `lib/os_sdlc/implementation/open_payload.rb` (1): boolean_literal 1 ## Reproduce n/a: the survivors come from a whole pass. Verify with a targeted run: `bin/os-sdlc-mutation-pass run <files> --no-matrix`. ## Approach For each file listed, write the missing paired test at `test/os_sdlc/<lib path>_test.rb` (ruling 100). The test must kill each survivor of that file. When a survivor shows dead code (a branch no caller reaches), delete the code if no caller needs it, and write no test for it. When a survivor is equivalent (the mutant has the same behavior), rule it equivalent in a comment on this ticket with the reason. Then verify with a targeted `--no-matrix` run over the files of this ticket. Do not run a whole pass. Required work: none beyond the acceptance criteria. ## Acceptance criteria 1. Given a targeted `--no-matrix` Mutineer run on the files listed in this ticket, when the run ends, then no survivor remains except ones that this ticket rules equivalent with a reason. 2. Given a file that has a deleted dead-code candidate, when the suite runs, then it is green and no caller of the deleted code remains. ## Origin - Trigger: second whole-codebase mutation pass, 2026-11-09 (`docs/research/mutation-testing/2026-11-09-second-pass/`) - Improvised this session: none - Chain: survivors ← no paired unit test for the file ← tests were written at the pipeline level, and the unit test per file (ruling 100) was never added ← DESIGN (ruling 100) - Root candidate: none found; searched survivor, mutation, mutant, missing test, implementation - Where: lib/os_sdlc/implementation/ and implementation.rb - Session: bc5ad309-36b7-4fe5-a67f-1d90187242eb - Transcript: /home/jared/.claude/projects/-home-jared-dev-cc-os-plugins-os-sdlc/bc5ad309-36b7-4fe5-a67f-1d90187242eb.jsonl VERDICT: CREATE (ticket-skeptic, 2026-11-09): no open ticket covers these survivors.

jared added the

plugin/os-sdlc

filed-by/user

category/code-change

labels

2026-11-09 22:13:18 +00:00

jared referenced this issue

2026-11-11 07:13:51 +00:00

Mutineer cannot mutate Sequel dataset_module methods; their mutants show as false survivors #1691

jared commented

2026-11-11 07:18:34 +00:00

Author

Owner

Resolution

Done: Implementation survivors through the survivor loop: paired tests for 33 files; repeats of older tests deleted after review; 11 survivors ruled equivalent.

Evidence: Commit 8c9cf7e9b on branch ticket-1662. Verify over all 8 groups: 30 survivors of 619, of which 14 in completion_intake.rb and open.rb are killed by older tests (separate packet with test/implementation/*: 0 survivors of 99), and 16 are dataset_module mutants. Suite: 4597 runs, 0 failures.

Follow-ups: #1691 owns the 16 dataset_module mutants that mutineer cannot apply (implementation.rb 6, reroute.rb 9, edge_spend.rb 1). #1683 covers the 19 uncovered mutants.

## Resolution **Done:** Implementation survivors through the survivor loop: paired tests for 33 files; repeats of older tests deleted after review; 11 survivors ruled equivalent. **Evidence:** Commit 8c9cf7e9b on branch ticket-1662. Verify over all 8 groups: 30 survivors of 619, of which 14 in completion_intake.rb and open.rb are killed by older tests (separate packet with test/implementation/*: 0 survivors of 99), and 16 are dataset_module mutants. Suite: 4597 runs, 0 failures. **Follow-ups:** #1691 owns the 16 dataset_module mutants that mutineer cannot apply (implementation.rb 6, reroute.rb 9, edge_spend.rb 1). #1683 covers the 19 uncovered mutants.

jared closed this issue

2026-11-11 07:18:34 +00:00

jared referenced this issue

2026-11-11 13:56:13 +00:00

Mutineer cannot mutate Sequel dataset_module methods; their mutants show as false survivors #1691

jared referenced this issue from a commit

2026-11-11 14:07:49 +00:00

test(os-sdlc): paired unit tests for the implementation survivors, first round (#1662)

jared referenced this issue from a commit

2026-11-11 14:07:49 +00:00

test(os-sdlc): paired unit tests kill the implementation survivors; repeats of older tests deleted; eleven survivors ruled equivalent; sixteen dataset_module mutants left to #1691 (#1662)

jared referenced this issue from a commit