Write the missing tests for 53 os-sdlc survivors in gate #1659

New issue

Closed

opened 2026-11-09 22:13:12 +00:00 by jared · 1 comment

jared commented

2026-11-09 22:13:12 +00:00

Owner

Problem

The second mutation pass (2026-11-09) left 53 survivors in 10 files under lib/os_sdlc/gate/ and gate.rb. No test kills them. A survivor means a changed behavior that the suite does not see. Ruling 100 puts a unit test for lib/os_sdlc/<path>.rb at test/os_sdlc/<path>_test.rb.

Observed

The pass ran bin/os-sdlc-mutation-pass run . on main at 38b3284d0. docs/research/mutation-testing/2026-11-09-second-pass/survivors.md lists each survivor with its original and mutated text. This ticket takes the groups that survivors.md classes as missing test. Each line below gives the file, its survivor count, and the mutation kinds.

gate/commands.rb has 28 survivors. Its respond_to? guards are dead-code candidates: delete a guard when no caller needs it, and write no test for it.

lib/os_sdlc/gate/commands.rb (28): boolean_literal 8, condition_false 7, return_nil 6, condition_true 4, statement_removal 3
lib/os_sdlc/gate/reply.rb (10): condition_false 5, statement_removal 3, condition_true 1, return_nil 1
lib/os_sdlc/gate.rb (3): arithmetic 2, condition_true 1
lib/os_sdlc/gate/source_snippet.rb (3): boolean_literal 1, condition_false 1, statement_removal 1
lib/os_sdlc/gate/violation_record.rb (3): condition_false 1, condition_true 1, statement_removal 1
lib/os_sdlc/gate/run.rb (2): condition_true 1, statement_removal 1
lib/os_sdlc/gate/slow_step.rb (1): comparison 1
lib/os_sdlc/gate/unchanged_check/base_checkout.rb (1): statement_removal 1
lib/os_sdlc/gate/unchanged_check/comparison.rb (1): boolean_connector 1
lib/os_sdlc/gate/unchanged_check/measurement.rb (1): arithmetic 1

Reproduce

n/a: the survivors come from a whole pass. Verify with a targeted run: bin/os-sdlc-mutation-pass run <files> --no-matrix.

Approach

For each file listed, write the missing paired test at test/os_sdlc/<lib path>_test.rb (ruling 100). The test must kill each survivor of that file. When a survivor shows dead code (a branch no caller reaches), delete the code if no caller needs it, and write no test for it. When a survivor is equivalent (the mutant has the same behavior), rule it equivalent in a comment on this ticket with the reason. Then verify with a targeted --no-matrix run over the files of this ticket. Do not run a whole pass.

Required work: none beyond the acceptance criteria.

Acceptance criteria

Given a targeted --no-matrix Mutineer run on the files listed in this ticket, when the run ends, then no survivor remains except ones that this ticket rules equivalent with a reason.
Given a file that has a deleted dead-code candidate, when the suite runs, then it is green and no caller of the deleted code remains.

Origin

Trigger: second whole-codebase mutation pass, 2026-11-09 (docs/research/mutation-testing/2026-11-09-second-pass/)
Improvised this session: none
Chain: survivors ← no paired unit test for the file ← tests were written at the pipeline level, and the unit test per file (ruling 100) was never added ← DESIGN (ruling 100)
Root candidate: none found; searched survivor, mutation, mutineer, gate, missing tests
Where: lib/os_sdlc/gate/ and gate.rb
Session: bc5ad309-36b7-4fe5-a67f-1d90187242eb
Transcript: /home/jared/.claude/projects/-home-jared-dev-cc-os-plugins-os-sdlc/bc5ad309-36b7-4fe5-a67f-1d90187242eb.jsonl

VERDICT: CREATE (ticket-skeptic, 2026-11-09): no open ticket covers these survivors.

## Problem The second mutation pass (2026-11-09) left 53 survivors in 10 files under lib/os_sdlc/gate/ and gate.rb. No test kills them. A survivor means a changed behavior that the suite does not see. Ruling 100 puts a unit test for `lib/os_sdlc/<path>.rb` at `test/os_sdlc/<path>_test.rb`. ## Observed The pass ran `bin/os-sdlc-mutation-pass run .` on main at 38b3284d0. `docs/research/mutation-testing/2026-11-09-second-pass/survivors.md` lists each survivor with its original and mutated text. This ticket takes the groups that `survivors.md` classes as `missing test`. Each line below gives the file, its survivor count, and the mutation kinds. `gate/commands.rb` has 28 survivors. Its `respond_to?` guards are dead-code candidates: delete a guard when no caller needs it, and write no test for it. - `lib/os_sdlc/gate/commands.rb` (28): boolean_literal 8, condition_false 7, return_nil 6, condition_true 4, statement_removal 3 - `lib/os_sdlc/gate/reply.rb` (10): condition_false 5, statement_removal 3, condition_true 1, return_nil 1 - `lib/os_sdlc/gate.rb` (3): arithmetic 2, condition_true 1 - `lib/os_sdlc/gate/source_snippet.rb` (3): boolean_literal 1, condition_false 1, statement_removal 1 - `lib/os_sdlc/gate/violation_record.rb` (3): condition_false 1, condition_true 1, statement_removal 1 - `lib/os_sdlc/gate/run.rb` (2): condition_true 1, statement_removal 1 - `lib/os_sdlc/gate/slow_step.rb` (1): comparison 1 - `lib/os_sdlc/gate/unchanged_check/base_checkout.rb` (1): statement_removal 1 - `lib/os_sdlc/gate/unchanged_check/comparison.rb` (1): boolean_connector 1 - `lib/os_sdlc/gate/unchanged_check/measurement.rb` (1): arithmetic 1 ## Reproduce n/a: the survivors come from a whole pass. Verify with a targeted run: `bin/os-sdlc-mutation-pass run <files> --no-matrix`. ## Approach For each file listed, write the missing paired test at `test/os_sdlc/<lib path>_test.rb` (ruling 100). The test must kill each survivor of that file. When a survivor shows dead code (a branch no caller reaches), delete the code if no caller needs it, and write no test for it. When a survivor is equivalent (the mutant has the same behavior), rule it equivalent in a comment on this ticket with the reason. Then verify with a targeted `--no-matrix` run over the files of this ticket. Do not run a whole pass. Required work: none beyond the acceptance criteria. ## Acceptance criteria 1. Given a targeted `--no-matrix` Mutineer run on the files listed in this ticket, when the run ends, then no survivor remains except ones that this ticket rules equivalent with a reason. 2. Given a file that has a deleted dead-code candidate, when the suite runs, then it is green and no caller of the deleted code remains. ## Origin - Trigger: second whole-codebase mutation pass, 2026-11-09 (`docs/research/mutation-testing/2026-11-09-second-pass/`) - Improvised this session: none - Chain: survivors ← no paired unit test for the file ← tests were written at the pipeline level, and the unit test per file (ruling 100) was never added ← DESIGN (ruling 100) - Root candidate: none found; searched survivor, mutation, mutineer, gate, missing tests - Where: lib/os_sdlc/gate/ and gate.rb - Session: bc5ad309-36b7-4fe5-a67f-1d90187242eb - Transcript: /home/jared/.claude/projects/-home-jared-dev-cc-os-plugins-os-sdlc/bc5ad309-36b7-4fe5-a67f-1d90187242eb.jsonl VERDICT: CREATE (ticket-skeptic, 2026-11-09): no open ticket covers these survivors.

jared added the

plugin/os-sdlc

filed-by/user

category/code-change

labels

2026-11-09 22:13:12 +00:00

jared commented

2026-11-10 22:40:34 +00:00

Author

Owner

Resolution

Done: Gate survivors through the survivor loop: 8 paired test files; the respond_to? guards and three other no-op lines deleted (ruling 107); Gate::Commands now requires its implementation.

Evidence: Commit 620eea361 on branch ticket-1659. Targeted packet: 0 survivors of 185, score 100.0. Suite: 4268 runs, 0 failures. Sonnet review: no breaches.

Follow-ups: #1683 covers the 3 uncovered gate mutants (commands.rb 2, reply.rb 1).

## Resolution **Done:** Gate survivors through the survivor loop: 8 paired test files; the respond_to? guards and three other no-op lines deleted (ruling 107); Gate::Commands now requires its implementation. **Evidence:** Commit 620eea361 on branch ticket-1659. Targeted packet: 0 survivors of 185, score 100.0. Suite: 4268 runs, 0 failures. Sonnet review: no breaches. **Follow-ups:** #1683 covers the 3 uncovered gate mutants (commands.rb 2, reply.rb 1).

jared closed this issue

2026-11-10 22:40:34 +00:00

jared referenced this issue from a commit

2026-11-11 00:18:29 +00:00

test(os-sdlc): paired unit tests kill the gate survivors; eight no-op guards deleted and Gate::Commands requires its implementation (ruling 107) (#1659)

jared referenced this issue from a commit

2026-11-11 00:18:29 +00:00

docs(status): os-sdlc history row for #1659