Write the missing tests for 65 os-sdlc survivors in daemon #1658

New issue

Closed

opened 2026-11-09 22:13:11 +00:00 by jared · 2 comments

jared commented

2026-11-09 22:13:11 +00:00

Owner

Problem

The second mutation pass (2026-11-09) left 65 survivors in 15 files under lib/os_sdlc/daemon/ and daemon.rb. No test kills them. A survivor means a changed behavior that the suite does not see. Ruling 100 puts a unit test for lib/os_sdlc/<path>.rb at test/os_sdlc/<path>_test.rb.

Observed

The pass ran bin/os-sdlc-mutation-pass run . on main at 38b3284d0. docs/research/mutation-testing/2026-11-09-second-pass/survivors.md lists each survivor with its original and mutated text. This ticket takes the groups that survivors.md classes as missing test. Each line below gives the file, its survivor count, and the mutation kinds.

lib/os_sdlc/daemon/lsp_session/readiness.rb (17): return_nil 5, condition_true 3, boolean_literal 2, condition_false 2, statement_removal 2, arithmetic 1, boolean_connector 1, comparison 1
lib/os_sdlc/daemon/termination.rb (11): statement_removal 4, return_nil 2, arithmetic 1, boolean_connector 1, boolean_literal 1, comparison 1, condition_false 1
lib/os_sdlc/daemon/navigation.rb (7): return_nil 4, condition_false 1, condition_true 1, statement_removal 1
lib/os_sdlc/daemon/client.rb (6): statement_removal 2, arithmetic 1, comparison 1, condition_true 1, return_nil 1
lib/os_sdlc/daemon/lsp_session/opened_documents.rb (5): condition_false 2, condition_true 1, return_nil 1, statement_removal 1
lib/os_sdlc/daemon/lsp_session.rb (4): return_nil 2, statement_removal 2
lib/os_sdlc/daemon/lsp_session/location_request.rb (3): statement_removal 2, return_nil 1
lib/os_sdlc/daemon/lsp_session/poll.rb (3): arithmetic 1, comparison 1, statement_removal 1
lib/os_sdlc/daemon/lsp_session/symbols_request/ast_definition.rb (3): arithmetic 2, boolean_connector 1
lib/os_sdlc/daemon.rb (1): return_nil 1
lib/os_sdlc/daemon/lsp_session/document_notification.rb (1): return_nil 1
lib/os_sdlc/daemon/lsp_session/handshake.rb (1): return_nil 1
lib/os_sdlc/daemon/lsp_session/references_request.rb (1): boolean_literal 1
lib/os_sdlc/daemon/symbol_kind.rb (1): return_nil 1
lib/os_sdlc/daemon/uri.rb (1): return_nil 1

Reproduce

n/a: the survivors come from a whole pass. Verify with a targeted run: bin/os-sdlc-mutation-pass run <files> --no-matrix.

Approach

For each file listed, write the missing paired test at test/os_sdlc/<lib path>_test.rb (ruling 100). The test must kill each survivor of that file. When a survivor shows dead code (a branch no caller reaches), delete the code if no caller needs it, and write no test for it. When a survivor is equivalent (the mutant has the same behavior), rule it equivalent in a comment on this ticket with the reason. Then verify with a targeted --no-matrix run over the files of this ticket. Do not run a whole pass.

Required work: none beyond the acceptance criteria.

Acceptance criteria

Given a targeted --no-matrix Mutineer run on the files listed in this ticket, when the run ends, then no survivor remains except ones that this ticket rules equivalent with a reason.
Given a file that has a deleted dead-code candidate, when the suite runs, then it is green and no caller of the deleted code remains.

Origin

Trigger: second whole-codebase mutation pass, 2026-11-09 (docs/research/mutation-testing/2026-11-09-second-pass/)
Improvised this session: none
Chain: survivors ← no paired unit test for the file ← tests were written at the pipeline level, and the unit test per file (ruling 100) was never added ← DESIGN (ruling 100)
Root candidate: none found; searched survivor, mutation, mutineer, daemon, missing tests
Where: lib/os_sdlc/daemon/ and daemon.rb
Session: bc5ad309-36b7-4fe5-a67f-1d90187242eb
Transcript: /home/jared/.claude/projects/-home-jared-dev-cc-os-plugins-os-sdlc/bc5ad309-36b7-4fe5-a67f-1d90187242eb.jsonl

VERDICT: CREATE (ticket-skeptic, 2026-11-09): no open ticket covers these survivors.

## Problem The second mutation pass (2026-11-09) left 65 survivors in 15 files under lib/os_sdlc/daemon/ and daemon.rb. No test kills them. A survivor means a changed behavior that the suite does not see. Ruling 100 puts a unit test for `lib/os_sdlc/<path>.rb` at `test/os_sdlc/<path>_test.rb`. ## Observed The pass ran `bin/os-sdlc-mutation-pass run .` on main at 38b3284d0. `docs/research/mutation-testing/2026-11-09-second-pass/survivors.md` lists each survivor with its original and mutated text. This ticket takes the groups that `survivors.md` classes as `missing test`. Each line below gives the file, its survivor count, and the mutation kinds. - `lib/os_sdlc/daemon/lsp_session/readiness.rb` (17): return_nil 5, condition_true 3, boolean_literal 2, condition_false 2, statement_removal 2, arithmetic 1, boolean_connector 1, comparison 1 - `lib/os_sdlc/daemon/termination.rb` (11): statement_removal 4, return_nil 2, arithmetic 1, boolean_connector 1, boolean_literal 1, comparison 1, condition_false 1 - `lib/os_sdlc/daemon/navigation.rb` (7): return_nil 4, condition_false 1, condition_true 1, statement_removal 1 - `lib/os_sdlc/daemon/client.rb` (6): statement_removal 2, arithmetic 1, comparison 1, condition_true 1, return_nil 1 - `lib/os_sdlc/daemon/lsp_session/opened_documents.rb` (5): condition_false 2, condition_true 1, return_nil 1, statement_removal 1 - `lib/os_sdlc/daemon/lsp_session.rb` (4): return_nil 2, statement_removal 2 - `lib/os_sdlc/daemon/lsp_session/location_request.rb` (3): statement_removal 2, return_nil 1 - `lib/os_sdlc/daemon/lsp_session/poll.rb` (3): arithmetic 1, comparison 1, statement_removal 1 - `lib/os_sdlc/daemon/lsp_session/symbols_request/ast_definition.rb` (3): arithmetic 2, boolean_connector 1 - `lib/os_sdlc/daemon.rb` (1): return_nil 1 - `lib/os_sdlc/daemon/lsp_session/document_notification.rb` (1): return_nil 1 - `lib/os_sdlc/daemon/lsp_session/handshake.rb` (1): return_nil 1 - `lib/os_sdlc/daemon/lsp_session/references_request.rb` (1): boolean_literal 1 - `lib/os_sdlc/daemon/symbol_kind.rb` (1): return_nil 1 - `lib/os_sdlc/daemon/uri.rb` (1): return_nil 1 ## Reproduce n/a: the survivors come from a whole pass. Verify with a targeted run: `bin/os-sdlc-mutation-pass run <files> --no-matrix`. ## Approach For each file listed, write the missing paired test at `test/os_sdlc/<lib path>_test.rb` (ruling 100). The test must kill each survivor of that file. When a survivor shows dead code (a branch no caller reaches), delete the code if no caller needs it, and write no test for it. When a survivor is equivalent (the mutant has the same behavior), rule it equivalent in a comment on this ticket with the reason. Then verify with a targeted `--no-matrix` run over the files of this ticket. Do not run a whole pass. Required work: none beyond the acceptance criteria. ## Acceptance criteria 1. Given a targeted `--no-matrix` Mutineer run on the files listed in this ticket, when the run ends, then no survivor remains except ones that this ticket rules equivalent with a reason. 2. Given a file that has a deleted dead-code candidate, when the suite runs, then it is green and no caller of the deleted code remains. ## Origin - Trigger: second whole-codebase mutation pass, 2026-11-09 (`docs/research/mutation-testing/2026-11-09-second-pass/`) - Improvised this session: none - Chain: survivors ← no paired unit test for the file ← tests were written at the pipeline level, and the unit test per file (ruling 100) was never added ← DESIGN (ruling 100) - Root candidate: none found; searched survivor, mutation, mutineer, daemon, missing tests - Where: lib/os_sdlc/daemon/ and daemon.rb - Session: bc5ad309-36b7-4fe5-a67f-1d90187242eb - Transcript: /home/jared/.claude/projects/-home-jared-dev-cc-os-plugins-os-sdlc/bc5ad309-36b7-4fe5-a67f-1d90187242eb.jsonl VERDICT: CREATE (ticket-skeptic, 2026-11-09): no open ticket covers these survivors.

jared added the

plugin/os-sdlc

filed-by/user

category/code-change

labels

2026-11-09 22:13:11 +00:00

jared referenced this issue

2026-11-10 21:58:49 +00:00

Cover the 388 mutants that no test runs #1683

jared commented

2026-11-10 21:58:52 +00:00

Author

Owner

Resolution

Done: Paired unit tests kill every daemon survivor, with doubles and shared stub helpers; no test starts a process or waits on a clock. Ruled equivalent with reasons: Readiness#settle and Client#retryable? return false to callers that test only truthiness (ruling 107 keeps predicates)

Evidence: One packet run over all daemon sources: 168 mutants, 0 unruled survivors, score 98.8 (6 hang-only no-verdict mutants, 45 uncovered mutants, both outside this ticket's survivors); suite 4144 runs, 0 failures; sonnet review fixes applied; commit 06f0e0994 on ticket-1658

Follow-ups: #1681 (cover the 388 uncovered mutants, 45 of them in daemon), filed with a ticket-skeptic CREATE verdict

## Resolution **Done:** Paired unit tests kill every daemon survivor, with doubles and shared stub helpers; no test starts a process or waits on a clock. Ruled equivalent with reasons: Readiness#settle and Client#retryable? return false to callers that test only truthiness (ruling 107 keeps predicates) **Evidence:** One packet run over all daemon sources: 168 mutants, 0 unruled survivors, score 98.8 (6 hang-only no-verdict mutants, 45 uncovered mutants, both outside this ticket's survivors); suite 4144 runs, 0 failures; sonnet review fixes applied; commit 06f0e0994 on ticket-1658 **Follow-ups:** #1681 (cover the 388 uncovered mutants, 45 of them in daemon), filed with a ticket-skeptic CREATE verdict

jared closed this issue

2026-11-10 21:58:52 +00:00

jared commented

2026-11-10 21:58:56 +00:00

Author

Owner

Correction to the follow-ups line above: the uncovered-mutants ticket is #1683, not #1681.

jared referenced this issue from a commit

2026-11-11 00:18:29 +00:00

test(os-sdlc): paired unit tests kill the daemon survivors with doubles and no real process; two predicates ruled equivalent (#1658)

jared referenced this issue from a commit

2026-11-11 00:18:29 +00:00