os_git ships a repository fake for consumer tests; os-sdlc moves its FakeGit into it #1652

New issue

Open

opened 2026-11-09 20:46:49 +00:00 by jared · 0 comments

jared commented

2026-11-09 20:46:49 +00:00

Owner

Problem

Consumers of the os_git gem must test without starting git (ruling 88, .claude/rules/ruby-external-calls.md).
OsGit::Testing::ScratchRepo starts real git.
OsGit Backend::Fake answers by message name only, so it cannot model a history.
#1645 (merged 38b3284d) built an in-memory fake in os-sdlc test/support: FakeGit, FakeGitRepository, FreshGitRepository, and GitMarker.
Other consumers (os-me, os-backlog, delta-refinery) will need the same fake.

Reproduce

n/a: design ticket, nothing to reproduce.

Approach

Move the fake into the os_git gem under OsGit::Testing.
The os-git plugin owns and tests it.
os-sdlc uses it from the gem.
Decide whether ScratchRepo stays: os-git's own tests may start git, and consumers may not.

Required work:

Add the repository fake under OsGit::Testing in the gem — check: present FakeGit in plugins/os-git/lib/os_git/testing/**/*.rb
Remove the fake from os-sdlc test/support — check: absent FakeGit in plugins/os-sdlc/test/support/**/*.rb

Acceptance criteria

Given os-sdlc test/support, when searched for FakeGit, then none is found and the tests use OsGit::Testing.
Given the os_git gem, when its suite runs, then the fake has its own tests.

Owner sketch

module OsGit
  module Testing
    class FakeGit
    end
  end
end

VERDICT: CREATE

Origin

Trigger: #1645 agent report.
Improvised this session: none
Chain: each consumer builds its own fake ← OsGit ships no history-modelling fake (plugins/os-git/lib/os_git/testing/) ← DESIGN (ruling 88).
Root candidate: none found; searched FakeGit, ScratchRepo, Backend::Fake, OsGit::Testing, os_git fake, in-memory fake
Where: plugins/os-git/lib/os_git/testing/, plugins/os-sdlc/test/support/
Session: bc5ad309-36b7-4fe5-a67f-1d90187242eb
Transcript: /home/jared/.claude/projects/-home-jared-dev-cc-os-plugins-os-sdlc/bc5ad309-36b7-4fe5-a67f-1d90187242eb.jsonl

## Problem Consumers of the os_git gem must test without starting git (ruling 88, `.claude/rules/ruby-external-calls.md`). `OsGit::Testing::ScratchRepo` starts real git. `OsGit` `Backend::Fake` answers by message name only, so it cannot model a history. #1645 (merged 38b3284d) built an in-memory fake in os-sdlc `test/support`: `FakeGit`, `FakeGitRepository`, `FreshGitRepository`, and `GitMarker`. Other consumers (os-me, os-backlog, delta-refinery) will need the same fake. ## Reproduce n/a: design ticket, nothing to reproduce. ## Approach Move the fake into the os_git gem under `OsGit::Testing`. The os-git plugin owns and tests it. os-sdlc uses it from the gem. Decide whether `ScratchRepo` stays: os-git's own tests may start git, and consumers may not. Required work: 1. Add the repository fake under `OsGit::Testing` in the gem — check: present `FakeGit` in `plugins/os-git/lib/os_git/testing/**/*.rb` 2. Remove the fake from os-sdlc `test/support` — check: absent `FakeGit` in `plugins/os-sdlc/test/support/**/*.rb` ## Acceptance criteria 1. Given os-sdlc `test/support`, when searched for `FakeGit`, then none is found and the tests use `OsGit::Testing`. 2. Given the os_git gem, when its suite runs, then the fake has its own tests. ## Owner sketch ```ruby module OsGit module Testing class FakeGit end end end ``` VERDICT: CREATE ## Origin - Trigger: #1645 agent report. - Improvised this session: none - Chain: each consumer builds its own fake ← `OsGit` ships no history-modelling fake (`plugins/os-git/lib/os_git/testing/`) ← DESIGN (ruling 88). - Root candidate: none found; searched FakeGit, ScratchRepo, Backend::Fake, OsGit::Testing, os_git fake, in-memory fake - Where: plugins/os-git/lib/os_git/testing/, plugins/os-sdlc/test/support/ - Session: bc5ad309-36b7-4fe5-a67f-1d90187242eb - Transcript: /home/jared/.claude/projects/-home-jared-dev-cc-os-plugins-os-sdlc/bc5ad309-36b7-4fe5-a67f-1d90187242eb.jsonl

jared added the

project/cc-os

filed-by/user

category/code-change

labels

2026-11-09 20:46:49 +00:00

jared referenced this issue

2026-11-09 20:46:56 +00:00

os-sdlc tests start git 3,381 times: move Git behind OsGit with a recorded fixture #1645

jared referenced this issue

2026-11-09 20:46:57 +00:00

Build os-git end to end (orchestrator) #1610