jared/cc-os

Watch

Fork 0

Move the close family onto Ticket and Resolution #1618

New issue

Closed

opened 2026-11-06 20:06:23 +00:00 by jared · 3 comments

jared commented

2026-11-06 20:06:23 +00:00

Owner

Problem

close, review, occurrence, and decision-sweep each apply close rules by hand. The rules differ between them, and that difference causes the defects below.

Approach

Move the rules to Ticket#close, Ticket#request_review, Ticket#record_occurrence, and Resolution. Owned rules: inventory 1.1, 1.2, and 1.8. Keep ## Resolution and **Follow-ups:** unchanged.

Required work:

Add the three Ticket methods — check: present def record_occurrence in plugins/os-backlog/lib/backlog/**/*.rb
Route close, close --needs-review, occurrence, and decision-sweep through Ticket.
Fix inventory defect 5 in close.rb and defect 6.
Fix inventory defects 14, 15, and 17.

Acceptance criteria

Given a recurring ticket, when close or decision-sweep runs, then it refuses before any other check.
Given a closed-out ticket with a complete Resolution, when close repeats, then it adds no comment and still closes.
Given a repeat of close --needs-review, when it runs, then no second comment appears.
Given a failed comment write on --needs-review, when the command ends, then the review label is absent.
Given a failed comment read, when close runs, then the failure reaches the caller and no duplicate comment appears.
Given no valid tracker, when decision-sweep runs, then the error names decision-sweep once.
Given a bad argument, when close runs, then the error carries the same prefix as categorize.
Given an occurrence on a recurring ticket, when it runs, then one comment appears and the ticket stays open.

Owner sketch

class Backlog::Ticket
  def close(resolution)
  def request_review(reason, resolution)
  def record_occurrence(resolution)
class Backlog::Tracker
  def save(ticket) # state is the last step
class Backlog::Host::Forgejo
  def close(number)

Non-goals

Do not rename a command before slice 9. Do not change ## Resolution, **Follow-ups:**, the body headings, the check form, the label names, or the issue-show JSON keys. Do not make a behavior change that this ticket does not name.

Blocking edges

Blocked by #1617

Origin

Trigger: port plan, section 5 of docs/system-design-format/proof/2026-11-06-os-backlog-domain-objects.md, slice 5
Improvised this session: none
Chain: os-backlog code has no domain objects ← commands own their own reads and writes ← DESIGN (ADR-0307, plugins/os-backlog/CONTEXT.md)
Root candidate: none found; searched close, Resolution, decision-sweep, occurrence
Where: plugins/os-backlog/lib/backlog/close.rb, plugins/os-backlog/lib/backlog/decision_sweep.rb, plugins/os-backlog/lib/backlog/resolution.rb
Session: 9d8c2e15-00c1-4dec-b177-e749fa05ec67
Transcript: /home/jared/.claude/projects/-home-jared-dev-cc-os/9d8c2e15-00c1-4dec-b177-e749fa05ec67.jsonl

VERDICT: CREATE

## Problem `close`, review, `occurrence`, and `decision-sweep` each apply close rules by hand. The rules differ between them, and that difference causes the defects below. ## Approach Move the rules to `Ticket#close`, `Ticket#request_review`, `Ticket#record_occurrence`, and `Resolution`. Owned rules: inventory 1.1, 1.2, and 1.8. Keep `## Resolution` and `**Follow-ups:**` unchanged. Required work: 1. Add the three `Ticket` methods — check: present `def record_occurrence` in `plugins/os-backlog/lib/backlog/**/*.rb` 2. Route `close`, `close --needs-review`, `occurrence`, and `decision-sweep` through `Ticket`. 3. Fix inventory defect 5 in `close.rb` and defect 6. 4. Fix inventory defects 14, 15, and 17. ## Acceptance criteria 1. Given a `recurring` ticket, when `close` or `decision-sweep` runs, then it refuses before any other check. 2. Given a closed-out ticket with a complete Resolution, when `close` repeats, then it adds no comment and still closes. 3. Given a repeat of `close --needs-review`, when it runs, then no second comment appears. 4. Given a failed comment write on `--needs-review`, when the command ends, then the `review` label is absent. 5. Given a failed comment read, when `close` runs, then the failure reaches the caller and no duplicate comment appears. 6. Given no valid tracker, when `decision-sweep` runs, then the error names `decision-sweep` once. 7. Given a bad argument, when `close` runs, then the error carries the same prefix as `categorize`. 8. Given an `occurrence` on a `recurring` ticket, when it runs, then one comment appears and the ticket stays open. ## Owner sketch ```ruby class Backlog::Ticket def close(resolution) def request_review(reason, resolution) def record_occurrence(resolution) class Backlog::Tracker def save(ticket) # state is the last step class Backlog::Host::Forgejo def close(number) ``` ## Non-goals Do not rename a command before slice 9. Do not change `## Resolution`, `**Follow-ups:**`, the body headings, the check form, the label names, or the `issue-show` JSON keys. Do not make a behavior change that this ticket does not name. ## Blocking edges Blocked by #1617 ## Origin - Trigger: port plan, section 5 of `docs/system-design-format/proof/2026-11-06-os-backlog-domain-objects.md`, slice 5 - Improvised this session: none - Chain: os-backlog code has no domain objects ← commands own their own reads and writes ← DESIGN (ADR-0307, `plugins/os-backlog/CONTEXT.md`) - Root candidate: none found; searched close, Resolution, decision-sweep, occurrence - Where: plugins/os-backlog/lib/backlog/close.rb, plugins/os-backlog/lib/backlog/decision_sweep.rb, plugins/os-backlog/lib/backlog/resolution.rb - Session: 9d8c2e15-00c1-4dec-b177-e749fa05ec67 - Transcript: /home/jared/.claude/projects/-home-jared-dev-cc-os/9d8c2e15-00c1-4dec-b177-e749fa05ec67.jsonl VERDICT: CREATE

jared added the

plugin/os-backlog

filed-by/agent

category/code-change

labels

2026-11-06 20:06:23 +00:00

jared referenced this issue

2026-11-06 20:06:23 +00:00

Move the claim family onto Claim and Checkpoint #1619

jared referenced this issue

2026-11-06 20:59:25 +00:00

Run issue-show and issue-edit through Ticket, Tracker, and the Forgejo host #1615

jared commented

2026-11-06 20:59:26 +00:00

Author

Owner

From #1615: add the state step to Tracker#save here, last in the order.

jared commented

2026-11-06 22:46:29 +00:00

Author

Owner

Work started on branch ticket-1618.

jared commented

2026-11-06 23:20:43 +00:00

Author

Owner

Resolution

Done: close, close --needs-review, occurrence, and decision-sweep run through Ticket and Resolution. State is the last step of Tracker#save. Close is deleted and Ticket::Refused replaces Close::Failed. Defects 5 (close.rb), 6, 14, 15, and 17 are fixed. After the Runner finished, I fixed a behavior change it missed: a repeat close with missing parts refuses again, with a pin.

Evidence: Implementation 254 complete, commit e0e1e358, follow-up commit on the same branch. os-backlog 497 runs on seed 19992, os-sdlc 3508 runs, ticket-takedown 623 runs (before the follow-up edit), 0 failures. This close ran on the new code.

Follow-ups: none. Lens A11 is a code defect: required work added to #1621.

## Resolution **Done:** close, close --needs-review, occurrence, and decision-sweep run through Ticket and Resolution. State is the last step of Tracker#save. Close is deleted and Ticket::Refused replaces Close::Failed. Defects 5 (close.rb), 6, 14, 15, and 17 are fixed. After the Runner finished, I fixed a behavior change it missed: a repeat close with missing parts refuses again, with a pin. **Evidence:** Implementation 254 complete, commit e0e1e358, follow-up commit on the same branch. os-backlog 497 runs on seed 19992, os-sdlc 3508 runs, ticket-takedown 623 runs (before the follow-up edit), 0 failures. This close ran on the new code. **Follow-ups:** none. Lens A11 is a code defect: required work added to #1621.

jared closed this issue

2026-11-06 23:20:43 +00:00

jared referenced this issue from a commit

2026-11-07 07:09:21 +00:00

feat(os-backlog): Audited POODR boundaries for #1618: the close rules sit on Ticket and Resolution, every WORK item is in the tree, and no production-only correction is required. (#1618)

jared referenced this issue from a commit

2026-11-07 07:09:21 +00:00

fix(os-backlog): refuse missing resolution parts on a repeat close (#1618)