Replace the catalog tests that do not detect their patterns #1612

New issue

Open

opened 2026-11-06 18:46:11 +00:00 by jared · 0 comments

jared commented

2026-11-06 18:46:11 +00:00

Owner

Problem

Most catalog tests do not detect their pattern. Only 3 of 24 tests have at least half of their hits true. The grid cells that read these tests are not reliable evidence. This work is parked. It has no order and no date, and it does not block the os-backlog design.

Observed

docs/system-design-format/pattern-research/README.md section 4 ranks the shared causes. A role sees one class (20 patterns). calls counts only constants (16 patterns). Section 6 lists T6 to T22. Section 2 holds the test decisions that remain open. Commit 11bb7a13.

Reproduce

n/a: the research files give the counts for each test.

Approach

New facts, then test replacements, as Jared chooses. Add Factory Method and Abstract Factory entries with the return-value fact, and reopen ruling D71 on eval/ at that time. #1584 folds into the storage test work.

Non-goals

Page text, which #1611 covers. Book checks.

Origin

Trigger: the pattern research rounds in session 99cf732f; Jared asked to park this work.
Improvised this session: none
Chain: wrong test hits ← one class seen at a time, and calls counts only constants ← docs/system-design-format/pattern-research/README.md section 4. End: DESIGN, plugins/os-sdlc/lib/os_sdlc/system_model/class_facts.rb.
Root candidate: none found; searched catalog tests, pattern test, detect their pattern, system_model, storage?, #1584
Where: plugins/os-sdlc/lib/os_sdlc/system_model/catalog/
Session: 99cf732f-5c43-4b14-8f5e-59712e2e9ba9
Transcript: /home/jared/.claude/projects/-home-jared-dev-cc-os/99cf732f-5c43-4b14-8f5e-59712e2e9ba9.jsonl

VERDICT: CREATE

## Problem Most catalog tests do not detect their pattern. Only 3 of 24 tests have at least half of their hits true. The grid cells that read these tests are not reliable evidence. This work is parked. It has no order and no date, and it does not block the os-backlog design. ## Observed `docs/system-design-format/pattern-research/README.md` section 4 ranks the shared causes. A role sees one class (20 patterns). `calls` counts only constants (16 patterns). Section 6 lists T6 to T22. Section 2 holds the test decisions that remain open. Commit 11bb7a13. ## Reproduce n/a: the research files give the counts for each test. ## Approach New facts, then test replacements, as Jared chooses. Add Factory Method and Abstract Factory entries with the return-value fact, and reopen ruling D71 on `eval/` at that time. #1584 folds into the storage test work. ## Non-goals Page text, which #1611 covers. Book checks. ## Origin - Trigger: the pattern research rounds in session 99cf732f; Jared asked to park this work. - Improvised this session: none - Chain: wrong test hits ← one class seen at a time, and `calls` counts only constants ← `docs/system-design-format/pattern-research/README.md` section 4. End: DESIGN, `plugins/os-sdlc/lib/os_sdlc/system_model/class_facts.rb`. - Root candidate: none found; searched catalog tests, pattern test, detect their pattern, system_model, storage?, #1584 - Where: `plugins/os-sdlc/lib/os_sdlc/system_model/catalog/` - Session: 99cf732f-5c43-4b14-8f5e-59712e2e9ba9 - Transcript: /home/jared/.claude/projects/-home-jared-dev-cc-os/99cf732f-5c43-4b14-8f5e-59712e2e9ba9.jsonl VERDICT: CREATE

jared added the

plugin/os-sdlc

filed-by/user

category/code-change

labels

2026-11-06 18:46:11 +00:00