Port os-context and os-vault Python hooks to Ruby #1527
Labels
No labels
P0
P1
P2
P3
bug
category/code-change
category/cross-repo
category/eval-run
category/investigation
category/no-test-target
category/owner-ruling
category/prose-artifact
category/recurring-chore
category/structure
category/umbrella
crc-refactor
create
delete
enhancement
filed-by/agent
filed-by/user
frozen
lint-rule
needs-info
needs-triage
next
plugin/cc-architect
plugin/os
plugin/os-adr
plugin/os-aidd-lint
plugin/os-backlog
plugin/os-context
plugin/os-doc-hygiene
plugin/os-sdlc
plugin/os-vault
project/cc-os
ready-for-agent
ready-for-human
recurring
review
rule-proposal
update
waiting
wayfinder:grilling
wayfinder:map
wayfinder:map
wayfinder:research
wayfinder:task
wayfinder:task
wontfix
worklist/deviations
worklist/lint-rule
worklist/new-implement-build
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
jared/cc-os#1527
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Problem
The journey tracer records in-process Ruby messages only. Two plugins still ship Python hooks: os-context
hooks/inject.py(76 lines, SessionStart prompt composition) and os-vault's nine hook files (637 lines:session_start,session_end,vault_sync,memsearch_sync,post_tool_use_write,session_context,config,hook_io,session_state). These entry points are untraceable while Python. Neither plugin has a Ruby lib or a test runner, so each port creates a new Ruby codebase, not a file swap. The hooks work today. Deferred until the journey map needs them.Reproduce
n/a: feature ticket; the gap is structural.
Approach
Same shape as #1522, #1524 and #1525: one lib class per hook responsibility with injected io, thin
hooks/*.rbwrappers, hooks.json (or the os-vault wrapper scripts) switched toruby, parity diffs against the Python before deletion, Python tests ported to Minitest. Each plugin first needs alib/,tests/all.rbandtests/test_helper.rbwith theuse_casetag.Required work: none beyond the acceptance criteria.
Origin
VERDICT: CREATE
Ruling 17 on #1554 (predicted, confidence 72): this ticket carries the Ruby route for
os-contextandos-vault. Doos-vaultafter #1540 and #1545 settle. No build now.Correction: the Python plugin route ruling is ruling 21 in
docs/decisions/rulings.tsv, not ruling 17. Ruling 17 is the #1545 order.Note from #1576: plugins/os-vault/tests/harness.sh stops before any scenario with 'Hook script not found: hooks/session-start.sh'. The golden files prove nothing today, and #1576 edited session-start-stale/sideeffects/graphify-shim-args.txt by hand with no run to verify it. Repair or retire the harness in this port.