jared/cc-os

Watch

Fork 0

Credit a nested Data.define block to its own class #1495

New issue

Closed

opened 2026-11-01 17:18:26 +00:00 by jared · 3 comments

jared commented

2026-11-01 17:18:26 +00:00

Owner

Problem

A nested Entry = Data.define do ... end block is credited to the outer class. The route_log/entry.rb decision is credited to RouteLog.

Reproduce

n/a: design gap in the extractor or detectors; nothing to run.

Approach

Attribute the facts of a nested Data.define block to the nested constant.

Required work: none beyond the acceptance criteria.

Origin

Trigger: follow-up from #1429, #1430, and #1482 close-out; evidence in #1430 noise review; route_log/entry.rb in os-me
Improvised this session: none
Chain: miss or noise ← detector gap ← DESIGN (#1430 noise review; route_log/entry.rb in os-me)
Root candidate: none found; searched backlog for the title terms
Skeptic: VERDICT: CREATE
Where: plugins/os-sdlc/lib/
Session: 313ee80d-b132-4de6-a01d-e1a57fbd3450
Transcript: /home/jared/.claude/projects/-home-jared-dev-cc-os/313ee80d-b132-4de6-a01d-e1a57fbd3450.jsonl

## Problem A nested Entry = Data.define do ... end block is credited to the outer class. The route_log/entry.rb decision is credited to RouteLog. ## Reproduce n/a: design gap in the extractor or detectors; nothing to run. ## Approach Attribute the facts of a nested Data.define block to the nested constant. Required work: none beyond the acceptance criteria. ## Origin - Trigger: follow-up from #1429, #1430, and #1482 close-out; evidence in #1430 noise review; route_log/entry.rb in os-me - Improvised this session: none - Chain: miss or noise ← detector gap ← DESIGN (#1430 noise review; route_log/entry.rb in os-me) - Root candidate: none found; searched backlog for the title terms - Skeptic: VERDICT: CREATE - Where: plugins/os-sdlc/lib/ - Session: 313ee80d-b132-4de6-a01d-e1a57fbd3450 - Transcript: /home/jared/.claude/projects/-home-jared-dev-cc-os/313ee80d-b132-4de6-a01d-e1a57fbd3450.jsonl

jared added the

plugin/os-sdlc

filed-by/user

category/code-change

labels

2026-11-01 17:18:26 +00:00

jared referenced this issue

2026-11-01 17:18:38 +00:00

Add a pattern opportunity detector over the catalog #1430

jared commented

2026-11-01 18:02:47 +00:00

Author

Owner

Work started in worktree branch worktree-agent-ae496a1ab932abb69: fixture tests first, then reruns of the run-3 and run-4 measures.

jared commented

2026-11-01 18:03:04 +00:00

Author

Owner

Occurrence: Credit facts in a nested Data.define block to its own class
Seen: plugins/os-sdlc/lib/os_sdlc/system_model/ (RouteLog, Extractor, Census/settings.rb)
Run: 313ee80d-b132-4de6-a01d-e1a57fbd3450; docs/system-design-format/proof/pattern-distance-run-4.md
Adds: Run 4 shows the credit error gives wrong edge verdicts for RouteLog, Extractor, and Census/settings.rb. Requested priority: P1 (the CLI cannot change labels; Jared or the orchestrator must raise it).

Occurrence: Credit facts in a nested Data.define block to its own class Seen: plugins/os-sdlc/lib/os_sdlc/system_model/ (RouteLog, Extractor, Census/settings.rb) Run: 313ee80d-b132-4de6-a01d-e1a57fbd3450; docs/system-design-format/proof/pattern-distance-run-4.md Adds: Run 4 shows the credit error gives wrong edge verdicts for RouteLog, Extractor, and Census/settings.rb. Requested priority: P1 (the CLI cannot change labels; Jared or the orchestrator must raise it).

jared referenced this issue

2026-11-01 18:03:16 +00:00

Detect the edge: an Edge role exempts adapters from core I/O rules #1504

jared referenced this issue from a commit

2026-11-01 18:10:41 +00:00

fix(system-model): credit Data.define and Struct.new blocks to their own constant (#1495)

jared commented

2026-11-01 18:10:55 +00:00

Author

Owner

Resolution

Done: Facts of a nested Data.define or Struct.new block are credited to the value's own constant (e.g. OsMe::RouteLog::Entry), not the enclosing class; a value with no block gets facts with no methods

Evidence: commit 4b6e2bbc on main (pushed); suite 3082 runs green in a clean worktree of main; test system_model_class_facts_data_values_test.rb; addendum in docs/system-design-format/proof/pattern-distance-run-4.md

Follow-ups: none as a ticket: the remaining gap (the Edge rule counts a value that does I/O with no decision as an adapter) is recorded in the session handoff for Jared's next session

## Resolution **Done:** Facts of a nested Data.define or Struct.new block are credited to the value's own constant (e.g. OsMe::RouteLog::Entry), not the enclosing class; a value with no block gets facts with no methods **Evidence:** commit 4b6e2bbc on main (pushed); suite 3082 runs green in a clean worktree of main; test system_model_class_facts_data_values_test.rb; addendum in docs/system-design-format/proof/pattern-distance-run-4.md **Follow-ups:** none as a ticket: the remaining gap (the Edge rule counts a value that does I/O with no decision as an adapter) is recorded in the session handoff for Jared's next session

jared closed this issue

2026-11-01 18:10:55 +00:00

jared referenced this issue

2026-11-01 18:10:56 +00:00

Give Data and Struct values ClassFacts #1500