Stop factory .new calls in self. methods tripping HEX R2 #1494

New issue

Closed

opened 2026-11-01 17:18:25 +00:00 by jared · 2 comments

jared commented

2026-11-01 17:18:25 +00:00

Owner

Problem

A factory .new call inside a self. method trips HEX R2. Example: os-me moment_store.rb lines 8-10.

Reproduce

n/a: design gap in the extractor or detectors; nothing to run.

Approach

Exempt the factory .new call in a self. method from HEX R2.

Required work: none beyond the acceptance criteria.

Origin

Trigger: follow-up from #1429, #1430, and #1482 close-out; evidence in plugins/os-me/lib/ (moment_store.rb lines 8-10), found in #1430 noise review; docs/system-design-format/proof/pattern-distance-run-3.md
Improvised this session: none
Chain: miss or noise ← detector gap ← DESIGN (plugins/os-me/lib/ (moment_store.rb lines 8-10), found in #1430 noise review; docs/system-design-format/proof/pattern-distance-run-3.md)
Root candidate: none found; searched backlog for the title terms
Skeptic: VERDICT: CREATE
Where: plugins/os-sdlc/lib/
Session: 313ee80d-b132-4de6-a01d-e1a57fbd3450
Transcript: /home/jared/.claude/projects/-home-jared-dev-cc-os/313ee80d-b132-4de6-a01d-e1a57fbd3450.jsonl

## Problem A factory .new call inside a self. method trips HEX R2. Example: os-me moment_store.rb lines 8-10. ## Reproduce n/a: design gap in the extractor or detectors; nothing to run. ## Approach Exempt the factory .new call in a self. method from HEX R2. Required work: none beyond the acceptance criteria. ## Origin - Trigger: follow-up from #1429, #1430, and #1482 close-out; evidence in plugins/os-me/lib/ (moment_store.rb lines 8-10), found in #1430 noise review; docs/system-design-format/proof/pattern-distance-run-3.md - Improvised this session: none - Chain: miss or noise ← detector gap ← DESIGN (plugins/os-me/lib/ (moment_store.rb lines 8-10), found in #1430 noise review; docs/system-design-format/proof/pattern-distance-run-3.md) - Root candidate: none found; searched backlog for the title terms - Skeptic: VERDICT: CREATE - Where: plugins/os-sdlc/lib/ - Session: 313ee80d-b132-4de6-a01d-e1a57fbd3450 - Transcript: /home/jared/.claude/projects/-home-jared-dev-cc-os/313ee80d-b132-4de6-a01d-e1a57fbd3450.jsonl

jared added the

plugin/os-sdlc

filed-by/user

category/code-change

labels

2026-11-01 17:18:25 +00:00

jared referenced this issue

2026-11-01 17:18:38 +00:00

Add a pattern opportunity detector over the catalog #1430

jared commented

2026-11-01 21:32:04 +00:00

Author

Owner

Work started on branch worktree-agent-ae04da1576293993c

jared referenced this issue from a commit

2026-11-01 21:43:35 +00:00

fix(system-model): a factory .new in a self. method is not an R2 construct (#1494)

jared commented

2026-11-01 21:43:36 +00:00

Author

Owner

Resolution

Done: A .new inside a def self. method is a factory construct; HEX R2 skips it

Evidence: 3edd4cb3 on main; suite 3098 runs 0 failures; run 3 holdout unchanged 8/9, 10/12, 28/39

Follow-ups: none: Catalog::Repository constructs.empty? check left as is until data shows a factory false positive

## Resolution **Done:** A .new inside a def self. method is a factory construct; HEX R2 skips it **Evidence:** 3edd4cb3 on main; suite 3098 runs 0 failures; run 3 holdout unchanged 8/9, 10/12, 28/39 **Follow-ups:** none: Catalog::Repository constructs.empty? check left as is until data shows a factory false positive

jared closed this issue

2026-11-01 21:43:36 +00:00