jared/cc-os

Watch

Fork 0

Rename the two os-sdlc FakeRunner fakes after their collaborator #1468

New issue

Closed

opened 2026-10-28 16:56:50 +00:00 by jared · 2 comments

jared commented

2026-10-28 16:56:50 +00:00

Owner

Problem

Two unrelated fakes share the name FakeRunner.

plugins/os-sdlc/tests/evidence/probe/lsp_test.rb:12 — a nested class with symbols(name:, root:); it fakes a symbol probe.
plugins/os-sdlc/eval/ticket-takedown/test/run_support.rb:12 — call(argv, cwd:, stdin:, timeout:); it fakes the claude CLI call.
A shared name for different jobs hides the collaborator.

Approach

Rename them to FakeSymbolProbe and FakeClaudeCall, or to the collaborator's real name after you read each.
Update callers in those files only.

Required work:

Rename both fakes — check: absent FakeRunner in plugins/os-sdlc/tests/**
Rename the eval fake — check: absent FakeRunner in plugins/os-sdlc/eval/ticket-takedown/test/**

Acceptance criteria

Given the renamed fakes, when the os-sdlc suite and the ticket-takedown eval tests run, then both are green.

Owner sketch

FakeSymbolProbe
FakeClaudeCall

Route: fast-batch.

Origin

Trigger: tests/support inventory survey 2026-10-28 after fast-batch-21 (#1019)
Improvised this session: none
Chain: misnamed or hand-built test records ← convention adopted 2026-10-28 but only TicketFixture converted ← DESIGN (#1019 memo comment)
Root candidate: none found; searched FakeRunner, fake, test double, run_support, lsp_test
Where: plugins/os-sdlc/tests/evidence/probe/lsp_test.rb
Session: 2dd497e0-555e-4518-9cdd-c68461c32463
Transcript: /home/jared/.claude/projects/-home-jared-dev-cc-os/2dd497e0-555e-4518-9cdd-c68461c32463.jsonl

VERDICT: CREATE

Parent: #1019

## Problem Two unrelated fakes share the name `FakeRunner`. 1. `plugins/os-sdlc/tests/evidence/probe/lsp_test.rb:12` — a nested class with `symbols(name:, root:)`; it fakes a symbol probe. 2. `plugins/os-sdlc/eval/ticket-takedown/test/run_support.rb:12` — `call(argv, cwd:, stdin:, timeout:)`; it fakes the claude CLI call. A shared name for different jobs hides the collaborator. ## Approach Rename them to `FakeSymbolProbe` and `FakeClaudeCall`, or to the collaborator's real name after you read each. Update callers in those files only. Required work: 1. Rename both fakes — check: absent `FakeRunner` in `plugins/os-sdlc/tests/**` 2. Rename the eval fake — check: absent `FakeRunner` in `plugins/os-sdlc/eval/ticket-takedown/test/**` ## Acceptance criteria 1. Given the renamed fakes, when the os-sdlc suite and the ticket-takedown eval tests run, then both are green. ## Owner sketch ```ruby FakeSymbolProbe FakeClaudeCall ``` Route: fast-batch. ## Origin - Trigger: tests/support inventory survey 2026-10-28 after fast-batch-21 (#1019) - Improvised this session: none - Chain: misnamed or hand-built test records ← convention adopted 2026-10-28 but only TicketFixture converted ← DESIGN (#1019 memo comment) - Root candidate: none found; searched FakeRunner, fake, test double, run_support, lsp_test - Where: plugins/os-sdlc/tests/evidence/probe/lsp_test.rb - Session: 2dd497e0-555e-4518-9cdd-c68461c32463 - Transcript: /home/jared/.claude/projects/-home-jared-dev-cc-os/2dd497e0-555e-4518-9cdd-c68461c32463.jsonl VERDICT: CREATE Parent: #1019

jared added the

plugin/os-sdlc

filed-by/user

category/structure

labels

2026-10-28 16:56:50 +00:00

jared referenced this issue

2026-10-28 16:56:54 +00:00

Revisit test fixture and factory strategy across plugin test suites #1019

jared referenced this issue

2026-10-28 16:57:34 +00:00

Revisit test fixture and factory strategy across plugin test suites #1019

jared commented

2026-10-28 17:06:29 +00:00

Author

Owner

Work started on branch fast-batch-22.

jared commented

2026-10-28 19:00:09 +00:00

Author

Owner

Resolution

Done: The two FakeRunner fakes carry their collaborator's name: FakeLspSession (tests/evidence/probe/lsp_test.rb, stands in for Evidence::LazyLspSession) and FakeProcessRunner (eval/ticket-takedown/test/run_support.rb, stands in for Takedown::ProcessRunner).

Evidence: fast-batch-22 merged to main 5f32ca8f; commit a43959fe. os-sdlc suite 2904 runs, eval suite 608 runs, 0 failures. No FakeRunner left in tests or eval tests outside frozen ledger data (ruling K2).

Follow-ups: none

## Resolution **Done:** The two FakeRunner fakes carry their collaborator's name: FakeLspSession (tests/evidence/probe/lsp_test.rb, stands in for Evidence::LazyLspSession) and FakeProcessRunner (eval/ticket-takedown/test/run_support.rb, stands in for Takedown::ProcessRunner). **Evidence:** fast-batch-22 merged to main 5f32ca8f; commit a43959fe. os-sdlc suite 2904 runs, eval suite 608 runs, 0 failures. No FakeRunner left in tests or eval tests outside frozen ledger data (ruling K2). **Follow-ups:** none

jared closed this issue

2026-10-28 19:00:09 +00:00

jared referenced this issue

2026-10-28 19:00:30 +00:00

Revisit test fixture and factory strategy across plugin test suites #1019

jared referenced this issue from a commit

2026-10-28 19:01:49 +00:00

refactor(os-sdlc): FakeLspSession and FakeProcessRunner replace the two FakeRunner fakes (#1468, fast-batch-22 finding K)