jared/cc-os

Watch

Fork 0

Move HomeAndStart out of project_scenario.rb into its own file #1460

New issue

Closed

opened 2026-10-28 15:40:20 +00:00 by jared · 1 comment

jared commented

2026-10-28 15:40:20 +00:00

Owner

Move HomeAndStart out of project_scenario.rb into its own file [capture]

Problem

plugins/os-sdlc/tests/support/project_scenario.rb defines two constants: HomeAndStart on line 7 and ProjectScenario. Zeitwerk expects one constant per file (ADR-0241). The takedown eval test helper cannot load ProjectScenario without HomeAndStart (ticket 5).

Approach

Required work:

Move HomeAndStart = Data.define(:home, :start) from plugins/os-sdlc/tests/support/project_scenario.rb to the new file plugins/os-sdlc/tests/support/home_and_start.rb — check: absent HomeAndStart = in plugins/os-sdlc/tests/support/project_scenario.rb

No caller changes.

Route: fast-batch.

Acceptance criteria

Given the moved constant, when the suite eager-loads tests/support, then Zeitwerk resolves HomeAndStart from home_and_start.rb and the suite is green.

Owner sketch

HomeAndStart = Data.define(:home, :start)

Origin

Trigger: fixture survey re-verified 2026-10-28 for #1019
Improvised this session: none
Chain: hand-built test records ← no fixture convention and no delivery to the test-writer ← DESIGN (#1019 memo comment 2026-10-28)
Root candidate: none found; searched per skeptic (see VERDICT)
Where: plugins/os-sdlc/tests/support/project_scenario.rb
Session: 2dd497e0-555e-4518-9cdd-c68461c32463
Transcript: /home/jared/.claude/projects/-home-jared-dev-cc-os/2dd497e0-555e-4518-9cdd-c68461c32463.jsonl

VERDICT: CREATE

Parent: #1019

# Move HomeAndStart out of project_scenario.rb into its own file [capture] ## Problem `plugins/os-sdlc/tests/support/project_scenario.rb` defines two constants: `HomeAndStart` on line 7 and `ProjectScenario`. Zeitwerk expects one constant per file (ADR-0241). The takedown eval test helper cannot load `ProjectScenario` without `HomeAndStart` (ticket 5). ## Approach Required work: 1. Move `HomeAndStart = Data.define(:home, :start)` from `plugins/os-sdlc/tests/support/project_scenario.rb` to the new file `plugins/os-sdlc/tests/support/home_and_start.rb` — check: absent `HomeAndStart = ` in `plugins/os-sdlc/tests/support/project_scenario.rb` No caller changes. Route: fast-batch. ## Acceptance criteria 1. Given the moved constant, when the suite eager-loads `tests/support`, then Zeitwerk resolves `HomeAndStart` from `home_and_start.rb` and the suite is green. ## Owner sketch ```ruby HomeAndStart = Data.define(:home, :start) ``` ## Origin - Trigger: fixture survey re-verified 2026-10-28 for #1019 - Improvised this session: none - Chain: hand-built test records ← no fixture convention and no delivery to the test-writer ← DESIGN (#1019 memo comment 2026-10-28) - Root candidate: none found; searched per skeptic (see VERDICT) - Where: plugins/os-sdlc/tests/support/project_scenario.rb - Session: 2dd497e0-555e-4518-9cdd-c68461c32463 - Transcript: /home/jared/.claude/projects/-home-jared-dev-cc-os/2dd497e0-555e-4518-9cdd-c68461c32463.jsonl VERDICT: CREATE Parent: #1019

jared added the

plugin/os-sdlc

filed-by/user

category/structure

labels

2026-10-28 15:40:20 +00:00

jared referenced this issue

2026-10-28 15:40:24 +00:00

Replace hand-built ticket bodies and project.yaml Hashes in os-sdlc tests with fixtures #1461

jared referenced this issue

2026-10-28 15:40:25 +00:00

Revisit test fixture and factory strategy across plugin test suites #1019

jared referenced this issue

2026-10-28 15:40:45 +00:00

Audit takedown eval for duplicates of os-sdlc lib, move onto owners #1011

jared commented

2026-10-28 16:46:18 +00:00

Author

Owner

Resolution

Done: HomeAndStart moved to plugins/os-sdlc/tests/support/home_and_start.rb; removed from project_scenario.rb; no caller changes.

Evidence: fast-batch-21 commit 96cfdda4, merged to main 70ecc103; full suite 2903 runs 0 failures on the merged head; memo docs/crc/os-sdlc/fast-batch-21/finding-a-home-and-start-split.md

Follow-ups: none

## Resolution **Done:** HomeAndStart moved to plugins/os-sdlc/tests/support/home_and_start.rb; removed from project_scenario.rb; no caller changes. **Evidence:** fast-batch-21 commit 96cfdda4, merged to main 70ecc103; full suite 2903 runs 0 failures on the merged head; memo docs/crc/os-sdlc/fast-batch-21/finding-a-home-and-start-split.md **Follow-ups:** none

jared closed this issue

2026-10-28 16:46:18 +00:00

jared referenced this issue

2026-10-28 16:46:27 +00:00

Revisit test fixture and factory strategy across plugin test suites #1019

jared referenced this issue from a commit

2026-10-28 16:46:28 +00:00

refactor(os-sdlc): move HomeAndStart to its own support file (#1460)