Fix 5 RawFileContentAssertion offenses that make os-sdlc lint red on main #1456

New issue

Closed

opened 2026-10-28 07:26:03 +00:00 by jared · 1 comment

jared commented

2026-10-28 07:26:03 +00:00

Owner

Problem

The os-sdlc lint is red on main. Any gate that lints all of os-sdlc fails on offenses that the current change did not make.

Observed

cd plugins/os-sdlc && bundle exec rubocop -c .rubocop.yml --format emacs | grep ': C: '

tests/lint/lint_worklist_residual_dispatch_test.rb:37:5: C: Sdlc/Structural/RawFileContentAssertion: asserts on the raw serialized content of a file the code under test wrote (File.r...
tests/lint/lint_worklist_residual_dispatch_test.rb:38:5: (same)
tests/lint/lint_worklist_residual_dispatch_test.rb:39:5: (same)
tests/lint/worklist/listing_test.rb:41:5: (same)
tests/lint/worklist/listing_test.rb:42:5: (same)

Main 9a03c5a4 had the 5 offenses before #1449 merged. #1449 did not touch these files.
The .rubocop.yml entries for this cop still name the old path tests/lint_worklist_residual_dispatch_test.rb, so the file move may be the cause. Open #1008 redesigns the cop but does not fix these sites.

Reproduce

cd plugins/os-sdlc && bundle exec rubocop -c .rubocop.yml tests/lint/lint_worklist_residual_dispatch_test.rb tests/lint/worklist/listing_test.rb

Origin

Trigger: #1449 full-plugin lint check before merge.
Improvised this session: none
Chain: lint red on main ← tests assert on raw written file content ← UNKNOWN which commit added the offenses or widened the cop
Root candidate: none found; searched RawFileContentAssertion, lint_worklist_residual_dispatch, listing_test
Where: plugins/os-sdlc/tests/lint/worklist/listing_test.rb
Session: 9f415790-a6bd-4850-8d70-3dd45004ce2b
Transcript: /home/jared/.claude/projects/-home-jared-dev-cc-os/9f415790-a6bd-4850-8d70-3dd45004ce2b.jsonl

VERDICT: CREATE

## Problem The os-sdlc lint is red on main. Any gate that lints all of os-sdlc fails on offenses that the current change did not make. ## Observed ``` cd plugins/os-sdlc && bundle exec rubocop -c .rubocop.yml --format emacs | grep ': C: ' ``` ``` tests/lint/lint_worklist_residual_dispatch_test.rb:37:5: C: Sdlc/Structural/RawFileContentAssertion: asserts on the raw serialized content of a file the code under test wrote (File.r... tests/lint/lint_worklist_residual_dispatch_test.rb:38:5: (same) tests/lint/lint_worklist_residual_dispatch_test.rb:39:5: (same) tests/lint/worklist/listing_test.rb:41:5: (same) tests/lint/worklist/listing_test.rb:42:5: (same) ``` Main 9a03c5a4 had the 5 offenses before #1449 merged. #1449 did not touch these files. The `.rubocop.yml` entries for this cop still name the old path `tests/lint_worklist_residual_dispatch_test.rb`, so the file move may be the cause. Open #1008 redesigns the cop but does not fix these sites. ## Reproduce ``` cd plugins/os-sdlc && bundle exec rubocop -c .rubocop.yml tests/lint/lint_worklist_residual_dispatch_test.rb tests/lint/worklist/listing_test.rb ``` ## Origin - Trigger: #1449 full-plugin lint check before merge. - Improvised this session: none - Chain: lint red on main ← tests assert on raw written file content ← UNKNOWN which commit added the offenses or widened the cop - Root candidate: none found; searched RawFileContentAssertion, lint_worklist_residual_dispatch, listing_test - Where: plugins/os-sdlc/tests/lint/worklist/listing_test.rb - Session: 9f415790-a6bd-4850-8d70-3dd45004ce2b - Transcript: /home/jared/.claude/projects/-home-jared-dev-cc-os/9f415790-a6bd-4850-8d70-3dd45004ce2b.jsonl VERDICT: CREATE

jared added the

plugin/os-sdlc

filed-by/agent

category/code-change

labels

2026-10-28 07:26:03 +00:00

jared referenced this issue

2026-10-28 07:26:10 +00:00

Widen QueryMethodReachesWrite to follow calls into same-file classes #1449

jared referenced this issue

2026-10-28 07:28:39 +00:00

Gate: full-tree lint sweep as a hard suite-gate check #1418

jared commented

2026-10-28 13:36:54 +00:00

Author

Owner

Resolution

Done: The 5 os-sdlc RawFileContentAssertion offenses are gone: the fix-lints brief tests compare residual-NN.txt and group-NN.txt whole against producer-built bytes, because the agent reads those files verbatim; the residual test also asserts the unit holds only lib/a.rb.

Evidence: fast-batch-19 merged to main (da267c11, 663bafeb, 023bd9ee); full suite 2880 runs, 0 failures; gate cop 0 offenses on both files; stranger reviews in docs/crc/os-sdlc/fast-batch-19/rulings.tsv R2-R6.

Follow-ups: Dropped: a public reader for the group brief bytes on BatchAssignments (would let listing_test drop its copy of the join) — no defect today, speculative.

## Resolution **Done:** The 5 os-sdlc RawFileContentAssertion offenses are gone: the fix-lints brief tests compare residual-NN.txt and group-NN.txt whole against producer-built bytes, because the agent reads those files verbatim; the residual test also asserts the unit holds only lib/a.rb. **Evidence:** fast-batch-19 merged to main (da267c11, 663bafeb, 023bd9ee); full suite 2880 runs, 0 failures; gate cop 0 offenses on both files; stranger reviews in docs/crc/os-sdlc/fast-batch-19/rulings.tsv R2-R6. **Follow-ups:** Dropped: a public reader for the group brief bytes on BatchAssignments (would let listing_test drop its copy of the join) — no defect today, speculative.

jared closed this issue

2026-10-28 13:36:54 +00:00

jared referenced this issue from a commit

2026-10-28 13:37:03 +00:00

test(os-sdlc): assert agent brief files whole against producer-built bytes (#1456)