Fix 3 ParameterListSignalsMissingObject hits in os-context scripts #1455

New issue

Closed

opened 2026-10-28 06:39:08 +00:00 by jared · 1 comment

jared commented

2026-10-28 06:39:08 +00:00

Owner

Problem

The gate cop Sdlc/Structural/ParameterListSignalsMissingObject reports 3 offenses in plugins/os-context scripts on main. These offenses existed before the #1448 widening. The #1363 note said the baseline was 0 hits, so the earlier sweep did not inspect these extensionless scripts. Jared's rule for this cop is zero hits with no Exclude list.

Observed

cd plugins/os-sdlc && bundle exec rubocop --cache false -c .rubocop.yml --only Sdlc/Structural/ParameterListSignalsMissingObject ../

plugins/os-context/audit/bin/audit-stats:93:19: C: ... This method takes 5 parameters (max 4).
plugins/os-context/eval/bin/self-test:100:12: C: ... This method takes 9 parameters (max 4).
plugins/os-context/eval/fixture/project/bin/gen-logs:37:13: C: ... This method takes 5 parameters (max 4).

Main 5b80a126, 2026-10-28. The same command from a linked worktree reported only the first two.

Reproduce

cd plugins/os-sdlc && bundle exec rubocop --cache false -c .rubocop.yml --only Sdlc/Structural/ParameterListSignalsMissingObject ../

Approach

For each hit, find the values that travel together, and pass a built value object (Data.define) instead of its parts. No Exclude list and no rubocop:disable.

Required work: none beyond the acceptance criteria.

Acceptance criteria

Given main, when the command in Reproduce runs, then it reports no offenses in plugins/os-context.
Given the change, when the os-context tests run, then they pass.

Origin

Trigger: probe of the widened cop over plugins/ while working #1448
Improvised this session: none
Chain: 3 hits on main ← earlier baseline sweep skipped extensionless scripts ← IMPROVISATION (the #1363 baseline note)
Root candidate: none found; searched ParameterListSignalsMissingObject, os-context, audit-stats, self-test, gen-logs
Where: plugins/os-context/audit/bin/audit-stats, plugins/os-context/eval/bin/self-test, plugins/os-context/eval/fixture/project/bin/gen-logs
Session: 9f415790-a6bd-4850-8d70-3dd45004ce2b
Transcript: /home/jared/.claude/projects/-home-jared-dev-cc-os/9f415790-a6bd-4850-8d70-3dd45004ce2b.jsonl

VERDICT: CREATE

## Problem The gate cop `Sdlc/Structural/ParameterListSignalsMissingObject` reports 3 offenses in `plugins/os-context` scripts on main. These offenses existed before the #1448 widening. The #1363 note said the baseline was 0 hits, so the earlier sweep did not inspect these extensionless scripts. Jared's rule for this cop is zero hits with no Exclude list. ## Observed ``` cd plugins/os-sdlc && bundle exec rubocop --cache false -c .rubocop.yml --only Sdlc/Structural/ParameterListSignalsMissingObject ../ ``` ``` plugins/os-context/audit/bin/audit-stats:93:19: C: ... This method takes 5 parameters (max 4). plugins/os-context/eval/bin/self-test:100:12: C: ... This method takes 9 parameters (max 4). plugins/os-context/eval/fixture/project/bin/gen-logs:37:13: C: ... This method takes 5 parameters (max 4). ``` Main 5b80a126, 2026-10-28. The same command from a linked worktree reported only the first two. ## Reproduce ``` cd plugins/os-sdlc && bundle exec rubocop --cache false -c .rubocop.yml --only Sdlc/Structural/ParameterListSignalsMissingObject ../ ``` ## Approach For each hit, find the values that travel together, and pass a built value object (`Data.define`) instead of its parts. No Exclude list and no `rubocop:disable`. Required work: none beyond the acceptance criteria. ## Acceptance criteria 1. Given main, when the command in Reproduce runs, then it reports no offenses in `plugins/os-context`. 2. Given the change, when the os-context tests run, then they pass. ## Origin - Trigger: probe of the widened cop over `plugins/` while working #1448 - Improvised this session: none - Chain: 3 hits on main ← earlier baseline sweep skipped extensionless scripts ← IMPROVISATION (the #1363 baseline note) - Root candidate: none found; searched ParameterListSignalsMissingObject, os-context, audit-stats, self-test, gen-logs - Where: plugins/os-context/audit/bin/audit-stats, plugins/os-context/eval/bin/self-test, plugins/os-context/eval/fixture/project/bin/gen-logs - Session: 9f415790-a6bd-4850-8d70-3dd45004ce2b - Transcript: /home/jared/.claude/projects/-home-jared-dev-cc-os/9f415790-a6bd-4850-8d70-3dd45004ce2b.jsonl VERDICT: CREATE

jared added the

plugin/os-context

filed-by/agent

category/code-change

labels

2026-10-28 06:39:08 +00:00

jared referenced this issue

2026-10-28 06:39:13 +00:00

Widen ParameterListSignalsMissingObject to count keys read from **opts #1448