Takedown critic card invites a label B the run did not give #1433

New issue

Closed

opened 2026-10-27 17:50:45 +00:00 by jared · 2 comments

jared commented

2026-10-27 17:50:45 +00:00

Owner

Problem

plugins/os-sdlc/eval/ticket-takedown/harness/cards/critic.md:3 says designs are "labelled A and, when there are two, B". #1426 made the code tolerate an extra empty label. The card still invites the extra label. A fix that says "cover exactly the ## Design headings in the prompt" failed HarnessFilesTest#test_every_card_is_under_1000_words, because the card is at its word cap. The fix needs a trim elsewhere in the card.

Reproduce

n/a: prose defect in a card.

Origin

Trigger: follow-up to #1426
Improvised this session: none
Chain: critic may return label B for a one-design run ← card line 3 invites it ← card is at its word cap, so the rewording failed (DESIGN: critic.md)
Root candidate: none found; searched cards/critic.md, test_every_card_is_under_1000_words, critic card, critique label, takedown critique
Where: plugins/os-sdlc/eval/ticket-takedown/harness/cards/critic.md
Session: 82e65b81-56fa-4c14-acd0-f225c6f57314
Transcript: /home/jared/.claude/projects/-home-jared-dev-cc-os/82e65b81-56fa-4c14-acd0-f225c6f57314.jsonl

VERDICT: CREATE

## Problem `plugins/os-sdlc/eval/ticket-takedown/harness/cards/critic.md:3` says designs are "labelled `A` and, when there are two, `B`". #1426 made the code tolerate an extra empty label. The card still invites the extra label. A fix that says "cover exactly the `## Design` headings in the prompt" failed `HarnessFilesTest#test_every_card_is_under_1000_words`, because the card is at its word cap. The fix needs a trim elsewhere in the card. ## Reproduce n/a: prose defect in a card. ## Origin - Trigger: follow-up to #1426 - Improvised this session: none - Chain: critic may return label B for a one-design run ← card line 3 invites it ← card is at its word cap, so the rewording failed (DESIGN: critic.md) - Root candidate: none found; searched cards/critic.md, test_every_card_is_under_1000_words, critic card, critique label, takedown critique - Where: plugins/os-sdlc/eval/ticket-takedown/harness/cards/critic.md - Session: 82e65b81-56fa-4c14-acd0-f225c6f57314 - Transcript: /home/jared/.claude/projects/-home-jared-dev-cc-os/82e65b81-56fa-4c14-acd0-f225c6f57314.jsonl VERDICT: CREATE

jared added the

plugin/os-sdlc

filed-by/user

category/prose-artifact

labels

2026-10-27 17:50:45 +00:00

jared referenced this issue

2026-10-27 17:50:53 +00:00

Accept extra empty critique labels in the takedown critique step #1426

jared commented

2026-10-27 17:51:34 +00:00

Author

Owner

Work started on branch ticket-1433 (worktree).

jared referenced this issue from a commit

2026-10-27 17:53:08 +00:00

fix(os-sdlc): critic card names only the given design labels (#1433)

jared commented

2026-10-27 17:55:25 +00:00

Author

Owner

Resolution

Done: critic.md now tells the critic to review exactly the designs under the ## Design headings, with one designs entry per heading and no other labels. Repeated sentences were cut to stay under the 1000-word cap (995 to 988 words).

Evidence: main f72cd0fe (commit 53f56453). Takedown suite 624 runs, 0 failures, including HarnessFilesTest.

Follow-ups: none

## Resolution **Done:** critic.md now tells the critic to review exactly the designs under the ## Design <label> headings, with one designs entry per heading and no other labels. Repeated sentences were cut to stay under the 1000-word cap (995 to 988 words). **Evidence:** main f72cd0fe (commit 53f56453). Takedown suite 624 runs, 0 failures, including HarnessFilesTest. **Follow-ups:** none

jared closed this issue

2026-10-27 17:55:25 +00:00

jared referenced this issue from a commit

2026-10-27 17:55:39 +00:00

docs(os-sdlc): History rows for #1432 and #1433