Stop fast-gate NewOffenseCheck from treating a Metrics offense with a changed count as new #1408

Open
opened 2026-10-26 21:20:35 +00:00 by jared · 0 comments
Owner

Problem

fast-gate NewOffenseCheck compares [path, cop, message]. Metrics messages hold the count, so an existing offense whose count changes shows as a new offense and the gate goes red. Example: os-backlog smoke AbcSize 16.52 to 17.49 reported as new.

Reproduce

n/a: see rulings.tsv row R8 and finding-e memo.

Origin

  • Trigger: fast-batch-15 (#1329-#1336), ruling R8
  • Improvised this session: the batch suite and rubocop decided the merge
  • Chain: false red gate ← offense identity includes the Metrics count ← DESIGN (fast_gate NewOffenseCheck)
  • Root candidate: none found; searched NewOffense, offense, fast-gate, fast_gate, Metrics, AbcSize, false red
  • Where: plugins/os-sdlc/lib/os_sdlc/fast_gate
  • Session: 6c6b6eae-4ebd-4ac4-9b32-535875a6b39b
  • Transcript: /home/jared/.claude/projects/-home-jared-dev-cc-os--claude-worktrees-fast-batch-15/6c6b6eae-4ebd-4ac4-9b32-535875a6b39b.jsonl

VERDICT: CREATE

## Problem fast-gate `NewOffenseCheck` compares `[path, cop, message]`. Metrics messages hold the count, so an existing offense whose count changes shows as a new offense and the gate goes red. Example: os-backlog smoke AbcSize 16.52 to 17.49 reported as new. ## Reproduce n/a: see rulings.tsv row R8 and finding-e memo. ## Origin - Trigger: fast-batch-15 (#1329-#1336), ruling R8 - Improvised this session: the batch suite and rubocop decided the merge - Chain: false red gate ← offense identity includes the Metrics count ← DESIGN (fast_gate NewOffenseCheck) - Root candidate: none found; searched NewOffense, offense, fast-gate, fast_gate, Metrics, AbcSize, false red - Where: plugins/os-sdlc/lib/os_sdlc/fast_gate - Session: 6c6b6eae-4ebd-4ac4-9b32-535875a6b39b - Transcript: /home/jared/.claude/projects/-home-jared-dev-cc-os--claude-worktrees-fast-batch-15/6c6b6eae-4ebd-4ac4-9b32-535875a6b39b.jsonl VERDICT: CREATE
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
jared/cc-os#1408
No description provided.