OneThingPrompt::Hook#run hides errors with a silent rescue #1389

New issue

Open

opened 2026-10-25 21:29:38 +00:00 by jared · 0 comments

jared commented

2026-10-25 21:29:38 +00:00

Owner

Problem

A broken hook looks the same as a hook with nothing to say. A failure stays hidden.

Observed

plugins/os-me/lib/os_me/one_thing_prompt/hook.rb:10-16 has rescue StandardError that returns nil in OsMe::OneThingPrompt::Hook#run.

Reproduce

n/a: this is a design gap, not a failure with a command.

Approach

Write e.class and e.message to an injected stderr, as the os-aidd-lint hooks do. Fail loudly.

Origin

Trigger: in-process test conversion of os-me tests (finding-d) in fast-batch-15
Improvised this session: none
Chain: a broken hook looks like nothing to say ← Hook#run rescues StandardError and returns nil ← DESIGN (plugins/os-me/lib/os_me/one_thing_prompt/hook.rb:10-16)
Root candidate: none found; searched OneThingPrompt, one_thing_prompt, rescue StandardError, swallow
VERDICT: CREATE
Where: plugins/os-me/lib/os_me/one_thing_prompt/hook.rb:10-16
Session: 01c29715-c945-43b4-86fc-6c5fc6c4dd3f
Transcript: /home/jared/.claude/projects/-home-jared-dev-cc-os/01c29715-c945-43b4-86fc-6c5fc6c4dd3f.jsonl

## Problem A broken hook looks the same as a hook with nothing to say. A failure stays hidden. ## Observed plugins/os-me/lib/os_me/one_thing_prompt/hook.rb:10-16 has `rescue StandardError` that returns nil in OsMe::OneThingPrompt::Hook#run. ## Reproduce n/a: this is a design gap, not a failure with a command. ## Approach Write e.class and e.message to an injected stderr, as the os-aidd-lint hooks do. Fail loudly. ## Origin - Trigger: in-process test conversion of os-me tests (finding-d) in fast-batch-15 - Improvised this session: none - Chain: a broken hook looks like nothing to say ← Hook#run rescues StandardError and returns nil ← DESIGN (plugins/os-me/lib/os_me/one_thing_prompt/hook.rb:10-16) - Root candidate: none found; searched OneThingPrompt, one_thing_prompt, rescue StandardError, swallow - VERDICT: CREATE - Where: plugins/os-me/lib/os_me/one_thing_prompt/hook.rb:10-16 - Session: 01c29715-c945-43b4-86fc-6c5fc6c4dd3f - Transcript: /home/jared/.claude/projects/-home-jared-dev-cc-os/01c29715-c945-43b4-86fc-6c5fc6c4dd3f.jsonl

jared added the

project/cc-os

filed-by/agent

category/code-change

labels

2026-10-25 21:29:38 +00:00