Pass the user into Backlog::Checkout from bin/os-backlog #1386

New issue

Open

opened 2026-10-25 21:29:34 +00:00 by jared · 0 comments

jared commented

2026-10-25 21:29:34 +00:00

Owner

Problem

Backlog::Checkout reads ENV['USER'] itself. A test that needs a different user must start a subprocess, so it cannot run in-process.

Observed

plugins/os-backlog/lib/backlog/checkout.rb:25 has assignee || ENV["USER"] || "agent".
test_checkout_ignores_cc_os_agent_id_env_and_falls_back_to_user stays an Open3 subprocess.

Reproduce

n/a: this is a design gap, not a failure.

Approach

Pass the user in from bin/os-backlog, so Backlog::Checkout takes the user as a parameter and does not read ENV.
Then run test_checkout_ignores_cc_os_agent_id_env_and_falls_back_to_user in-process.
Keep one Open3 subprocess test for the bin entry, with a comment that states the constraint.

Origin

Trigger: in-process test conversion of os-backlog tests (finding-e) in fast-batch-15
Improvised this session: the test stays an Open3 subprocess
Chain: test stays a subprocess ← Backlog::Checkout reads ENV['USER'] itself ← DESIGN (plugins/os-backlog/lib/backlog/checkout.rb:25)
Root candidate: none found; searched Checkout, ENV USER, backlog checkout.rb
VERDICT: CREATE
Where: plugins/os-backlog/lib/backlog/checkout.rb:25
Session: 01c29715-c945-43b4-86fc-6c5fc6c4dd3f
Transcript: /home/jared/.claude/projects/-home-jared-dev-cc-os/01c29715-c945-43b4-86fc-6c5fc6c4dd3f.jsonl

## Problem Backlog::Checkout reads ENV['USER'] itself. A test that needs a different user must start a subprocess, so it cannot run in-process. ## Observed plugins/os-backlog/lib/backlog/checkout.rb:25 has `assignee || ENV["USER"] || "agent"`. test_checkout_ignores_cc_os_agent_id_env_and_falls_back_to_user stays an Open3 subprocess. ## Reproduce n/a: this is a design gap, not a failure. ## Approach Pass the user in from bin/os-backlog, so Backlog::Checkout takes the user as a parameter and does not read ENV. Then run test_checkout_ignores_cc_os_agent_id_env_and_falls_back_to_user in-process. Keep one Open3 subprocess test for the bin entry, with a comment that states the constraint. ## Origin - Trigger: in-process test conversion of os-backlog tests (finding-e) in fast-batch-15 - Improvised this session: the test stays an Open3 subprocess - Chain: test stays a subprocess ← Backlog::Checkout reads ENV['USER'] itself ← DESIGN (plugins/os-backlog/lib/backlog/checkout.rb:25) - Root candidate: none found; searched Checkout, ENV USER, backlog checkout.rb - VERDICT: CREATE - Where: plugins/os-backlog/lib/backlog/checkout.rb:25 - Session: 01c29715-c945-43b4-86fc-6c5fc6c4dd3f - Transcript: /home/jared/.claude/projects/-home-jared-dev-cc-os/01c29715-c945-43b4-86fc-6c5fc6c4dd3f.jsonl

jared added the

plugin/os-backlog

filed-by/agent

category/code-change

labels

2026-10-25 21:29:34 +00:00

jared referenced this issue

2026-11-02 16:01:01 +00:00

Add a cop for ENV reads in library code (A6) #1506