Wire the reviewer agent into the poodr-ticket-implementation map or retire its charter #1318

New issue

Open

opened 2026-10-25 14:33:00 +00:00 by jared · 0 comments

jared commented

2026-10-25 14:33:00 +00:00

Owner

Problem

The reviewer charter plugins/os-sdlc/agents/reviewer.md is not a node in any approved map. The maps under plugins/os-sdlc/maps/*.yaml name only test-reviewer, and no skill dispatches reviewer. Its judgment items never run in a pipeline. #1316 added items 9 to 11 (open-closed ownership, undeclared new classes, the three gate answers on each CREATES item). Those items read the seam-designer handoff, which the reviewer never receives. The realignment in docs/system-design-format/README.md section 4 depends on a review step that reads CREATES card lines; today no step does.

Observed

grep -n "reviewer" plugins/os-sdlc/maps/*.yaml | grep -v test-reviewer
grep -rln "os-sdlc:reviewer\|agents/reviewer" plugins/os-sdlc/skills plugins/os-sdlc/lib plugins/os-sdlc/references

Both commands print nothing.

Reproduce

n/a: design gap found by audit; the two grep commands above show it.

Approach

Decide one of two: add a reviewer node to poodr-ticket-implementation after the green increment with enrich: [seam-designer] so it receives the CREATES card lines, or retire the charter if test-reviewer and contract-auditor already cover its job and move items 9 to 11 into contract-auditor. The design audit of the #1313-#1316 batch did not rule which; the ticket-skeptic or the owner should.

Required work:

The reviewer's items 9 to 11 run in the poodr-ticket-implementation map, on one node — check: present own the data in plugins/os-sdlc/agents/*.md

Orchestrator work: pick the node or the retirement; update the map-making reference if a node is added; run bin/refresh-plugins.

Rejected: leaving the charter unwired — #1316's items are then dead text and the realignment has no review step.

Acceptance criteria

Given a poodr-ticket-implementation run whose diff creates a class no CREATES item named, when the run reaches review, then a review item lists the class.
Given a run whose diff adds a decision to an object that does not own the data it reads, when the run reaches review, then a finding names the object that should own it.

Owner sketch

# plugins/os-sdlc/maps/poodr-ticket-implementation.yaml
- name: reviewer
  enrich: [seam-designer]

Origin

Trigger: design audit of the #1313-#1316 batch on 2026-10-25, finding 8
Improvised this session: none; reviewer.md:27 now says to apply item 10 only when no seam-designer handoff is in the brief
Chain: reviewer items never run ← reviewer is in no map and no skill (plugins/os-sdlc/maps/*.yaml) ← DESIGN (the maps)
Root candidate: none found; searched reviewer, os-sdlc:reviewer, agents/reviewer, seam-designer, enrich, wire, retire, maps/*.yaml
Where: plugins/os-sdlc/maps/poodr-ticket-implementation.yaml, plugins/os-sdlc/agents/reviewer.md
Session: b154d58f-14cd-41fc-ba1a-04aa88301bfb
Transcript: /home/jared/.claude/projects/-home-jared-dev-cc-os/b154d58f-14cd-41fc-ba1a-04aa88301bfb.jsonl

VERDICT: CREATE

## Problem The reviewer charter `plugins/os-sdlc/agents/reviewer.md` is not a node in any approved map. The maps under `plugins/os-sdlc/maps/*.yaml` name only `test-reviewer`, and no skill dispatches `reviewer`. Its judgment items never run in a pipeline. #1316 added items 9 to 11 (open-closed ownership, undeclared new classes, the three gate answers on each CREATES item). Those items read the seam-designer handoff, which the reviewer never receives. The realignment in docs/system-design-format/README.md section 4 depends on a review step that reads CREATES card lines; today no step does. ## Observed ``` grep -n "reviewer" plugins/os-sdlc/maps/*.yaml | grep -v test-reviewer grep -rln "os-sdlc:reviewer\|agents/reviewer" plugins/os-sdlc/skills plugins/os-sdlc/lib plugins/os-sdlc/references ``` Both commands print nothing. ## Reproduce n/a: design gap found by audit; the two grep commands above show it. ## Approach Decide one of two: add a `reviewer` node to `poodr-ticket-implementation` after the green increment with `enrich: [seam-designer]` so it receives the CREATES card lines, or retire the charter if `test-reviewer` and `contract-auditor` already cover its job and move items 9 to 11 into `contract-auditor`. The design audit of the #1313-#1316 batch did not rule which; the ticket-skeptic or the owner should. Required work: 1. The reviewer's items 9 to 11 run in the poodr-ticket-implementation map, on one node — check: present `own the data` in `plugins/os-sdlc/agents/*.md` Orchestrator work: pick the node or the retirement; update the map-making reference if a node is added; run bin/refresh-plugins. Rejected: leaving the charter unwired — #1316's items are then dead text and the realignment has no review step. ## Acceptance criteria 1. Given a poodr-ticket-implementation run whose diff creates a class no CREATES item named, when the run reaches review, then a review item lists the class. 2. Given a run whose diff adds a decision to an object that does not own the data it reads, when the run reaches review, then a finding names the object that should own it. ## Owner sketch ```yaml # plugins/os-sdlc/maps/poodr-ticket-implementation.yaml - name: reviewer enrich: [seam-designer] ``` ## Origin - Trigger: design audit of the #1313-#1316 batch on 2026-10-25, finding 8 - Improvised this session: none; reviewer.md:27 now says to apply item 10 only when no seam-designer handoff is in the brief - Chain: reviewer items never run ← reviewer is in no map and no skill (plugins/os-sdlc/maps/*.yaml) ← DESIGN (the maps) - Root candidate: none found; searched reviewer, os-sdlc:reviewer, agents/reviewer, seam-designer, enrich, wire, retire, maps/*.yaml - Where: plugins/os-sdlc/maps/poodr-ticket-implementation.yaml, plugins/os-sdlc/agents/reviewer.md - Session: b154d58f-14cd-41fc-ba1a-04aa88301bfb - Transcript: /home/jared/.claude/projects/-home-jared-dev-cc-os/b154d58f-14cd-41fc-ba1a-04aa88301bfb.jsonl VERDICT: CREATE

jared added the

plugin/os-sdlc

filed-by/agent

category/code-change

labels

2026-10-25 14:33:00 +00:00

jared referenced this issue

2026-10-25 14:34:15 +00:00

reviewer judges open-closed ownership and lists undeclared new classes as review items #1316