jared/cc-os

Watch

Fork 0

seam-designer asks who owns the data before preferring an existing seam #1313

New issue

Closed

opened 2026-10-25 00:41:06 +00:00 by jared · 3 comments

jared commented

2026-10-25 00:41:06 +00:00

Owner

Problem

seam-designer rule 1 says "Prefer an existing responsibility owner before proposing a new object; select a new collaborator boundary only when the current change supplies evidence" (plugins/os-sdlc/agents/seam-designer.md:17). The agent never asks who should own the message. It only passes CREATES tokens through (seam-designer.md:36). The lens already has the rule the agent should apply: A12 "If no object owns it, make the concept own it" and A14 "write the card before the class" (plugins/os-sdlc/skills/lens-architecture/SKILL.md:103-123). The result is that every seam lands on an existing object and new objects appear only when the ticket author named them. Design record: docs/system-design-format/README.md section 4.

Reproduce

n/a: charter change.

Approach

Insert an owner step before the existing rule 1. For each message the ticket adds or changes: name the data it decides on; name the existing object that owns that data, with path:line; if no object owns it, emit a CREATES item with a five-line card per A14 (noun, knows, decides, does, guarantees) and place the seam on the new object. Reword rule 1 so "existing" is the result of the owner step, not a preference. Keep rules 2 and 3 unchanged. Add the gate that prevents over-building: a new object must own a secret that no existing object owns; the card's "decides" line is that secret. The gate is three questions, each answered in the CREATES item, and a new object is allowed only when all three have answers: (1) the secret, one sentence "it hides how X is decided"; (2) the existing object checked, with path:line, and why it does not own X; (3) one caller that would change if X changed. If any answer is missing, place the seam on the existing owner and name it. The card also carries an exemplar: line naming one existing file of the same kind, so the programmer learns the house shape of a new object from that one file and nothing else (programmer.md:38 stays unchanged).

Required work:

An owner step before rule 1 in the seam-designer charter — check: present owns the data in plugins/os-sdlc/agents/seam-designer.md
Rule 1 no longer prefers an existing owner before asking who owns the data — check: absent Prefer an existing responsibility owner before proposing a new object in plugins/os-sdlc/agents/seam-designer.md
A CREATES item carries the A14 card lines — check: present decides in plugins/os-sdlc/agents/seam-designer.md
The CREATES item answers the three gate questions — check: present one caller that would change in plugins/os-sdlc/agents/seam-designer.md
The card names an exemplar file — check: present exemplar: in plugins/os-sdlc/agents/seam-designer.md

Orchestrator work: run bin/refresh-plugins after the charter edit; run /os-adr:find on plugins/os-sdlc/agents before editing.

Rejected: a separate owner-designer agent — one more dispatch per ticket for a question seam-designer already has the evidence to answer.

Acceptance criteria

Given a ticket whose new message decides on data no existing object owns, when seam-designer runs, then its handoff has a CREATES item with a card and the SEAM names the new object.
Given a ticket whose new message decides on data an existing object owns, when seam-designer runs, then the SEAM names that object with path:line and no CREATES item appears.
Given a CREATES item, when read, then its card has a decides line.
Given a CREATES item, when read, then it names the secret, the existing object checked with path:line, one caller that would change, and an exemplar file.
Given a candidate object whose secret changes with no caller changing, when seam-designer runs, then no CREATES item appears and the SEAM names the existing owner.

Owner sketch

# prose artifact: plugins/os-sdlc/agents/seam-designer.md
# no Ruby owner; the suite gate runs the charter lint

Origin

Trigger: session review of os-sdlc agent charters on 2026-10-24
Improvised this session: none
Chain: seams always land on existing objects ← rule 1 "prefer an existing responsibility owner before proposing a new object" ← DESIGN (plugins/os-sdlc/agents/seam-designer.md:17)
Root candidate: none found; searched seam-designer, CREATES, owns the data, seam_designer, A12, A14, owner
Where: plugins/os-sdlc/agents/seam-designer.md
Session: 5da956dc-a39d-4933-8b16-0fa90b4bb8ca
Transcript: /home/jared/.claude/projects/-home-jared-dev-cc-os/5da956dc-a39d-4933-8b16-0fa90b4bb8ca.jsonl

VERDICT: CREATE

## Problem seam-designer rule 1 says "Prefer an existing responsibility owner before proposing a new object; select a new collaborator boundary only when the current change supplies evidence" (plugins/os-sdlc/agents/seam-designer.md:17). The agent never asks who should own the message. It only passes CREATES tokens through (seam-designer.md:36). The lens already has the rule the agent should apply: A12 "If no object owns it, make the concept own it" and A14 "write the card before the class" (plugins/os-sdlc/skills/lens-architecture/SKILL.md:103-123). The result is that every seam lands on an existing object and new objects appear only when the ticket author named them. Design record: docs/system-design-format/README.md section 4. ## Reproduce n/a: charter change. ## Approach Insert an owner step before the existing rule 1. For each message the ticket adds or changes: name the data it decides on; name the existing object that owns that data, with path:line; if no object owns it, emit a `CREATES` item with a five-line card per A14 (noun, knows, decides, does, guarantees) and place the seam on the new object. Reword rule 1 so "existing" is the result of the owner step, not a preference. Keep rules 2 and 3 unchanged. Add the gate that prevents over-building: a new object must own a secret that no existing object owns; the card's "decides" line is that secret. The gate is three questions, each answered in the CREATES item, and a new object is allowed only when all three have answers: (1) the secret, one sentence "it hides how X is decided"; (2) the existing object checked, with path:line, and why it does not own X; (3) one caller that would change if X changed. If any answer is missing, place the seam on the existing owner and name it. The card also carries an `exemplar:` line naming one existing file of the same kind, so the programmer learns the house shape of a new object from that one file and nothing else (programmer.md:38 stays unchanged). Required work: 1. An owner step before rule 1 in the seam-designer charter — check: present `owns the data` in `plugins/os-sdlc/agents/seam-designer.md` 2. Rule 1 no longer prefers an existing owner before asking who owns the data — check: absent `Prefer an existing responsibility owner before proposing a new object` in `plugins/os-sdlc/agents/seam-designer.md` 3. A `CREATES` item carries the A14 card lines — check: present `decides` in `plugins/os-sdlc/agents/seam-designer.md` 4. The CREATES item answers the three gate questions — check: present `one caller that would change` in `plugins/os-sdlc/agents/seam-designer.md` 5. The card names an exemplar file — check: present `exemplar:` in `plugins/os-sdlc/agents/seam-designer.md` Orchestrator work: run bin/refresh-plugins after the charter edit; run /os-adr:find on plugins/os-sdlc/agents before editing. Rejected: a separate owner-designer agent — one more dispatch per ticket for a question seam-designer already has the evidence to answer. ## Acceptance criteria 1. Given a ticket whose new message decides on data no existing object owns, when seam-designer runs, then its handoff has a CREATES item with a card and the SEAM names the new object. 2. Given a ticket whose new message decides on data an existing object owns, when seam-designer runs, then the SEAM names that object with path:line and no CREATES item appears. 3. Given a CREATES item, when read, then its card has a decides line. 4. Given a CREATES item, when read, then it names the secret, the existing object checked with path:line, one caller that would change, and an exemplar file. 5. Given a candidate object whose secret changes with no caller changing, when seam-designer runs, then no CREATES item appears and the SEAM names the existing owner. ## Owner sketch ```ruby # prose artifact: plugins/os-sdlc/agents/seam-designer.md # no Ruby owner; the suite gate runs the charter lint ``` ## Origin - Trigger: session review of os-sdlc agent charters on 2026-10-24 - Improvised this session: none - Chain: seams always land on existing objects ← rule 1 "prefer an existing responsibility owner before proposing a new object" ← DESIGN (plugins/os-sdlc/agents/seam-designer.md:17) - Root candidate: none found; searched seam-designer, CREATES, owns the data, seam_designer, A12, A14, owner - Where: plugins/os-sdlc/agents/seam-designer.md - Session: 5da956dc-a39d-4933-8b16-0fa90b4bb8ca - Transcript: /home/jared/.claude/projects/-home-jared-dev-cc-os/5da956dc-a39d-4933-8b16-0fa90b4bb8ca.jsonl VERDICT: CREATE

jared added the

plugin/os-sdlc

filed-by/user

category/prose-artifact

labels

2026-10-25 00:41:06 +00:00

jared referenced this issue

2026-10-25 14:07:06 +00:00

reviewer judges open-closed ownership and lists undeclared new classes as review items #1316

jared commented

2026-10-25 14:07:07 +00:00

Author

Owner

Amended 2026-10-25 per accepted prediction: the over-building gate is now three questions answered in the CREATES item (secret, existing object checked, one caller that would change), and the A14 card carries an exemplar: line so the programmer learns a new object's shape from one named file. programmer.md:38 unchanged.

jared referenced this issue

2026-10-25 14:07:07 +00:00

reviewer judges open-closed ownership and lists undeclared new classes as review items #1316

jared commented

2026-10-25 14:21:13 +00:00

Author

Owner

Work started on branch ticket-1315 (shared worktree for #1313-#1316). Deviation: no implementation map accepts category/prose-artifact, so these charter edits are hand-finished per the implement skill's recovery path: one agent per file, gated by the ticket's Required-work checks, aidd-lint, the suites, and one design audit.

jared commented

2026-10-25 14:32:32 +00:00

Author

Owner

Resolution

Done: seam-designer runs an owner step before its selection policy: names the data each message decides on, the existing owner with path:line, else a CREATES item with the A14 card (knows, decides, does, guarantees) plus secret:, checked:, caller:, exemplar: lines. A new object is allowed only when all three gate answers are present; otherwise the seam lands on the existing owner. Rule 1 no longer prefers an existing owner. Frontmatter description updated. OWNER-GAP from change-auditor named as a trigger.

Evidence: main 59f6cdb0 (commits 4a804143, faa10b62). Required-work checks: present 'owns the data', 'decides', 'one caller that would change', 'exemplar:'; absent 'Prefer an existing responsibility owner before proposing a new object'. aidd-lint: no new finding. ruby plugins/os-sdlc/tests/all.rb: 2514 runs, 0 failures. One opus design audit over the four-commit range; its two defects and three risks fixed in faa10b62. bin/refresh-plugins ran via worktree finish. Deviation: hand-finished, no map accepts category/prose-artifact.

Follow-ups: Dropped: a programmer.md line allowing the exemplar read; programmer.md:26 already lets it read files the brief names, and the accepted prediction keeps :38 unchanged. Dropped: test-writer mention of card lines; it reads the whole handoff. The reviewer wiring gap is captured against #1316.

## Resolution **Done:** seam-designer runs an owner step before its selection policy: names the data each message decides on, the existing owner with path:line, else a CREATES item with the A14 card (knows, decides, does, guarantees) plus secret:, checked:, caller:, exemplar: lines. A new object is allowed only when all three gate answers are present; otherwise the seam lands on the existing owner. Rule 1 no longer prefers an existing owner. Frontmatter description updated. OWNER-GAP from change-auditor named as a trigger. **Evidence:** main 59f6cdb0 (commits 4a804143, faa10b62). Required-work checks: present 'owns the data', 'decides', 'one caller that would change', 'exemplar:'; absent 'Prefer an existing responsibility owner before proposing a new object'. aidd-lint: no new finding. ruby plugins/os-sdlc/tests/all.rb: 2514 runs, 0 failures. One opus design audit over the four-commit range; its two defects and three risks fixed in faa10b62. bin/refresh-plugins ran via worktree finish. Deviation: hand-finished, no map accepts category/prose-artifact. **Follow-ups:** Dropped: a programmer.md line allowing the exemplar read; programmer.md:26 already lets it read files the brief names, and the accepted prediction keeps :38 unchanged. Dropped: test-writer mention of card lines; it reads the whole handoff. The reviewer wiring gap is captured against #1316.

jared closed this issue

2026-10-25 14:32:32 +00:00

jared referenced this issue from a commit

2026-10-25 14:34:50 +00:00

feat(os-sdlc): seam-designer runs an owner step and gates new objects on an owned secret (#1313)

jared referenced this issue from a commit

2026-10-25 14:34:50 +00:00

fix(os-sdlc,os-backlog): audit fixes for the realignment charters: one secret line, OWNER-GAP trigger, reviewer item source, questions a and b (#1313 #1315 #1316)