Move CollaboratorPass::StopCheck::SettingsDiffer to its own error file #1258

New issue

Closed

opened 2026-10-23 17:06:48 +00:00 by jared · 1 comment

jared commented

2026-10-23 17:06:48 +00:00

Owner

Problem

CollaboratorPass::StopCheck::SettingsDiffer is nested in collaborator_pass/stop_check.rb:6. Structure ruling S45 moves the error to its own file so that the path spells the constant (lens A15) and the concept file holds one class.

Reproduce

n/a: structure-only move; no defect to reproduce.

Approach

Move the class body unchanged. Update each holder to the new constant. The existing suite, green, is the proof; add no test.

Required work:

Define CollaboratorPass::SettingsDifferError < StandardError in its own file — check: present class SettingsDifferError < StandardError in plugins/os-sdlc/lib/os_sdlc/collaborator_pass/settings_differ_error.rb
Remove the nested class and update the holders stop_check.rb:16 and command/stop_check.rb:28 — check: absent class SettingsDiffer < in plugins/os-sdlc/lib/os_sdlc/collaborator_pass/stop_check.rb

Rejected: keep the nested class — the ruling is recorded and the error lineage design (S31) puts each error in its own file.

Acceptance criteria

Given the stop-check settings differ, when the stop check runs, then it raises and reports the same error message as before.

Origin

Trigger: CRC run 4, phase 1b step 4 (errors), bin/detector error-lineage --target os-sdlc
Improvised this session: none
Chain: nested error class ← run 3 ruled S45 but wave 2 kept the concept file ← DESIGN (docs/crc/os-sdlc/wave0/structure-rulings.tsv S45)
Root candidate: none found; searched SettingsDiffer, StopCheck, nested error, own file
Where: plugins/os-sdlc/lib/os_sdlc/collaborator_pass/stop_check.rb
Ledger: docs/crc/os-sdlc/ledger.tsv
Rulings: docs/crc/os-sdlc/wave0/structure-rulings.tsv
Session: c1bedec6-7e01-45ab-b9db-22d63652c19f
Transcript: /home/jared/.claude/projects/-home-jared-dev-cc-os--claude-worktrees-crc-os-sdlc-run-4/c1bedec6-7e01-45ab-b9db-22d63652c19f.jsonl

VERDICT: CREATE

## Problem `CollaboratorPass::StopCheck::SettingsDiffer` is nested in `collaborator_pass/stop_check.rb:6`. Structure ruling S45 moves the error to its own file so that the path spells the constant (lens A15) and the concept file holds one class. ## Reproduce n/a: structure-only move; no defect to reproduce. ## Approach Move the class body unchanged. Update each holder to the new constant. The existing suite, green, is the proof; add no test. Required work: 1. Define `CollaboratorPass::SettingsDifferError < StandardError` in its own file — check: present `class SettingsDifferError < StandardError` in `plugins/os-sdlc/lib/os_sdlc/collaborator_pass/settings_differ_error.rb` 2. Remove the nested class and update the holders `stop_check.rb:16` and `command/stop_check.rb:28` — check: absent `class SettingsDiffer <` in `plugins/os-sdlc/lib/os_sdlc/collaborator_pass/stop_check.rb` Rejected: keep the nested class — the ruling is recorded and the error lineage design (S31) puts each error in its own file. ## Acceptance criteria 1. Given the stop-check settings differ, when the stop check runs, then it raises and reports the same error message as before. ## Origin - Trigger: CRC run 4, phase 1b step 4 (errors), `bin/detector error-lineage --target os-sdlc` - Improvised this session: none - Chain: nested error class ← run 3 ruled S45 but wave 2 kept the concept file ← DESIGN (docs/crc/os-sdlc/wave0/structure-rulings.tsv S45) - Root candidate: none found; searched SettingsDiffer, StopCheck, nested error, own file - Where: plugins/os-sdlc/lib/os_sdlc/collaborator_pass/stop_check.rb - Ledger: docs/crc/os-sdlc/ledger.tsv - Rulings: docs/crc/os-sdlc/wave0/structure-rulings.tsv - Session: c1bedec6-7e01-45ab-b9db-22d63652c19f - Transcript: /home/jared/.claude/projects/-home-jared-dev-cc-os--claude-worktrees-crc-os-sdlc-run-4/c1bedec6-7e01-45ab-b9db-22d63652c19f.jsonl VERDICT: CREATE

jared added the

labels

2026-10-23 17:06:48 +00:00

jared referenced this issue from a commit

2026-10-23 17:18:59 +00:00

refactor(os-sdlc): move StopCheck::SettingsDiffer to CollaboratorPass::SettingsDifferError (#1258)

jared commented

2026-10-23 17:20:06 +00:00

Author

Owner

Resolution

Done: Moved CollaboratorPass::StopCheck::SettingsDiffer to CollaboratorPass::SettingsDifferError in its own file (S45, fast-batch-13).

Evidence: 118c9a82; suite 2458 runs, 0 failures, 0 errors (82 s); eager load silent; fast-gate PASS, rubocop 0 new offenses; merged to main 6cb38456

Follow-ups: none

## Resolution **Done:** Moved CollaboratorPass::StopCheck::SettingsDiffer to CollaboratorPass::SettingsDifferError in its own file (S45, fast-batch-13). **Evidence:** 118c9a82; suite 2458 runs, 0 failures, 0 errors (82 s); eager load silent; fast-gate PASS, rubocop 0 new offenses; merged to main 6cb38456 **Follow-ups:** none

jared closed this issue

2026-10-23 17:20:06 +00:00