Supply real gate facts to test-reviewer after a reroute #1255

New issue

Open

opened 2026-10-23 15:38:23 +00:00 by jared · 0 comments

jared commented

2026-10-23 15:38:23 +00:00

Owner

Problem

A reroute into test-reviewer ends the run with verdict:error. Dispatch::Brief::Facts#red_tests reads the step summaries of the latest completed dispatch. After a reroute, that dispatch is the map-router, and its only step is reroute with empty output. The reviewer brief then has red_tests = {"reroute" => []}. agents/test-reviewer.md:24 tells the reviewer to settle error with MISSING: red_tests when red_tests is empty. The map's error edge is terminal, so a correct reroute kills the run.

Observed

Implementation 115 (ticket #1239), 2026-10-23. Map-router dispatch 960 chose poodr-ticket-implementation, resume at test-reviewer. Test-reviewer dispatch 962 settled in 15 s. Handoff 990:

verdict: error
MISSING: red_tests
red_tests is empty (reroute: []), so no gate evidence shows the 3 new tests are red.

Reproduce

os-sdlc-reroute-request <id> --situation ... --misfit ...   # map-router picks entry test-reviewer

Approach

Options, not decided: Facts reads the latest dispatch that has gate steps and skips map-router dispatches; or map-router refuses an entry node whose brief needs gate facts (red_tests, gate_results, gate_verdicts) that the reroute cannot supply.

Origin

Trigger: os-sdlc-reroute-request 115 during the #1239 implement run
Improvised this session: a fresh os-sdlc-implementation-open (implementation 118)
Chain: run failed verdict:error ← empty red_tests in the reviewer brief ← Facts#red_tests reads the map-router dispatch (plugins/os-sdlc/lib/os_sdlc/dispatch/brief/facts.rb:68) — DESIGN
Root candidate: none found; searched red_tests, reroute, map-router, test-reviewer, Brief::Facts, gate facts
Where: plugins/os-sdlc/lib/os_sdlc/dispatch/brief/facts.rb
Session: b0da7c4b-f4b3-4f3b-96cd-0b77e82451d4
Transcript: /home/jared/.claude/projects/-home-jared-dev-cc-os/b0da7c4b-f4b3-4f3b-96cd-0b77e82451d4.jsonl

VERDICT: CREATE

## Problem A reroute into `test-reviewer` ends the run with `verdict:error`. `Dispatch::Brief::Facts#red_tests` reads the step summaries of the latest completed dispatch. After a reroute, that dispatch is the `map-router`, and its only step is `reroute` with empty output. The reviewer brief then has `red_tests` = `{"reroute" => []}`. `agents/test-reviewer.md:24` tells the reviewer to settle `error` with `MISSING: red_tests` when `red_tests` is empty. The map's `error` edge is terminal, so a correct reroute kills the run. ## Observed Implementation 115 (ticket #1239), 2026-10-23. Map-router dispatch 960 chose `poodr-ticket-implementation`, resume at `test-reviewer`. Test-reviewer dispatch 962 settled in 15 s. Handoff 990: ``` verdict: error MISSING: red_tests red_tests is empty (reroute: []), so no gate evidence shows the 3 new tests are red. ``` ## Reproduce ``` os-sdlc-reroute-request <id> --situation ... --misfit ... # map-router picks entry test-reviewer ``` ## Approach Options, not decided: `Facts` reads the latest dispatch that has gate steps and skips `map-router` dispatches; or `map-router` refuses an entry node whose brief needs gate facts (`red_tests`, `gate_results`, `gate_verdicts`) that the reroute cannot supply. ## Origin - Trigger: `os-sdlc-reroute-request 115` during the #1239 implement run - Improvised this session: a fresh `os-sdlc-implementation-open` (implementation 118) - Chain: run failed `verdict:error` ← empty `red_tests` in the reviewer brief ← `Facts#red_tests` reads the map-router dispatch (`plugins/os-sdlc/lib/os_sdlc/dispatch/brief/facts.rb:68`) — DESIGN - Root candidate: none found; searched red_tests, reroute, map-router, test-reviewer, Brief::Facts, gate facts - Where: `plugins/os-sdlc/lib/os_sdlc/dispatch/brief/facts.rb` - Session: b0da7c4b-f4b3-4f3b-96cd-0b77e82451d4 - Transcript: /home/jared/.claude/projects/-home-jared-dev-cc-os/b0da7c4b-f4b3-4f3b-96cd-0b77e82451d4.jsonl VERDICT: CREATE

jared added the

plugin/os-sdlc

filed-by/agent

category/code-change

labels

2026-10-23 15:38:23 +00:00

jared referenced this issue

2026-10-23 16:01:42 +00:00

Stop the 60s suite budget from failing bin/fast-gate on a loaded host #1239