Clear the 48 judgement rubocop offenses in the ticket-takedown eval harness #1221

New issue

Open

opened 2026-10-21 20:02:05 +00:00 by jared · 1 comment

jared commented

2026-10-21 20:02:05 +00:00

Owner

Problem

The eval harness under plugins/os-sdlc/eval/ticket-takedown/ and tests/support/fake_rubocop_runner.rb carry 48 rubocop offenses from judgement cops. The CRC refactor never gave eval/ ledger rows, so no pass has read this code. Jared ruled on 2026-10-21 that the 19 mechanical offenses are autocorrected in fast-batch-2 and the 48 judgement offenses get this ticket, not an Exclude.

Observed

cd plugins/os-sdlc && bundle exec rubocop --format offenses eval/ticket-takedown tests/support/fake_rubocop_runner.rb

14 Metrics/AbcSize, 11 Sdlc/Structural/FeatureEnvy, 10 Metrics/PerceivedComplexity, 4 Sdlc/Structural/ParameterListSignalsMissingObject, 2 MutableCollectionLeakViaAttrReader, 2 ParameterThreadedThroughPrivateMethods, 1 each Minitest/MultipleAssertions, SeedSweepAssertion, PrimitiveObsessedIvar, RawFileContentAssertion, UnusedPrivateMethod (measured 2026-10-21, main 272a8cf3; PLAN.md said 89)

Reproduce

cd plugins/os-sdlc && bundle exec rubocop --format offenses eval/ticket-takedown tests/support/fake_rubocop_runner.rb

Approach

Required work: none beyond the acceptance criteria.

Rejected: Exclude eval/**/* for these cops — Jared forbids cop Exclude lists.

Acceptance criteria

Given the eval harness, when rubocop runs over eval/ticket-takedown and tests/support/fake_rubocop_runner.rb, then it reports zero offenses.
Given the eval harness tests, when they run, then they are green.
Given scenario Task blocks and reserve sets, when the work is done, then none were read or run (docs/eval-discipline.md).

Non-goals

The 19 mechanical offenses (Layout, Lint/UnusedMethodArgument, Style/FrozenStringLiteralComment): fast-batch-2.

Origin

Trigger: docs/crc/PLAN.md Phase 9 "Decide the 89 rubocop offenses outside the CRC scope"; measured in fast-batch-2 preparation 2026-10-21
Improvised this session: none
Chain: 48 judgement offenses ← eval/ has no ledger rows so no CRC pass read it ← DESIGN (docs/crc/os-sdlc/ledger.tsv scope)
Root candidate: none found; searched eval ticket-takedown rubocop offenses AbcSize FeatureEnvy
Where: plugins/os-sdlc/eval/ticket-takedown/
Session: 017840c1-178f-4be2-bbb8-c548c9e70349
Transcript: /home/jared/.claude/projects/-home-jared-dev-cc-os/017840c1-178f-4be2-bbb8-c548c9e70349.jsonl

VERDICT: CREATE

## Problem The eval harness under `plugins/os-sdlc/eval/ticket-takedown/` and `tests/support/fake_rubocop_runner.rb` carry 48 rubocop offenses from judgement cops. The CRC refactor never gave `eval/` ledger rows, so no pass has read this code. Jared ruled on 2026-10-21 that the 19 mechanical offenses are autocorrected in fast-batch-2 and the 48 judgement offenses get this ticket, not an Exclude. ## Observed ``` cd plugins/os-sdlc && bundle exec rubocop --format offenses eval/ticket-takedown tests/support/fake_rubocop_runner.rb ``` ``` 14 Metrics/AbcSize, 11 Sdlc/Structural/FeatureEnvy, 10 Metrics/PerceivedComplexity, 4 Sdlc/Structural/ParameterListSignalsMissingObject, 2 MutableCollectionLeakViaAttrReader, 2 ParameterThreadedThroughPrivateMethods, 1 each Minitest/MultipleAssertions, SeedSweepAssertion, PrimitiveObsessedIvar, RawFileContentAssertion, UnusedPrivateMethod (measured 2026-10-21, main 272a8cf3; PLAN.md said 89) ``` ## Reproduce ``` cd plugins/os-sdlc && bundle exec rubocop --format offenses eval/ticket-takedown tests/support/fake_rubocop_runner.rb ``` ## Approach Required work: none beyond the acceptance criteria. Rejected: Exclude `eval/**/*` for these cops — Jared forbids cop Exclude lists. ## Acceptance criteria 1. Given the eval harness, when rubocop runs over `eval/ticket-takedown` and `tests/support/fake_rubocop_runner.rb`, then it reports zero offenses. 2. Given the eval harness tests, when they run, then they are green. 3. Given scenario Task blocks and reserve sets, when the work is done, then none were read or run (docs/eval-discipline.md). ## Non-goals The 19 mechanical offenses (Layout, Lint/UnusedMethodArgument, Style/FrozenStringLiteralComment): fast-batch-2. ## Origin - Trigger: docs/crc/PLAN.md Phase 9 "Decide the 89 rubocop offenses outside the CRC scope"; measured in fast-batch-2 preparation 2026-10-21 - Improvised this session: none - Chain: 48 judgement offenses ← eval/ has no ledger rows so no CRC pass read it ← DESIGN (docs/crc/os-sdlc/ledger.tsv scope) - Root candidate: none found; searched eval ticket-takedown rubocop offenses AbcSize FeatureEnvy - Where: plugins/os-sdlc/eval/ticket-takedown/ - Session: 017840c1-178f-4be2-bbb8-c548c9e70349 - Transcript: /home/jared/.claude/projects/-home-jared-dev-cc-os/017840c1-178f-4be2-bbb8-c548c9e70349.jsonl VERDICT: CREATE

jared added the

plugin/os-sdlc

filed-by/user

category/code-change

labels

2026-10-21 20:02:05 +00:00

jared commented

2026-10-21 21:48:00 +00:00

Author

Owner

Progress: fast-batch-5 (524f99c5) fixed 47 of 48 offenses. setup_step.rb:5 remains. Option B moved the offense to scratch_repo.rb:10. Next try: option B2, a SourceRevision value (repo_root plus base_commit) passed with dest into ScratchRepo.

Progress: fast-batch-5 (524f99c5) fixed 47 of 48 offenses. setup_step.rb:5 remains. Option B moved the offense to scratch_repo.rb:10. Next try: option B2, a SourceRevision value (repo_root plus base_commit) passed with dest into ScratchRepo.