jared/cc-os

Watch

Fork 0

CRC wave 5: split OsSdlc::Crc::Tickets::Candidate #1210

New issue

Closed

opened 2026-10-20 06:34:09 +00:00 by jared · 3 comments

jared commented

2026-10-20 06:34:09 +00:00

Owner

Problem

plugins/os-sdlc/lib/os_sdlc/crc/tickets/candidate.rb (OsSdlc::Crc::Tickets::Candidate) has the job sentence "This object owns one ledger row read as a ticket candidate: its cells, its skip decision, its change lines, and its row problems.", which holds two jobs. Extract it into separate files.

Reproduce

n/a: structure-only refactor, no behavior change.

Approach

Required work:
- split plugins/os-sdlc/lib/os_sdlc/crc/tickets/candidate.rb (OsSdlc::Crc::Tickets::Candidate)
- public methods: missing_columns initialize path constant wave wave_number concept job public_methods_list judged? split? skipped? rulings test_text change_lines problems
- test: no test file
- Part names: read the governing rulings below. Where they name no part, choose the names at extraction.
- Before you finish, grep the repository for the old file path, not only the constant.
Governing rulings:
- R3
- R50

Acceptance criteria

Every named ledger row is applied, or logged in deviations.md, or reported blocked.
cd plugins/os-sdlc && ruby tests/all.rb 0 failures.
ruby -e 'require "./plugins/os-sdlc/lib/os_sdlc"; OsSdlc::Db.connect!(":memory:"); OsSdlc.loader.eager_load' silent.
plugins/os-sdlc/bin/lint-sweep shows no unexplained new line.

Owner sketch

Each part owns one job; the old file is removed.

Non-goals

No behavior change.
No new tests.
No deletion of code that has callers.

Origin

Session: 2e167079-f404-4139-9cfa-6c0c937ce9f0
Transcript: /home/jared/.claude/projects/-home-jared-dev-cc-os--claude-worktrees-crc-os-sdlc-run-3/2e167079-f404-4139-9cfa-6c0c937ce9f0.jsonl
Where: plugins/os-sdlc/lib/os_sdlc/crc/tickets/candidate.rb
CRC refactor run: docs/crc/os-sdlc/.
Ledger: docs/crc/os-sdlc/ledger.tsv
Wave: 5.

## Problem `plugins/os-sdlc/lib/os_sdlc/crc/tickets/candidate.rb` (`OsSdlc::Crc::Tickets::Candidate`) has the job sentence "This object owns one ledger row read as a ticket candidate: its cells, its skip decision, its change lines, and its row problems.", which holds two jobs. Extract it into separate files. ## Reproduce n/a: structure-only refactor, no behavior change. ## Approach 1. Required work: - split `plugins/os-sdlc/lib/os_sdlc/crc/tickets/candidate.rb` (`OsSdlc::Crc::Tickets::Candidate`) - public methods: missing_columns initialize path constant wave wave_number concept job public_methods_list judged? split? skipped? rulings test_text change_lines problems - test: no test file - Part names: read the governing rulings below. Where they name no part, choose the names at extraction. - Before you finish, grep the repository for the old file path, not only the constant. 2. Governing rulings: - R3 - R50 ## Acceptance criteria - Every named ledger row is applied, or logged in deviations.md, or reported blocked. - `cd plugins/os-sdlc && ruby tests/all.rb` 0 failures. - `ruby -e 'require "./plugins/os-sdlc/lib/os_sdlc"; OsSdlc::Db.connect!(":memory:"); OsSdlc.loader.eager_load'` silent. - `plugins/os-sdlc/bin/lint-sweep` shows no unexplained new line. ## Owner sketch Each part owns one job; the old file is removed. ## Non-goals - No behavior change. - No new tests. - No deletion of code that has callers. ## Origin - Session: 2e167079-f404-4139-9cfa-6c0c937ce9f0 - Transcript: /home/jared/.claude/projects/-home-jared-dev-cc-os--claude-worktrees-crc-os-sdlc-run-3/2e167079-f404-4139-9cfa-6c0c937ce9f0.jsonl - Where: plugins/os-sdlc/lib/os_sdlc/crc/tickets/candidate.rb - CRC refactor run: docs/crc/os-sdlc/. - Ledger: docs/crc/os-sdlc/ledger.tsv - Wave: 5.

jared added the

labels

2026-10-20 06:34:09 +00:00

jared referenced this issue from a commit

2026-10-20 07:23:56 +00:00

refactor(os-sdlc): RowCheck extracted from Tickets::Candidate (#1210)

jared commented

2026-10-20 07:24:50 +00:00

Author

Owner

ad0f3e8c; rows applied 1/1; rows deviated 0; rows blocked 0

ad0f3e8c; rows applied 1/1; rows deviated 0; rows blocked 0

jared referenced this issue from a commit

2026-10-20 07:25:09 +00:00

refactor(os-sdlc): ReadinessCheck extracted from Tickets::Candidate (#1210)

jared referenced this issue from a commit

2026-10-20 07:28:59 +00:00

docs(crc): run 3 census row and row fill for #1210 ReadinessCheck (keep, R8); split row stamped (ad0f3e8c)

jared referenced this issue

2026-10-20 14:05:47 +00:00

Fix Sdlc/Dry/RepeatedPathLiteral crash on a string literal with invalid UTF-8 #1213

jared commented

2026-10-20 14:05:58 +00:00

Author

Owner

Follow-up dropped (skeptic, run 3 close-out): "Candidate and ReadinessCheck copy four cell helpers". The copy is real, but no cell-rule change is pending; the depth-1 rule applies.

jared commented

2026-10-20 14:09:16 +00:00

Author

Owner

Resolution

Done: Wave 5 split applied; created rows filled and merged.

Evidence: ad0f3e8c; records 56c44508; HEAD a2199744 suite 2273 runs 5106 assertions 0 failures 0 errors 45.3s; rubocop on run 3 files: no new offense

Follow-ups: drop 22 (Candidate and ReadinessCheck helpers) noted on this ticket

## Resolution **Done:** Wave 5 split applied; created rows filled and merged. **Evidence:** ad0f3e8c; records 56c44508; HEAD a2199744 suite 2273 runs 5106 assertions 0 failures 0 errors 45.3s; rubocop on run 3 files: no new offense **Follow-ups:** drop 22 (Candidate and ReadinessCheck helpers) noted on this ticket

jared closed this issue

2026-10-20 14:09:16 +00:00