CRC wave 4: apply Crc renames and moves #1209

New issue

Closed

opened 2026-10-20 06:34:08 +00:00 by jared · 2 comments

jared commented

2026-10-20 06:34:08 +00:00

Owner

Problem

Apply 1 ledger rows (rename and move) for Crc. Each row's path, constant, and test path change as listed in Approach.

Reproduce

n/a: structure-only refactor, no behavior change.

Approach

Required work, in order:
1. plugins/os-sdlc/lib/os_sdlc/crc/shares/verdict_rules.rb -> plugins/os-sdlc/lib/os_sdlc/crc/verdict_rules.rb
  - constant: OsSdlc::Crc::Shares::VerdictRules -> OsSdlc::Crc::VerdictRules
  - test: no test file
    Before you finish, grep the repository for each old file path and each old constant, not only the constant. Config and docs keep old paths (for example .rubocop.yml, loader collapse lists).
Governing rulings:
- R8
- R49

Acceptance criteria

Every named ledger row is applied, or logged in deviations.md, or reported blocked.
cd plugins/os-sdlc && ruby tests/all.rb 0 failures.
ruby -e 'require "./plugins/os-sdlc/lib/os_sdlc"; OsSdlc::Db.connect!(":memory:"); OsSdlc.loader.eager_load' silent.
plugins/os-sdlc/bin/lint-sweep shows no unexplained new line.

Owner sketch

Each constant matches its new path; callers follow the new name.

Non-goals

No behavior change.
No new tests.
No deletion of code that has callers.

Origin

Session: 2e167079-f404-4139-9cfa-6c0c937ce9f0
Transcript: /home/jared/.claude/projects/-home-jared-dev-cc-os--claude-worktrees-crc-os-sdlc-run-3/2e167079-f404-4139-9cfa-6c0c937ce9f0.jsonl
Where: plugins/os-sdlc/lib/os_sdlc/crc/shares/verdict_rules.rb
CRC refactor run: docs/crc/os-sdlc/.
Ledger: docs/crc/os-sdlc/ledger.tsv
Wave: 4.

## Problem Apply 1 ledger rows (rename and move) for Crc. Each row's path, constant, and test path change as listed in Approach. ## Reproduce n/a: structure-only refactor, no behavior change. ## Approach 1. Required work, in order: 1. `plugins/os-sdlc/lib/os_sdlc/crc/shares/verdict_rules.rb` -> `plugins/os-sdlc/lib/os_sdlc/crc/verdict_rules.rb` - constant: `OsSdlc::Crc::Shares::VerdictRules` -> `OsSdlc::Crc::VerdictRules` - test: no test file Before you finish, grep the repository for each old file path and each old constant, not only the constant. Config and docs keep old paths (for example .rubocop.yml, loader collapse lists). 2. Governing rulings: - R8 - R49 ## Acceptance criteria - Every named ledger row is applied, or logged in deviations.md, or reported blocked. - `cd plugins/os-sdlc && ruby tests/all.rb` 0 failures. - `ruby -e 'require "./plugins/os-sdlc/lib/os_sdlc"; OsSdlc::Db.connect!(":memory:"); OsSdlc.loader.eager_load'` silent. - `plugins/os-sdlc/bin/lint-sweep` shows no unexplained new line. ## Owner sketch Each constant matches its new path; callers follow the new name. ## Non-goals - No behavior change. - No new tests. - No deletion of code that has callers. ## Origin - Session: 2e167079-f404-4139-9cfa-6c0c937ce9f0 - Transcript: /home/jared/.claude/projects/-home-jared-dev-cc-os--claude-worktrees-crc-os-sdlc-run-3/2e167079-f404-4139-9cfa-6c0c937ce9f0.jsonl - Where: plugins/os-sdlc/lib/os_sdlc/crc/shares/verdict_rules.rb - CRC refactor run: docs/crc/os-sdlc/. - Ledger: docs/crc/os-sdlc/ledger.tsv - Wave: 4.

jared added the

labels

2026-10-20 06:34:08 +00:00

jared commented

2026-10-20 07:10:34 +00:00

Author

Owner

commit 6ff8460d; rows applied 1/1; rows deviated 0; rows blocked 0

commit 6ff8460d; rows applied 1/1; rows deviated 0; rows blocked 0

jared referenced this issue from a commit

2026-10-20 07:11:02 +00:00

refactor(os-sdlc): VerdictRules rises from Crc::Shares to Crc (#1209)

jared referenced this issue from a commit

2026-10-20 07:13:03 +00:00

docs(crc): run 3 ledger commits for #1209 (1 row)

jared commented

2026-10-20 14:09:14 +00:00

Author

Owner

Resolution

Done: Wave 4 batch applied, behavior unchanged.

Evidence: 6ff8460d; ledger 1f7c6c75; HEAD a2199744 suite 2273 runs 5106 assertions 0 failures 0 errors 45.3s; rubocop on run 3 files: no new offense

Follow-ups: none

## Resolution **Done:** Wave 4 batch applied, behavior unchanged. **Evidence:** 6ff8460d; ledger 1f7c6c75; HEAD a2199744 suite 2273 runs 5106 assertions 0 failures 0 errors 45.3s; rubocop on run 3 files: no new offense **Follow-ups:** none

jared closed this issue

2026-10-20 14:09:14 +00:00