CRC wave 4: apply Agent, ArrayLiteralOfLocalsReturn, ArtifactDir, Census, ConstantReference, Crc::Ledger, Daemon, Dispatch, Evidence renames and moves #1207
Labels
No labels
P0
P1
P2
P3
bug
category/code-change
category/cross-repo
category/eval-run
category/investigation
category/no-test-target
category/owner-ruling
category/prose-artifact
category/recurring-chore
category/structure
category/umbrella
crc-refactor
create
delete
enhancement
filed-by/agent
filed-by/user
frozen
lint-rule
needs-info
needs-triage
next
plugin/cc-architect
plugin/os
plugin/os-adr
plugin/os-aidd-lint
plugin/os-backlog
plugin/os-context
plugin/os-doc-hygiene
plugin/os-sdlc
plugin/os-vault
project/cc-os
ready-for-agent
ready-for-human
recurring
review
rule-proposal
update
waiting
wayfinder:grilling
wayfinder:map
wayfinder:map
wayfinder:research
wayfinder:task
wayfinder:task
wontfix
worklist/deviations
worklist/lint-rule
worklist/new-implement-build
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
jared/cc-os#1207
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Problem
Apply 25 ledger rows (rename and move) for Agent, ArrayLiteralOfLocalsReturn, ArtifactDir, Census, ConstantReference, Crc::Ledger, Daemon, Dispatch, Evidence. Each row's path, constant, and test path change as listed in Approach.
Reproduce
n/a: structure-only refactor, no behavior change.
Approach
plugins/os-sdlc/lib/os_sdlc/agent/type/unknown_error.rb->plugins/os-sdlc/lib/os_sdlc/agent/unknown_type_error.rbOsSdlc::Agent::Type::UnknownError->OsSdlc::Agent::UnknownTypeErrorplugins/os-sdlc/lib/os_sdlc/cops/array_literal_of_locals_return/locals_list.rb->plugins/os-sdlc/lib/os_sdlc/cops/array_literal_of_locals_return/message.rbRuboCop::Cop::Sdlc::Structural::ArrayLiteralOfLocalsReturn::LocalsList->RuboCop::Cop::Sdlc::Structural::ArrayLiteralOfLocalsReturn::Messageplugins/os-sdlc/lib/os_sdlc/project/artifact_dir.rb->plugins/os-sdlc/lib/os_sdlc/artifact_dir.rbOsSdlc::Project::ArtifactDir->OsSdlc::ArtifactDirplugins/os-sdlc/tests/project/artifact_dir_test.rb->plugins/os-sdlc/tests/artifact_dir_test.rbplugins/os-sdlc/lib/os_sdlc/crc/census/definition.rb->plugins/os-sdlc/lib/os_sdlc/crc/definitions/definition.rbOsSdlc::Crc::Census::Definition->OsSdlc::Crc::Definitions::Definitionplugins/os-sdlc/lib/os_sdlc/crc/census/definitions.rb->plugins/os-sdlc/lib/os_sdlc/crc/definitions.rbOsSdlc::Crc::Census::Definitions->OsSdlc::Crc::Definitionsplugins/os-sdlc/lib/os_sdlc/crc/census/expected_constants.rb->plugins/os-sdlc/lib/os_sdlc/crc/expected_constants.rbOsSdlc::Crc::Census::ExpectedConstants->OsSdlc::Crc::ExpectedConstantsplugins/os-sdlc/lib/os_sdlc/crc/census/namespace_definitions.rb->plugins/os-sdlc/lib/os_sdlc/crc/definitions/namespace_definitions.rbOsSdlc::Crc::Census::NamespaceDefinitions->OsSdlc::Crc::Definitions::NamespaceDefinitionsplugins/os-sdlc/lib/os_sdlc/crc/census/statements.rb->plugins/os-sdlc/lib/os_sdlc/crc/statements.rbOsSdlc::Crc::Census::Statements->OsSdlc::Crc::Statementsplugins/os-sdlc/lib/os_sdlc/crc/census/value_block.rb->plugins/os-sdlc/lib/os_sdlc/crc/statements/value_block.rbOsSdlc::Crc::Census::ValueBlock->OsSdlc::Crc::Statements::ValueBlockplugins/os-sdlc/lib/os_sdlc/cops/inward_dependency/reference.rb->plugins/os-sdlc/lib/os_sdlc/cops/constant_reference.rbRuboCop::Cop::Sdlc::Structural::InwardDependency::Reference->RuboCop::Cop::Sdlc::Structural::ConstantReferenceplugins/os-sdlc/lib/os_sdlc/crc/ledger/check/check.rb->plugins/os-sdlc/lib/os_sdlc/crc/ledger/check.rbOsSdlc::Crc::Ledger::Check::Check->OsSdlc::Crc::Ledger::Checkplugins/os-sdlc/lib/os_sdlc/crc/ledger/commits/stamp.rb->plugins/os-sdlc/lib/os_sdlc/crc/ledger/commits.rbOsSdlc::Crc::Ledger::Commits::Stamp->OsSdlc::Crc::Ledger::Commitsplugins/os-sdlc/lib/os_sdlc/lsp_timeout_error.rb->plugins/os-sdlc/lib/os_sdlc/daemon/lsp_timeout_error.rbOsSdlc::LspTimeoutError->OsSdlc::Daemon::LspTimeoutErrorplugins/os-sdlc/lib/os_sdlc/brief.rb->plugins/os-sdlc/lib/os_sdlc/dispatch/brief.rbOsSdlc::Brief->OsSdlc::Dispatch::Briefplugins/os-sdlc/tests/brief_drafted_map_test.rb->plugins/os-sdlc/tests/dispatch/brief_drafted_map_test.rb,plugins/os-sdlc/tests/brief_map_name_test.rb->plugins/os-sdlc/tests/dispatch/brief_map_name_test.rb,plugins/os-sdlc/tests/brief_objections_test.rb->plugins/os-sdlc/tests/dispatch/brief_objections_test.rb,plugins/os-sdlc/tests/brief_test.rb->plugins/os-sdlc/tests/dispatch/brief_test.rbplugins/os-sdlc/lib/os_sdlc/brief/facts.rb->plugins/os-sdlc/lib/os_sdlc/dispatch/brief/facts.rbOsSdlc::Brief::Facts->OsSdlc::Dispatch::Brief::Factsplugins/os-sdlc/tests/brief/facts_approved_maps_drafts_test.rb->plugins/os-sdlc/tests/dispatch/brief/facts_approved_maps_drafts_test.rb,plugins/os-sdlc/tests/brief/facts_approved_maps_test.rb->plugins/os-sdlc/tests/dispatch/brief/facts_approved_maps_test.rb,plugins/os-sdlc/tests/brief/facts_bound_target_test.rb->plugins/os-sdlc/tests/dispatch/brief/facts_bound_target_test.rb,plugins/os-sdlc/tests/brief/facts_fact_names_test.rb->plugins/os-sdlc/tests/dispatch/brief/facts_fact_names_test.rb,plugins/os-sdlc/tests/brief/facts_gate_results_truncation_marker_test.rb->plugins/os-sdlc/tests/dispatch/brief/facts_gate_results_truncation_marker_test.rb,plugins/os-sdlc/tests/brief/facts_gate_verdicts_test.rb->plugins/os-sdlc/tests/dispatch/brief/facts_gate_verdicts_test.rb,plugins/os-sdlc/tests/brief/facts_handoff_from_agent_type_test.rb->plugins/os-sdlc/tests/dispatch/brief/facts_handoff_from_agent_type_test.rb,plugins/os-sdlc/tests/brief/facts_investigator_handoffs_test.rb->plugins/os-sdlc/tests/dispatch/brief/facts_investigator_handoffs_test.rb,plugins/os-sdlc/tests/brief/facts_legacy_labels_test.rb->plugins/os-sdlc/tests/dispatch/brief/facts_legacy_labels_test.rb,plugins/os-sdlc/tests/brief/facts_lint_offense_history_test.rb->plugins/os-sdlc/tests/dispatch/brief/facts_lint_offense_history_test.rb,plugins/os-sdlc/tests/brief/facts_project_dispatch_test.rb->plugins/os-sdlc/tests/dispatch/brief/facts_project_dispatch_test.rb,plugins/os-sdlc/tests/brief/facts_red_tests_test.rb->plugins/os-sdlc/tests/dispatch/brief/facts_red_tests_test.rb,plugins/os-sdlc/tests/brief/facts_retired_tests_test.rb->plugins/os-sdlc/tests/dispatch/brief/facts_retired_tests_test.rb,plugins/os-sdlc/tests/brief/facts_round_tests_test.rb->plugins/os-sdlc/tests/dispatch/brief/facts_round_tests_test.rb,plugins/os-sdlc/tests/brief/facts_ticket_body_test.rb->plugins/os-sdlc/tests/dispatch/brief/facts_ticket_body_test.rbplugins/os-sdlc/lib/os_sdlc/brief/facts/unknown_fact_error.rb->plugins/os-sdlc/lib/os_sdlc/dispatch/brief/unknown_fact_error.rbOsSdlc::Brief::Facts::UnknownFactError->OsSdlc::Dispatch::Brief::UnknownFactErrorplugins/os-sdlc/lib/os_sdlc/brief/gate_output_warning.rb->plugins/os-sdlc/lib/os_sdlc/dispatch/brief/gate_output_warning.rbOsSdlc::Brief::GateOutputWarning->OsSdlc::Dispatch::Brief::GateOutputWarningplugins/os-sdlc/lib/os_sdlc/brief/lint_offense.rb->plugins/os-sdlc/lib/os_sdlc/dispatch/brief/lint_offense.rbOsSdlc::Brief::LintOffense->OsSdlc::Dispatch::Brief::LintOffenseplugins/os-sdlc/lib/os_sdlc/brief/lint_offense_entry.rb->plugins/os-sdlc/lib/os_sdlc/dispatch/brief/lint_offense_entry.rbOsSdlc::Brief::LintOffenseEntry->OsSdlc::Dispatch::Brief::LintOffenseEntryplugins/os-sdlc/lib/os_sdlc/brief/lint_offenses.rb->plugins/os-sdlc/lib/os_sdlc/dispatch/brief/lint_offenses.rbOsSdlc::Brief::LintOffenses->OsSdlc::Dispatch::Brief::LintOffensesplugins/os-sdlc/lib/os_sdlc/brief/missing_file_error.rb->plugins/os-sdlc/lib/os_sdlc/dispatch/brief/missing_file_error.rbOsSdlc::Brief::MissingFileError->OsSdlc::Dispatch::Brief::MissingFileErrorplugins/os-sdlc/lib/os_sdlc/brief/objections_digest.rb->plugins/os-sdlc/lib/os_sdlc/dispatch/brief/objections_digest.rbOsSdlc::Brief::ObjectionsDigest->OsSdlc::Dispatch::Brief::ObjectionsDigestplugins/os-sdlc/tests/support/report_scenario.rb->plugins/os-sdlc/tests/support/evidence_report_scenario.rbReportScenario->EvidenceReportScenarioplugins/os-sdlc/tests/support/resolver_assertions.rb->plugins/os-sdlc/tests/support/resolution_assertions.rbResolverAssertions->ResolutionAssertionsplugins/os-sdlc/tests/support/resolver_scenario.rb->plugins/os-sdlc/tests/support/resolution_scenario.rbResolverScenario->ResolutionScenarioBefore you finish, grep the repository for each old file path and each old constant, not only the constant. Config and docs keep old paths (for example .rubocop.yml, loader collapse lists).
Acceptance criteria
cd plugins/os-sdlc && ruby tests/all.rb0 failures.ruby -e 'require "./plugins/os-sdlc/lib/os_sdlc"; OsSdlc::Db.connect!(":memory:"); OsSdlc.loader.eager_load'silent.plugins/os-sdlc/bin/lint-sweepshows no unexplained new line.Owner sketch
Each constant matches its new path; callers follow the new name.
Non-goals
Origin
Commits
06f209da,df0bebfb,b07fe9df,941edc7c,d1a22816,d98443c6; rows applied 25/25; rows deviated 0 (2 inward-lint notes in deviations.md); rows blocked 0Follow-up dropped (skeptic, run 3 close-out): "Reparent errors to OsSdlc::Error". No code rescues OsSdlc::Error, and the depth-1 rule applies.
Resolution
Done: Wave 4 batch applied: 25 ledger rows renamed or moved, behavior unchanged.
Evidence:
06f209dadf0bebfbb07fe9df941edc7cd1a22816d98443c6; ledger47b14f03; HEADa2199744suite 2273 runs 5106 assertions 0 failures 0 errors 45.3s; rubocop on run 3 files: no new offense (tests/dispatch_test.rb:211 InlineDatasetQuery predates run 3; PrimitiveObsessedIvar crashes on retired_test.rb, tooling item)Follow-ups: #1212 (inward edges, created); drop 01 (reparent errors) noted on this ticket