CRC wave 4: apply Agent, ArrayLiteralOfLocalsReturn, ArtifactDir, Census, ConstantReference, Crc::Ledger, Daemon, Dispatch, Evidence renames and moves #1207

Closed
opened 2026-10-20 06:34:06 +00:00 by jared · 3 comments
Owner

Problem

Apply 25 ledger rows (rename and move) for Agent, ArrayLiteralOfLocalsReturn, ArtifactDir, Census, ConstantReference, Crc::Ledger, Daemon, Dispatch, Evidence. Each row's path, constant, and test path change as listed in Approach.

Reproduce

n/a: structure-only refactor, no behavior change.

Approach

  1. Required work, in order:
    1. plugins/os-sdlc/lib/os_sdlc/agent/type/unknown_error.rb -> plugins/os-sdlc/lib/os_sdlc/agent/unknown_type_error.rb
      • constant: OsSdlc::Agent::Type::UnknownError -> OsSdlc::Agent::UnknownTypeError
      • test: no test file
    2. plugins/os-sdlc/lib/os_sdlc/cops/array_literal_of_locals_return/locals_list.rb -> plugins/os-sdlc/lib/os_sdlc/cops/array_literal_of_locals_return/message.rb
      • constant: RuboCop::Cop::Sdlc::Structural::ArrayLiteralOfLocalsReturn::LocalsList -> RuboCop::Cop::Sdlc::Structural::ArrayLiteralOfLocalsReturn::Message
      • test: no test file
    3. plugins/os-sdlc/lib/os_sdlc/project/artifact_dir.rb -> plugins/os-sdlc/lib/os_sdlc/artifact_dir.rb
      • constant: OsSdlc::Project::ArtifactDir -> OsSdlc::ArtifactDir
      • test: plugins/os-sdlc/tests/project/artifact_dir_test.rb -> plugins/os-sdlc/tests/artifact_dir_test.rb
    4. plugins/os-sdlc/lib/os_sdlc/crc/census/definition.rb -> plugins/os-sdlc/lib/os_sdlc/crc/definitions/definition.rb
      • constant: OsSdlc::Crc::Census::Definition -> OsSdlc::Crc::Definitions::Definition
      • test: no test file
    5. plugins/os-sdlc/lib/os_sdlc/crc/census/definitions.rb -> plugins/os-sdlc/lib/os_sdlc/crc/definitions.rb
      • constant: OsSdlc::Crc::Census::Definitions -> OsSdlc::Crc::Definitions
      • test: no test file
    6. plugins/os-sdlc/lib/os_sdlc/crc/census/expected_constants.rb -> plugins/os-sdlc/lib/os_sdlc/crc/expected_constants.rb
      • constant: OsSdlc::Crc::Census::ExpectedConstants -> OsSdlc::Crc::ExpectedConstants
      • test: no test file
    7. plugins/os-sdlc/lib/os_sdlc/crc/census/namespace_definitions.rb -> plugins/os-sdlc/lib/os_sdlc/crc/definitions/namespace_definitions.rb
      • constant: OsSdlc::Crc::Census::NamespaceDefinitions -> OsSdlc::Crc::Definitions::NamespaceDefinitions
      • test: no test file
    8. plugins/os-sdlc/lib/os_sdlc/crc/census/statements.rb -> plugins/os-sdlc/lib/os_sdlc/crc/statements.rb
      • constant: OsSdlc::Crc::Census::Statements -> OsSdlc::Crc::Statements
      • test: no test file
    9. plugins/os-sdlc/lib/os_sdlc/crc/census/value_block.rb -> plugins/os-sdlc/lib/os_sdlc/crc/statements/value_block.rb
      • constant: OsSdlc::Crc::Census::ValueBlock -> OsSdlc::Crc::Statements::ValueBlock
      • test: no test file
    10. plugins/os-sdlc/lib/os_sdlc/cops/inward_dependency/reference.rb -> plugins/os-sdlc/lib/os_sdlc/cops/constant_reference.rb
    • constant: RuboCop::Cop::Sdlc::Structural::InwardDependency::Reference -> RuboCop::Cop::Sdlc::Structural::ConstantReference
    • test: no test file
    1. plugins/os-sdlc/lib/os_sdlc/crc/ledger/check/check.rb -> plugins/os-sdlc/lib/os_sdlc/crc/ledger/check.rb
    • constant: OsSdlc::Crc::Ledger::Check::Check -> OsSdlc::Crc::Ledger::Check
    • test: no test file
    1. plugins/os-sdlc/lib/os_sdlc/crc/ledger/commits/stamp.rb -> plugins/os-sdlc/lib/os_sdlc/crc/ledger/commits.rb
    • constant: OsSdlc::Crc::Ledger::Commits::Stamp -> OsSdlc::Crc::Ledger::Commits
    • test: no test file
    1. plugins/os-sdlc/lib/os_sdlc/lsp_timeout_error.rb -> plugins/os-sdlc/lib/os_sdlc/daemon/lsp_timeout_error.rb
    • constant: OsSdlc::LspTimeoutError -> OsSdlc::Daemon::LspTimeoutError
    • test: no test file
    1. plugins/os-sdlc/lib/os_sdlc/brief.rb -> plugins/os-sdlc/lib/os_sdlc/dispatch/brief.rb
    • constant: OsSdlc::Brief -> OsSdlc::Dispatch::Brief
    • test: plugins/os-sdlc/tests/brief_drafted_map_test.rb -> plugins/os-sdlc/tests/dispatch/brief_drafted_map_test.rb, plugins/os-sdlc/tests/brief_map_name_test.rb -> plugins/os-sdlc/tests/dispatch/brief_map_name_test.rb, plugins/os-sdlc/tests/brief_objections_test.rb -> plugins/os-sdlc/tests/dispatch/brief_objections_test.rb, plugins/os-sdlc/tests/brief_test.rb -> plugins/os-sdlc/tests/dispatch/brief_test.rb
    1. plugins/os-sdlc/lib/os_sdlc/brief/facts.rb -> plugins/os-sdlc/lib/os_sdlc/dispatch/brief/facts.rb
    • constant: OsSdlc::Brief::Facts -> OsSdlc::Dispatch::Brief::Facts
    • test: plugins/os-sdlc/tests/brief/facts_approved_maps_drafts_test.rb -> plugins/os-sdlc/tests/dispatch/brief/facts_approved_maps_drafts_test.rb, plugins/os-sdlc/tests/brief/facts_approved_maps_test.rb -> plugins/os-sdlc/tests/dispatch/brief/facts_approved_maps_test.rb, plugins/os-sdlc/tests/brief/facts_bound_target_test.rb -> plugins/os-sdlc/tests/dispatch/brief/facts_bound_target_test.rb, plugins/os-sdlc/tests/brief/facts_fact_names_test.rb -> plugins/os-sdlc/tests/dispatch/brief/facts_fact_names_test.rb, plugins/os-sdlc/tests/brief/facts_gate_results_truncation_marker_test.rb -> plugins/os-sdlc/tests/dispatch/brief/facts_gate_results_truncation_marker_test.rb, plugins/os-sdlc/tests/brief/facts_gate_verdicts_test.rb -> plugins/os-sdlc/tests/dispatch/brief/facts_gate_verdicts_test.rb, plugins/os-sdlc/tests/brief/facts_handoff_from_agent_type_test.rb -> plugins/os-sdlc/tests/dispatch/brief/facts_handoff_from_agent_type_test.rb, plugins/os-sdlc/tests/brief/facts_investigator_handoffs_test.rb -> plugins/os-sdlc/tests/dispatch/brief/facts_investigator_handoffs_test.rb, plugins/os-sdlc/tests/brief/facts_legacy_labels_test.rb -> plugins/os-sdlc/tests/dispatch/brief/facts_legacy_labels_test.rb, plugins/os-sdlc/tests/brief/facts_lint_offense_history_test.rb -> plugins/os-sdlc/tests/dispatch/brief/facts_lint_offense_history_test.rb, plugins/os-sdlc/tests/brief/facts_project_dispatch_test.rb -> plugins/os-sdlc/tests/dispatch/brief/facts_project_dispatch_test.rb, plugins/os-sdlc/tests/brief/facts_red_tests_test.rb -> plugins/os-sdlc/tests/dispatch/brief/facts_red_tests_test.rb, plugins/os-sdlc/tests/brief/facts_retired_tests_test.rb -> plugins/os-sdlc/tests/dispatch/brief/facts_retired_tests_test.rb, plugins/os-sdlc/tests/brief/facts_round_tests_test.rb -> plugins/os-sdlc/tests/dispatch/brief/facts_round_tests_test.rb, plugins/os-sdlc/tests/brief/facts_ticket_body_test.rb -> plugins/os-sdlc/tests/dispatch/brief/facts_ticket_body_test.rb
    1. plugins/os-sdlc/lib/os_sdlc/brief/facts/unknown_fact_error.rb -> plugins/os-sdlc/lib/os_sdlc/dispatch/brief/unknown_fact_error.rb
    • constant: OsSdlc::Brief::Facts::UnknownFactError -> OsSdlc::Dispatch::Brief::UnknownFactError
    • test: no test file
    1. plugins/os-sdlc/lib/os_sdlc/brief/gate_output_warning.rb -> plugins/os-sdlc/lib/os_sdlc/dispatch/brief/gate_output_warning.rb
    • constant: OsSdlc::Brief::GateOutputWarning -> OsSdlc::Dispatch::Brief::GateOutputWarning
    • test: no test file
    1. plugins/os-sdlc/lib/os_sdlc/brief/lint_offense.rb -> plugins/os-sdlc/lib/os_sdlc/dispatch/brief/lint_offense.rb
    • constant: OsSdlc::Brief::LintOffense -> OsSdlc::Dispatch::Brief::LintOffense
    • test: no test file
    1. plugins/os-sdlc/lib/os_sdlc/brief/lint_offense_entry.rb -> plugins/os-sdlc/lib/os_sdlc/dispatch/brief/lint_offense_entry.rb
    • constant: OsSdlc::Brief::LintOffenseEntry -> OsSdlc::Dispatch::Brief::LintOffenseEntry
    • test: no test file
    1. plugins/os-sdlc/lib/os_sdlc/brief/lint_offenses.rb -> plugins/os-sdlc/lib/os_sdlc/dispatch/brief/lint_offenses.rb
    • constant: OsSdlc::Brief::LintOffenses -> OsSdlc::Dispatch::Brief::LintOffenses
    • test: no test file
    1. plugins/os-sdlc/lib/os_sdlc/brief/missing_file_error.rb -> plugins/os-sdlc/lib/os_sdlc/dispatch/brief/missing_file_error.rb
    • constant: OsSdlc::Brief::MissingFileError -> OsSdlc::Dispatch::Brief::MissingFileError
    • test: no test file
    1. plugins/os-sdlc/lib/os_sdlc/brief/objections_digest.rb -> plugins/os-sdlc/lib/os_sdlc/dispatch/brief/objections_digest.rb
    • constant: OsSdlc::Brief::ObjectionsDigest -> OsSdlc::Dispatch::Brief::ObjectionsDigest
    • test: no test file
    1. plugins/os-sdlc/tests/support/report_scenario.rb -> plugins/os-sdlc/tests/support/evidence_report_scenario.rb
    • constant: ReportScenario -> EvidenceReportScenario
    • test: no test file
    1. plugins/os-sdlc/tests/support/resolver_assertions.rb -> plugins/os-sdlc/tests/support/resolution_assertions.rb
    • constant: ResolverAssertions -> ResolutionAssertions
    • test: no test file
    1. plugins/os-sdlc/tests/support/resolver_scenario.rb -> plugins/os-sdlc/tests/support/resolution_scenario.rb
    • constant: ResolverScenario -> ResolutionScenario
    • test: no test file
      Before you finish, grep the repository for each old file path and each old constant, not only the constant. Config and docs keep old paths (for example .rubocop.yml, loader collapse lists).
  2. Governing rulings:
    • R1
    • R2
    • R4
    • R6
    • R8
    • R10
    • R14
    • R18
    • R20
    • R26
    • R28
    • R40
    • R44
    • R47
    • R48
    • R51
    • R52

Acceptance criteria

  • Every named ledger row is applied, or logged in deviations.md, or reported blocked.
  • cd plugins/os-sdlc && ruby tests/all.rb 0 failures.
  • ruby -e 'require "./plugins/os-sdlc/lib/os_sdlc"; OsSdlc::Db.connect!(":memory:"); OsSdlc.loader.eager_load' silent.
  • plugins/os-sdlc/bin/lint-sweep shows no unexplained new line.

Owner sketch

Each constant matches its new path; callers follow the new name.

Non-goals

  • No behavior change.
  • No new tests.
  • No deletion of code that has callers.

Origin

  • Session: 2e167079-f404-4139-9cfa-6c0c937ce9f0
  • Transcript: /home/jared/.claude/projects/-home-jared-dev-cc-os--claude-worktrees-crc-os-sdlc-run-3/2e167079-f404-4139-9cfa-6c0c937ce9f0.jsonl
  • Where: plugins/os-sdlc/lib/os_sdlc/agent/type/unknown_error.rb, plugins/os-sdlc/lib/os_sdlc/cops/array_literal_of_locals_return/locals_list.rb, plugins/os-sdlc/lib/os_sdlc/project/artifact_dir.rb, plugins/os-sdlc/lib/os_sdlc/crc/census/definition.rb, plugins/os-sdlc/lib/os_sdlc/crc/census/definitions.rb, plugins/os-sdlc/lib/os_sdlc/crc/census/expected_constants.rb, plugins/os-sdlc/lib/os_sdlc/crc/census/namespace_definitions.rb, plugins/os-sdlc/lib/os_sdlc/crc/census/statements.rb, plugins/os-sdlc/lib/os_sdlc/crc/census/value_block.rb, plugins/os-sdlc/lib/os_sdlc/cops/inward_dependency/reference.rb, plugins/os-sdlc/lib/os_sdlc/crc/ledger/check/check.rb, plugins/os-sdlc/lib/os_sdlc/crc/ledger/commits/stamp.rb, plugins/os-sdlc/lib/os_sdlc/lsp_timeout_error.rb, plugins/os-sdlc/lib/os_sdlc/brief.rb, plugins/os-sdlc/lib/os_sdlc/brief/facts.rb, plugins/os-sdlc/lib/os_sdlc/brief/facts/unknown_fact_error.rb, plugins/os-sdlc/lib/os_sdlc/brief/gate_output_warning.rb, plugins/os-sdlc/lib/os_sdlc/brief/lint_offense.rb, plugins/os-sdlc/lib/os_sdlc/brief/lint_offense_entry.rb, plugins/os-sdlc/lib/os_sdlc/brief/lint_offenses.rb, plugins/os-sdlc/lib/os_sdlc/brief/missing_file_error.rb, plugins/os-sdlc/lib/os_sdlc/brief/objections_digest.rb, plugins/os-sdlc/tests/support/report_scenario.rb, plugins/os-sdlc/tests/support/resolver_assertions.rb, plugins/os-sdlc/tests/support/resolver_scenario.rb
  • CRC refactor run: docs/crc/os-sdlc/.
  • Ledger: docs/crc/os-sdlc/ledger.tsv
  • Wave: 4.
## Problem Apply 25 ledger rows (rename and move) for Agent, ArrayLiteralOfLocalsReturn, ArtifactDir, Census, ConstantReference, Crc::Ledger, Daemon, Dispatch, Evidence. Each row's path, constant, and test path change as listed in Approach. ## Reproduce n/a: structure-only refactor, no behavior change. ## Approach 1. Required work, in order: 1. `plugins/os-sdlc/lib/os_sdlc/agent/type/unknown_error.rb` -> `plugins/os-sdlc/lib/os_sdlc/agent/unknown_type_error.rb` - constant: `OsSdlc::Agent::Type::UnknownError` -> `OsSdlc::Agent::UnknownTypeError` - test: no test file 2. `plugins/os-sdlc/lib/os_sdlc/cops/array_literal_of_locals_return/locals_list.rb` -> `plugins/os-sdlc/lib/os_sdlc/cops/array_literal_of_locals_return/message.rb` - constant: `RuboCop::Cop::Sdlc::Structural::ArrayLiteralOfLocalsReturn::LocalsList` -> `RuboCop::Cop::Sdlc::Structural::ArrayLiteralOfLocalsReturn::Message` - test: no test file 3. `plugins/os-sdlc/lib/os_sdlc/project/artifact_dir.rb` -> `plugins/os-sdlc/lib/os_sdlc/artifact_dir.rb` - constant: `OsSdlc::Project::ArtifactDir` -> `OsSdlc::ArtifactDir` - test: `plugins/os-sdlc/tests/project/artifact_dir_test.rb` -> `plugins/os-sdlc/tests/artifact_dir_test.rb` 4. `plugins/os-sdlc/lib/os_sdlc/crc/census/definition.rb` -> `plugins/os-sdlc/lib/os_sdlc/crc/definitions/definition.rb` - constant: `OsSdlc::Crc::Census::Definition` -> `OsSdlc::Crc::Definitions::Definition` - test: no test file 5. `plugins/os-sdlc/lib/os_sdlc/crc/census/definitions.rb` -> `plugins/os-sdlc/lib/os_sdlc/crc/definitions.rb` - constant: `OsSdlc::Crc::Census::Definitions` -> `OsSdlc::Crc::Definitions` - test: no test file 6. `plugins/os-sdlc/lib/os_sdlc/crc/census/expected_constants.rb` -> `plugins/os-sdlc/lib/os_sdlc/crc/expected_constants.rb` - constant: `OsSdlc::Crc::Census::ExpectedConstants` -> `OsSdlc::Crc::ExpectedConstants` - test: no test file 7. `plugins/os-sdlc/lib/os_sdlc/crc/census/namespace_definitions.rb` -> `plugins/os-sdlc/lib/os_sdlc/crc/definitions/namespace_definitions.rb` - constant: `OsSdlc::Crc::Census::NamespaceDefinitions` -> `OsSdlc::Crc::Definitions::NamespaceDefinitions` - test: no test file 8. `plugins/os-sdlc/lib/os_sdlc/crc/census/statements.rb` -> `plugins/os-sdlc/lib/os_sdlc/crc/statements.rb` - constant: `OsSdlc::Crc::Census::Statements` -> `OsSdlc::Crc::Statements` - test: no test file 9. `plugins/os-sdlc/lib/os_sdlc/crc/census/value_block.rb` -> `plugins/os-sdlc/lib/os_sdlc/crc/statements/value_block.rb` - constant: `OsSdlc::Crc::Census::ValueBlock` -> `OsSdlc::Crc::Statements::ValueBlock` - test: no test file 10. `plugins/os-sdlc/lib/os_sdlc/cops/inward_dependency/reference.rb` -> `plugins/os-sdlc/lib/os_sdlc/cops/constant_reference.rb` - constant: `RuboCop::Cop::Sdlc::Structural::InwardDependency::Reference` -> `RuboCop::Cop::Sdlc::Structural::ConstantReference` - test: no test file 11. `plugins/os-sdlc/lib/os_sdlc/crc/ledger/check/check.rb` -> `plugins/os-sdlc/lib/os_sdlc/crc/ledger/check.rb` - constant: `OsSdlc::Crc::Ledger::Check::Check` -> `OsSdlc::Crc::Ledger::Check` - test: no test file 12. `plugins/os-sdlc/lib/os_sdlc/crc/ledger/commits/stamp.rb` -> `plugins/os-sdlc/lib/os_sdlc/crc/ledger/commits.rb` - constant: `OsSdlc::Crc::Ledger::Commits::Stamp` -> `OsSdlc::Crc::Ledger::Commits` - test: no test file 13. `plugins/os-sdlc/lib/os_sdlc/lsp_timeout_error.rb` -> `plugins/os-sdlc/lib/os_sdlc/daemon/lsp_timeout_error.rb` - constant: `OsSdlc::LspTimeoutError` -> `OsSdlc::Daemon::LspTimeoutError` - test: no test file 14. `plugins/os-sdlc/lib/os_sdlc/brief.rb` -> `plugins/os-sdlc/lib/os_sdlc/dispatch/brief.rb` - constant: `OsSdlc::Brief` -> `OsSdlc::Dispatch::Brief` - test: `plugins/os-sdlc/tests/brief_drafted_map_test.rb` -> `plugins/os-sdlc/tests/dispatch/brief_drafted_map_test.rb`, `plugins/os-sdlc/tests/brief_map_name_test.rb` -> `plugins/os-sdlc/tests/dispatch/brief_map_name_test.rb`, `plugins/os-sdlc/tests/brief_objections_test.rb` -> `plugins/os-sdlc/tests/dispatch/brief_objections_test.rb`, `plugins/os-sdlc/tests/brief_test.rb` -> `plugins/os-sdlc/tests/dispatch/brief_test.rb` 15. `plugins/os-sdlc/lib/os_sdlc/brief/facts.rb` -> `plugins/os-sdlc/lib/os_sdlc/dispatch/brief/facts.rb` - constant: `OsSdlc::Brief::Facts` -> `OsSdlc::Dispatch::Brief::Facts` - test: `plugins/os-sdlc/tests/brief/facts_approved_maps_drafts_test.rb` -> `plugins/os-sdlc/tests/dispatch/brief/facts_approved_maps_drafts_test.rb`, `plugins/os-sdlc/tests/brief/facts_approved_maps_test.rb` -> `plugins/os-sdlc/tests/dispatch/brief/facts_approved_maps_test.rb`, `plugins/os-sdlc/tests/brief/facts_bound_target_test.rb` -> `plugins/os-sdlc/tests/dispatch/brief/facts_bound_target_test.rb`, `plugins/os-sdlc/tests/brief/facts_fact_names_test.rb` -> `plugins/os-sdlc/tests/dispatch/brief/facts_fact_names_test.rb`, `plugins/os-sdlc/tests/brief/facts_gate_results_truncation_marker_test.rb` -> `plugins/os-sdlc/tests/dispatch/brief/facts_gate_results_truncation_marker_test.rb`, `plugins/os-sdlc/tests/brief/facts_gate_verdicts_test.rb` -> `plugins/os-sdlc/tests/dispatch/brief/facts_gate_verdicts_test.rb`, `plugins/os-sdlc/tests/brief/facts_handoff_from_agent_type_test.rb` -> `plugins/os-sdlc/tests/dispatch/brief/facts_handoff_from_agent_type_test.rb`, `plugins/os-sdlc/tests/brief/facts_investigator_handoffs_test.rb` -> `plugins/os-sdlc/tests/dispatch/brief/facts_investigator_handoffs_test.rb`, `plugins/os-sdlc/tests/brief/facts_legacy_labels_test.rb` -> `plugins/os-sdlc/tests/dispatch/brief/facts_legacy_labels_test.rb`, `plugins/os-sdlc/tests/brief/facts_lint_offense_history_test.rb` -> `plugins/os-sdlc/tests/dispatch/brief/facts_lint_offense_history_test.rb`, `plugins/os-sdlc/tests/brief/facts_project_dispatch_test.rb` -> `plugins/os-sdlc/tests/dispatch/brief/facts_project_dispatch_test.rb`, `plugins/os-sdlc/tests/brief/facts_red_tests_test.rb` -> `plugins/os-sdlc/tests/dispatch/brief/facts_red_tests_test.rb`, `plugins/os-sdlc/tests/brief/facts_retired_tests_test.rb` -> `plugins/os-sdlc/tests/dispatch/brief/facts_retired_tests_test.rb`, `plugins/os-sdlc/tests/brief/facts_round_tests_test.rb` -> `plugins/os-sdlc/tests/dispatch/brief/facts_round_tests_test.rb`, `plugins/os-sdlc/tests/brief/facts_ticket_body_test.rb` -> `plugins/os-sdlc/tests/dispatch/brief/facts_ticket_body_test.rb` 16. `plugins/os-sdlc/lib/os_sdlc/brief/facts/unknown_fact_error.rb` -> `plugins/os-sdlc/lib/os_sdlc/dispatch/brief/unknown_fact_error.rb` - constant: `OsSdlc::Brief::Facts::UnknownFactError` -> `OsSdlc::Dispatch::Brief::UnknownFactError` - test: no test file 17. `plugins/os-sdlc/lib/os_sdlc/brief/gate_output_warning.rb` -> `plugins/os-sdlc/lib/os_sdlc/dispatch/brief/gate_output_warning.rb` - constant: `OsSdlc::Brief::GateOutputWarning` -> `OsSdlc::Dispatch::Brief::GateOutputWarning` - test: no test file 18. `plugins/os-sdlc/lib/os_sdlc/brief/lint_offense.rb` -> `plugins/os-sdlc/lib/os_sdlc/dispatch/brief/lint_offense.rb` - constant: `OsSdlc::Brief::LintOffense` -> `OsSdlc::Dispatch::Brief::LintOffense` - test: no test file 19. `plugins/os-sdlc/lib/os_sdlc/brief/lint_offense_entry.rb` -> `plugins/os-sdlc/lib/os_sdlc/dispatch/brief/lint_offense_entry.rb` - constant: `OsSdlc::Brief::LintOffenseEntry` -> `OsSdlc::Dispatch::Brief::LintOffenseEntry` - test: no test file 20. `plugins/os-sdlc/lib/os_sdlc/brief/lint_offenses.rb` -> `plugins/os-sdlc/lib/os_sdlc/dispatch/brief/lint_offenses.rb` - constant: `OsSdlc::Brief::LintOffenses` -> `OsSdlc::Dispatch::Brief::LintOffenses` - test: no test file 21. `plugins/os-sdlc/lib/os_sdlc/brief/missing_file_error.rb` -> `plugins/os-sdlc/lib/os_sdlc/dispatch/brief/missing_file_error.rb` - constant: `OsSdlc::Brief::MissingFileError` -> `OsSdlc::Dispatch::Brief::MissingFileError` - test: no test file 22. `plugins/os-sdlc/lib/os_sdlc/brief/objections_digest.rb` -> `plugins/os-sdlc/lib/os_sdlc/dispatch/brief/objections_digest.rb` - constant: `OsSdlc::Brief::ObjectionsDigest` -> `OsSdlc::Dispatch::Brief::ObjectionsDigest` - test: no test file 23. `plugins/os-sdlc/tests/support/report_scenario.rb` -> `plugins/os-sdlc/tests/support/evidence_report_scenario.rb` - constant: `ReportScenario` -> `EvidenceReportScenario` - test: no test file 24. `plugins/os-sdlc/tests/support/resolver_assertions.rb` -> `plugins/os-sdlc/tests/support/resolution_assertions.rb` - constant: `ResolverAssertions` -> `ResolutionAssertions` - test: no test file 25. `plugins/os-sdlc/tests/support/resolver_scenario.rb` -> `plugins/os-sdlc/tests/support/resolution_scenario.rb` - constant: `ResolverScenario` -> `ResolutionScenario` - test: no test file Before you finish, grep the repository for each old file path and each old constant, not only the constant. Config and docs keep old paths (for example .rubocop.yml, loader collapse lists). 2. Governing rulings: - R1 - R2 - R4 - R6 - R8 - R10 - R14 - R18 - R20 - R26 - R28 - R40 - R44 - R47 - R48 - R51 - R52 ## Acceptance criteria - Every named ledger row is applied, or logged in deviations.md, or reported blocked. - `cd plugins/os-sdlc && ruby tests/all.rb` 0 failures. - `ruby -e 'require "./plugins/os-sdlc/lib/os_sdlc"; OsSdlc::Db.connect!(":memory:"); OsSdlc.loader.eager_load'` silent. - `plugins/os-sdlc/bin/lint-sweep` shows no unexplained new line. ## Owner sketch Each constant matches its new path; callers follow the new name. ## Non-goals - No behavior change. - No new tests. - No deletion of code that has callers. ## Origin - Session: 2e167079-f404-4139-9cfa-6c0c937ce9f0 - Transcript: /home/jared/.claude/projects/-home-jared-dev-cc-os--claude-worktrees-crc-os-sdlc-run-3/2e167079-f404-4139-9cfa-6c0c937ce9f0.jsonl - Where: plugins/os-sdlc/lib/os_sdlc/agent/type/unknown_error.rb, plugins/os-sdlc/lib/os_sdlc/cops/array_literal_of_locals_return/locals_list.rb, plugins/os-sdlc/lib/os_sdlc/project/artifact_dir.rb, plugins/os-sdlc/lib/os_sdlc/crc/census/definition.rb, plugins/os-sdlc/lib/os_sdlc/crc/census/definitions.rb, plugins/os-sdlc/lib/os_sdlc/crc/census/expected_constants.rb, plugins/os-sdlc/lib/os_sdlc/crc/census/namespace_definitions.rb, plugins/os-sdlc/lib/os_sdlc/crc/census/statements.rb, plugins/os-sdlc/lib/os_sdlc/crc/census/value_block.rb, plugins/os-sdlc/lib/os_sdlc/cops/inward_dependency/reference.rb, plugins/os-sdlc/lib/os_sdlc/crc/ledger/check/check.rb, plugins/os-sdlc/lib/os_sdlc/crc/ledger/commits/stamp.rb, plugins/os-sdlc/lib/os_sdlc/lsp_timeout_error.rb, plugins/os-sdlc/lib/os_sdlc/brief.rb, plugins/os-sdlc/lib/os_sdlc/brief/facts.rb, plugins/os-sdlc/lib/os_sdlc/brief/facts/unknown_fact_error.rb, plugins/os-sdlc/lib/os_sdlc/brief/gate_output_warning.rb, plugins/os-sdlc/lib/os_sdlc/brief/lint_offense.rb, plugins/os-sdlc/lib/os_sdlc/brief/lint_offense_entry.rb, plugins/os-sdlc/lib/os_sdlc/brief/lint_offenses.rb, plugins/os-sdlc/lib/os_sdlc/brief/missing_file_error.rb, plugins/os-sdlc/lib/os_sdlc/brief/objections_digest.rb, plugins/os-sdlc/tests/support/report_scenario.rb, plugins/os-sdlc/tests/support/resolver_assertions.rb, plugins/os-sdlc/tests/support/resolver_scenario.rb - CRC refactor run: docs/crc/os-sdlc/. - Ledger: docs/crc/os-sdlc/ledger.tsv - Wave: 4.
Author
Owner

Commits 06f209da, df0bebfb, b07fe9df, 941edc7c, d1a22816, d98443c6; rows applied 25/25; rows deviated 0 (2 inward-lint notes in deviations.md); rows blocked 0

Commits 06f209da, df0bebfb, b07fe9df, 941edc7c, d1a22816, d98443c6; rows applied 25/25; rows deviated 0 (2 inward-lint notes in deviations.md); rows blocked 0
Author
Owner

Follow-up dropped (skeptic, run 3 close-out): "Reparent errors to OsSdlc::Error". No code rescues OsSdlc::Error, and the depth-1 rule applies.

Follow-up dropped (skeptic, run 3 close-out): "Reparent errors to OsSdlc::Error". No code rescues OsSdlc::Error, and the depth-1 rule applies.
Author
Owner

Resolution

Done: Wave 4 batch applied: 25 ledger rows renamed or moved, behavior unchanged.

Evidence: 06f209da df0bebfb b07fe9df 941edc7c d1a22816 d98443c6; ledger 47b14f03; HEAD a2199744 suite 2273 runs 5106 assertions 0 failures 0 errors 45.3s; rubocop on run 3 files: no new offense (tests/dispatch_test.rb:211 InlineDatasetQuery predates run 3; PrimitiveObsessedIvar crashes on retired_test.rb, tooling item)

Follow-ups: #1212 (inward edges, created); drop 01 (reparent errors) noted on this ticket

## Resolution **Done:** Wave 4 batch applied: 25 ledger rows renamed or moved, behavior unchanged. **Evidence:** 06f209da df0bebfb b07fe9df 941edc7c d1a22816 d98443c6; ledger 47b14f03; HEAD a2199744 suite 2273 runs 5106 assertions 0 failures 0 errors 45.3s; rubocop on run 3 files: no new offense (tests/dispatch_test.rb:211 InlineDatasetQuery predates run 3; PrimitiveObsessedIvar crashes on retired_test.rb, tooling item) **Follow-ups:** #1212 (inward edges, created); drop 01 (reparent errors) noted on this ticket
jared closed this issue 2026-10-20 14:09:05 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
jared/cc-os#1207
No description provided.