jared/cc-os

Watch

Fork 0

Rename: run to request for run #1194

New issue

Closed

opened 2026-10-20 02:11:09 +00:00 by jared · 2 comments

jared commented

2026-10-20 02:11:09 +00:00

Owner

Problem

run (name_collision, score 36) spans 18 classes in concepts CollaboratorPass, Crc.

OsSdlc::CollaboratorPass::ConceptBrief (/home/jared/dev/cc-os/.claude/worktrees/crc-os-sdlc-run-3/plugins/os-sdlc/lib/os_sdlc/collaborator_pass/concept_brief.rb:9)
OsSdlc::CollaboratorPass::ConceptBrief::EntryCallers (/home/jared/dev/cc-os/.claude/worktrees/crc-os-sdlc-run-3/plugins/os-sdlc/lib/os_sdlc/collaborator_pass/concept_brief/entry_callers.rb:7)
OsSdlc::CollaboratorPass::ConceptBrief::Owners (/home/jared/dev/cc-os/.claude/worktrees/crc-os-sdlc-run-3/plugins/os-sdlc/lib/os_sdlc/collaborator_pass/concept_brief/owners.rb:7)
OsSdlc::CollaboratorPass::ConceptBrief::Site (/home/jared/dev/cc-os/.claude/worktrees/crc-os-sdlc-run-3/plugins/os-sdlc/lib/os_sdlc/collaborator_pass/concept_brief/site.rb:7)
OsSdlc::CollaboratorPass::Meanings (/home/jared/dev/cc-os/.claude/worktrees/crc-os-sdlc-run-3/plugins/os-sdlc/lib/os_sdlc/collaborator_pass/meanings.rb:6)
OsSdlc::CollaboratorPass::PrescriptionBrief (/home/jared/dev/cc-os/.claude/worktrees/crc-os-sdlc-run-3/plugins/os-sdlc/lib/os_sdlc/collaborator_pass/prescription_brief.rb:9)
OsSdlc::CollaboratorPass::RecipeCheck (/home/jared/dev/cc-os/.claude/worktrees/crc-os-sdlc-run-3/plugins/os-sdlc/lib/os_sdlc/collaborator_pass/recipe_check.rb:6)
OsSdlc::CollaboratorPass::RecipeCheck::ObjectRules (/home/jared/dev/cc-os/.claude/worktrees/crc-os-sdlc-run-3/plugins/os-sdlc/lib/os_sdlc/collaborator_pass/recipe_check/object_rules.rb:7)
OsSdlc::CollaboratorPass::RecipeCheck::SubjectRules (/home/jared/dev/cc-os/.claude/worktrees/crc-os-sdlc-run-3/plugins/os-sdlc/lib/os_sdlc/collaborator_pass/recipe_check/subject_rules.rb:7)
OsSdlc::CollaboratorPass::RecipeCheck::TargetRules (/home/jared/dev/cc-os/.claude/worktrees/crc-os-sdlc-run-3/plugins/os-sdlc/lib/os_sdlc/collaborator_pass/recipe_check/target_rules.rb:7)
OsSdlc::CollaboratorPass::TicketDraft (/home/jared/dev/cc-os/.claude/worktrees/crc-os-sdlc-run-3/plugins/os-sdlc/lib/os_sdlc/collaborator_pass/ticket_draft.rb:8)
OsSdlc::CollaboratorPass::TicketDraft::Origin (/home/jared/dev/cc-os/.claude/worktrees/crc-os-sdlc-run-3/plugins/os-sdlc/lib/os_sdlc/collaborator_pass/ticket_draft/origin.rb:7)
OsSdlc::CollaboratorPass::TicketDraft::Problem (/home/jared/dev/cc-os/.claude/worktrees/crc-os-sdlc-run-3/plugins/os-sdlc/lib/os_sdlc/collaborator_pass/ticket_draft/problem.rb:7)
OsSdlc::Crc::InwardDelta::Run (/home/jared/dev/cc-os/.claude/worktrees/crc-os-sdlc-run-3/plugins/os-sdlc/lib/os_sdlc/crc/inward_delta/run.rb:7)
OsSdlc::Crc::Ledger::Commits::Run (/home/jared/dev/cc-os/.claude/worktrees/crc-os-sdlc-run-3/plugins/os-sdlc/lib/os_sdlc/crc/ledger/commits/run.rb:8)
OsSdlc::Crc::Placement::Run (/home/jared/dev/cc-os/.claude/worktrees/crc-os-sdlc-run-3/plugins/os-sdlc/lib/os_sdlc/crc/placement/run.rb:7)
OsSdlc::Crc::Records::Run (/home/jared/dev/cc-os/.claude/worktrees/crc-os-sdlc-run-3/plugins/os-sdlc/lib/os_sdlc/crc/records/run.rb:9)
OsSdlc::Crc::Tickets::Run (/home/jared/dev/cc-os/.claude/worktrees/crc-os-sdlc-run-3/plugins/os-sdlc/lib/os_sdlc/crc/tickets/run.rb:9)

Hash takers 5; OsSdlc::CollaboratorPass::RunDirectory takers 13; untyped 9

Approach

One name carries two meanings; give each its own name. The Hash sites are the five Crc Run commands that take the parsed request under the name run; the 13 collaborator-pass sites take a RunDirectory and keep the name. Renaming the Hash parameter splits the two meanings without a new object.

Required work:

OsSdlc::Crc::InwardDelta::Run takes io, project, request — check: absent run: in plugins/os-sdlc/lib/os_sdlc/crc/inward_delta/run.rb
OsSdlc::Crc::Ledger::Commits::Run takes io, project, request — check: absent run: in plugins/os-sdlc/lib/os_sdlc/crc/ledger/commits/run.rb
OsSdlc::Crc::Placement::Run takes io, project, request — check: absent run: in plugins/os-sdlc/lib/os_sdlc/crc/placement/run.rb
OsSdlc::Crc::Records::Run takes io, project, request — check: absent run: in plugins/os-sdlc/lib/os_sdlc/crc/records/run.rb
OsSdlc::Crc::Tickets::Run takes io, project, request — check: absent run: in plugins/os-sdlc/lib/os_sdlc/crc/tickets/run.rb

Orchestrator work: write these entries to the root GLOSSARY.md, create the file when it is absent, and make docs/agents/domain.md point to it. Then re-measure with bin/collaborator-pass measure --runs docs/crc/os-sdlc/collaborator-runs, then stop-check.

run: One saved collaborator-pass run: the directory that holds its findings, join, and recipes. Avoid: run_path, run_dir_object.

Acceptance criteria

Given today's lib, when bin/collaborator-pass measure --sources params,inward,flay runs after the change, then the name_collision finding run scores at most 0 (was 36) and none of run appears in its names.
Given any of the five crc commands (inward-delta, ledger-commits, placement, records, tickets), when it runs with the same argv, then its output and exit status are unchanged.
Given the tests of the five touched Run classes, when the suite runs, then they pass.

Owner sketch

class OsSdlc::Crc::InwardDelta::Run
  def initialize(io, project, request)
  end
end

class OsSdlc::Crc::Ledger::Commits::Run
  def initialize(io, project, request)
  end
end

class OsSdlc::Crc::Placement::Run
  def initialize(io, project, request)
  end
end

class OsSdlc::Crc::Records::Run
  def initialize(io, project, request)
  end
end

class OsSdlc::Crc::Tickets::Run
  def initialize(io, project, request)
  end
end

Origin

Trigger: bin/collaborator-pass run 20261020T020325Z
Improvised this session: none
Chain: run across 18 classes ← DESIGN (plugins/os-sdlc/lib/os_sdlc/crc/inward_delta/run.rb)
Root candidate: none found; searched run, request, rename, name_collision, Crc Run, RunPath, RunDirectory
Where: plugins/os-sdlc/lib/os_sdlc/crc/inward_delta/run.rb
Session: 2e167079-f404-4139-9cfa-6c0c937ce9f0
Transcript: /home/jared/.claude/projects/-home-jared-dev-cc-os--claude-worktrees-crc-os-sdlc-run-3/2e167079-f404-4139-9cfa-6c0c937ce9f0.jsonl

VERDICT: CREATE

## Problem run (name_collision, score 36) spans 18 classes in concepts CollaboratorPass, Crc. - `OsSdlc::CollaboratorPass::ConceptBrief` (`/home/jared/dev/cc-os/.claude/worktrees/crc-os-sdlc-run-3/plugins/os-sdlc/lib/os_sdlc/collaborator_pass/concept_brief.rb:9`) - `OsSdlc::CollaboratorPass::ConceptBrief::EntryCallers` (`/home/jared/dev/cc-os/.claude/worktrees/crc-os-sdlc-run-3/plugins/os-sdlc/lib/os_sdlc/collaborator_pass/concept_brief/entry_callers.rb:7`) - `OsSdlc::CollaboratorPass::ConceptBrief::Owners` (`/home/jared/dev/cc-os/.claude/worktrees/crc-os-sdlc-run-3/plugins/os-sdlc/lib/os_sdlc/collaborator_pass/concept_brief/owners.rb:7`) - `OsSdlc::CollaboratorPass::ConceptBrief::Site` (`/home/jared/dev/cc-os/.claude/worktrees/crc-os-sdlc-run-3/plugins/os-sdlc/lib/os_sdlc/collaborator_pass/concept_brief/site.rb:7`) - `OsSdlc::CollaboratorPass::Meanings` (`/home/jared/dev/cc-os/.claude/worktrees/crc-os-sdlc-run-3/plugins/os-sdlc/lib/os_sdlc/collaborator_pass/meanings.rb:6`) - `OsSdlc::CollaboratorPass::PrescriptionBrief` (`/home/jared/dev/cc-os/.claude/worktrees/crc-os-sdlc-run-3/plugins/os-sdlc/lib/os_sdlc/collaborator_pass/prescription_brief.rb:9`) - `OsSdlc::CollaboratorPass::RecipeCheck` (`/home/jared/dev/cc-os/.claude/worktrees/crc-os-sdlc-run-3/plugins/os-sdlc/lib/os_sdlc/collaborator_pass/recipe_check.rb:6`) - `OsSdlc::CollaboratorPass::RecipeCheck::ObjectRules` (`/home/jared/dev/cc-os/.claude/worktrees/crc-os-sdlc-run-3/plugins/os-sdlc/lib/os_sdlc/collaborator_pass/recipe_check/object_rules.rb:7`) - `OsSdlc::CollaboratorPass::RecipeCheck::SubjectRules` (`/home/jared/dev/cc-os/.claude/worktrees/crc-os-sdlc-run-3/plugins/os-sdlc/lib/os_sdlc/collaborator_pass/recipe_check/subject_rules.rb:7`) - `OsSdlc::CollaboratorPass::RecipeCheck::TargetRules` (`/home/jared/dev/cc-os/.claude/worktrees/crc-os-sdlc-run-3/plugins/os-sdlc/lib/os_sdlc/collaborator_pass/recipe_check/target_rules.rb:7`) - `OsSdlc::CollaboratorPass::TicketDraft` (`/home/jared/dev/cc-os/.claude/worktrees/crc-os-sdlc-run-3/plugins/os-sdlc/lib/os_sdlc/collaborator_pass/ticket_draft.rb:8`) - `OsSdlc::CollaboratorPass::TicketDraft::Origin` (`/home/jared/dev/cc-os/.claude/worktrees/crc-os-sdlc-run-3/plugins/os-sdlc/lib/os_sdlc/collaborator_pass/ticket_draft/origin.rb:7`) - `OsSdlc::CollaboratorPass::TicketDraft::Problem` (`/home/jared/dev/cc-os/.claude/worktrees/crc-os-sdlc-run-3/plugins/os-sdlc/lib/os_sdlc/collaborator_pass/ticket_draft/problem.rb:7`) - `OsSdlc::Crc::InwardDelta::Run` (`/home/jared/dev/cc-os/.claude/worktrees/crc-os-sdlc-run-3/plugins/os-sdlc/lib/os_sdlc/crc/inward_delta/run.rb:7`) - `OsSdlc::Crc::Ledger::Commits::Run` (`/home/jared/dev/cc-os/.claude/worktrees/crc-os-sdlc-run-3/plugins/os-sdlc/lib/os_sdlc/crc/ledger/commits/run.rb:8`) - `OsSdlc::Crc::Placement::Run` (`/home/jared/dev/cc-os/.claude/worktrees/crc-os-sdlc-run-3/plugins/os-sdlc/lib/os_sdlc/crc/placement/run.rb:7`) - `OsSdlc::Crc::Records::Run` (`/home/jared/dev/cc-os/.claude/worktrees/crc-os-sdlc-run-3/plugins/os-sdlc/lib/os_sdlc/crc/records/run.rb:9`) - `OsSdlc::Crc::Tickets::Run` (`/home/jared/dev/cc-os/.claude/worktrees/crc-os-sdlc-run-3/plugins/os-sdlc/lib/os_sdlc/crc/tickets/run.rb:9`) Hash takers 5; OsSdlc::CollaboratorPass::RunDirectory takers 13; untyped 9 ## Approach One name carries two meanings; give each its own name. The Hash sites are the five Crc Run commands that take the parsed request under the name run; the 13 collaborator-pass sites take a RunDirectory and keep the name. Renaming the Hash parameter splits the two meanings without a new object. Required work: 1. `OsSdlc::Crc::InwardDelta::Run` takes `io, project, request` — check: absent `run:` in `plugins/os-sdlc/lib/os_sdlc/crc/inward_delta/run.rb` 2. `OsSdlc::Crc::Ledger::Commits::Run` takes `io, project, request` — check: absent `run:` in `plugins/os-sdlc/lib/os_sdlc/crc/ledger/commits/run.rb` 3. `OsSdlc::Crc::Placement::Run` takes `io, project, request` — check: absent `run:` in `plugins/os-sdlc/lib/os_sdlc/crc/placement/run.rb` 4. `OsSdlc::Crc::Records::Run` takes `io, project, request` — check: absent `run:` in `plugins/os-sdlc/lib/os_sdlc/crc/records/run.rb` 5. `OsSdlc::Crc::Tickets::Run` takes `io, project, request` — check: absent `run:` in `plugins/os-sdlc/lib/os_sdlc/crc/tickets/run.rb` Orchestrator work: write these entries to the root `GLOSSARY.md`, create the file when it is absent, and make `docs/agents/domain.md` point to it. Then re-measure with bin/collaborator-pass measure --runs docs/crc/os-sdlc/collaborator-runs, then stop-check. - **run**: One saved collaborator-pass run: the directory that holds its findings, join, and recipes. Avoid: run_path, run_dir_object. ## Acceptance criteria 1. Given today's lib, when bin/collaborator-pass measure --sources params,inward,flay runs after the change, then the name_collision finding run scores at most 0 (was 36) and none of run appears in its names. 2. Given any of the five crc commands (inward-delta, ledger-commits, placement, records, tickets), when it runs with the same argv, then its output and exit status are unchanged. 3. Given the tests of the five touched Run classes, when the suite runs, then they pass. ## Owner sketch ```ruby class OsSdlc::Crc::InwardDelta::Run def initialize(io, project, request) end end class OsSdlc::Crc::Ledger::Commits::Run def initialize(io, project, request) end end class OsSdlc::Crc::Placement::Run def initialize(io, project, request) end end class OsSdlc::Crc::Records::Run def initialize(io, project, request) end end class OsSdlc::Crc::Tickets::Run def initialize(io, project, request) end end ``` ## Origin - Trigger: bin/collaborator-pass run 20261020T020325Z - Improvised this session: none - Chain: run across 18 classes ← DESIGN (`plugins/os-sdlc/lib/os_sdlc/crc/inward_delta/run.rb`) - Root candidate: none found; searched run, request, rename, name_collision, Crc Run, RunPath, RunDirectory - Where: plugins/os-sdlc/lib/os_sdlc/crc/inward_delta/run.rb - Session: 2e167079-f404-4139-9cfa-6c0c937ce9f0 - Transcript: /home/jared/.claude/projects/-home-jared-dev-cc-os--claude-worktrees-crc-os-sdlc-run-3/2e167079-f404-4139-9cfa-6c0c937ce9f0.jsonl VERDICT: CREATE

jared added the

plugin/os-sdlc

filed-by/user

category/code-change

labels

2026-10-20 02:11:09 +00:00

jared commented

2026-10-20 02:13:46 +00:00

Author

Owner

Work started on branch crc-os-sdlc-run-3 (persistent worktree, in place).

jared added

category/structure

and removed

category/code-change

labels

2026-10-20 02:18:24 +00:00

jared referenced this issue from a commit

2026-10-20 02:31:45 +00:00

feat(os-sdlc): Renamed Hash parameter run to request in five crc run.rb files; collision test subject now settings. Gate green on rerun (required-work, lint, test-lint, suite, unchanged). (#1194)

jared commented

2026-10-20 02:32:10 +00:00

Author

Owner

Resolution

Done: Renamed the parsed request Hash parameter run to request in the five Crc Run commands; collision test subject now settings. Glossary entry for run already lives in plugins/os-sdlc/CONTEXT.md (51705a0c), which docs/agents/domain.md points to; no root GLOSSARY.md created to avoid a second glossary.

Evidence: 0d0c1a7a; os-sdlc-gate dispatch 809 green (required-work, lint, test-lint, suite, unchanged); delta-check vs 20261020T020325Z exit 0: name_collision run 36 -> 0, data_clump 266 -> 256, no shape regressed

Follow-ups: none

## Resolution **Done:** Renamed the parsed request Hash parameter run to request in the five Crc Run commands; collision test subject now settings. Glossary entry for run already lives in plugins/os-sdlc/CONTEXT.md (51705a0c), which docs/agents/domain.md points to; no root GLOSSARY.md created to avoid a second glossary. **Evidence:** 0d0c1a7a; os-sdlc-gate dispatch 809 green (required-work, lint, test-lint, suite, unchanged); delta-check vs 20261020T020325Z exit 0: name_collision run 36 -> 0, data_clump 266 -> 256, no shape regressed **Follow-ups:** none

jared closed this issue

2026-10-20 02:32:10 +00:00

jared referenced this issue from a commit

2026-10-20 02:33:47 +00:00

docs(crc): run 3 measure 20261020T023315Z after #1194; name_collision 50 -> 14

jared referenced this issue

2026-10-20 18:22:40 +00:00

Crc Run controllers build RunPath in the initializer; find the missing run config #1117