Cut Project -> Lint: move Project::Onboarding to Boot::Onboarding #1166
Labels
No labels
P0
P1
P2
P3
bug
category/code-change
category/cross-repo
category/eval-run
category/investigation
category/no-test-target
category/owner-ruling
category/prose-artifact
category/recurring-chore
category/structure
category/umbrella
crc-refactor
create
delete
enhancement
filed-by/agent
filed-by/user
frozen
lint-rule
needs-info
needs-triage
next
plugin/cc-architect
plugin/os
plugin/os-adr
plugin/os-aidd-lint
plugin/os-backlog
plugin/os-context
plugin/os-doc-hygiene
plugin/os-sdlc
plugin/os-vault
project/cc-os
ready-for-agent
ready-for-human
recurring
review
rule-proposal
update
waiting
wayfinder:grilling
wayfinder:map
wayfinder:map
wayfinder:research
wayfinder:task
wayfinder:task
wontfix
worklist/deviations
worklist/lint-rule
worklist/new-implement-build
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
jared/cc-os#1166
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Problem
The Project concept calls into the Lint concept.
Project::Onboardingis the Thor CLI behindbin/os-sdlc. Itslint_initcommand buildsLint::SetupCommand(project/onboarding.rb:41). The edge Project -> Lint lies on 58 concept cycles. The CLI is an entry point. Entry points live in Boot.This ticket lands only after S4. Before S4, a move into Boot closes the cycle Lint -> ... -> Dispatch -> Boot -> Lint.
Reproduce
n/a: structure-wave cut, nothing to reproduce
Approach
Required work:
plugins/os-sdlc/lib/os_sdlc/project/onboarding.rbtoplugins/os-sdlc/lib/os_sdlc/boot/onboarding.rband rename the class toOsSdlc::Boot::Onboarding < Thor. Behavior stays the same — check: absentOnboardinginplugins/os-sdlc/lib/os_sdlc/project/**/*.rbplugins/os-sdlc/bin/os-sdlc, callOsSdlc::Boot::Onboarding.start(ARGV, invocation: OsSdlc::ProcessIO.from_process).plugins/os-sdlc/tests/controller/project/cli_project_config_test.rb,plugins/os-sdlc/tests/controller/project/cli_project_config_help_test.rbandplugins/os-sdlc/tests/controller/project/cli_project_config_show_target_test.rbto callOsSdlc::Boot::Onboarding.start.Acceptance criteria
bin/crc-cycle-edgesruns, then no edge Project -> Lint listsproject/onboarding.rb:41.bin/os-sdlc lint-initandbin/os-sdlc project-config, when each runs, then each prints the same output and exit code as before the move.Owner sketch
bin/os-sdlcstays the single entry script. ADR-0123 (Thor for plugin bin CLIs) and ADR-0232 (one bin script per dispatch command) stay true.Non-goals
Tests that move or change only a constant name follow the code in the same commit (git mv, then update the constant). Delete no test.
Blocked by S4. Do not land this ticket before S4.
Origin
049a7820)VERDICT: CREATE
Resolution
Done: Moved Project::Onboarding to Boot::Onboarding (git mv); bin/os-sdlc and the three cli_project_config tests call Boot::Onboarding.start. Cut the Project -> Lint cycle edge.
Evidence:
8f007fd7(runner commit),53cd767b(move the runner commit left staged),845114bf(ledger S2 row), merged to main; pipeline gate dispatch 768 green on required-work, lint, test-lint, suite, unchanged; suite 2249 runs, 0 failures (57.2 s); eager load exit 0; crc-cycle-edges lists no onboarding.rb edge; cycle edges 8 -> 6; inward delta exit 1 only from the #1174 rename false positive; bin/os-sdlc help exit 0.Follow-ups: none (the structure-changer 10-minute wait found on this run is fixed in-process:
3f76bcb4)