test-writer does not record the lens classification its prompt now requires #1110

New issue

Open

opened 2026-10-18 16:38:39 +00:00 by jared · 0 comments

jared commented

2026-10-18 16:38:39 +00:00

Owner

Problem

test-writer does not record the lens classification that its prompt now requires. The test-reviewer cannot check a classification that no handoff carries.

Observed

Commit b1db4ffe added a step to plugins/os-sdlc/agents/test-writer.md: name the lens-testing rule and lens-taxonomy-tests kind per test, and record both in the summary line.
In implementation 65 (dispatches 555, 559, 564, 567) no writer handoff summary carried a rule or a kind.
The transcript shows the writer reading the lens.
Open question: is the summary line the wrong field (the handoff YAML has no per-test slot), or did the instruction not bind?

Reproduce

n/a: design gap; see implementation 65 dispatches 555, 559, 564, 567.

Approach

Add a per-test field (rule, kind) to the writer handoff schema, readable by the test-reviewer. Add a gate or reviewer check that rejects a test with no classification before review.

Required work: none beyond the acceptance criteria.

Acceptance criteria

Given a writer handoff, when it lists a test, then the entry carries a rule and a kind.
Given a writer handoff with a test that has no rule or kind, when the gate or reviewer checks it, then the handoff is rejected before review.
Given a classified test, when the test-reviewer reads the handoff, then it can read the rule and the kind.

Origin

Trigger: implementation 65 of #1105, writer dispatches 555, 559, 564, 567
Improvised this session: none
Chain: no classification in summaries ← handoff YAML has no per-test slot, or instruction did not bind (unresolved, DESIGN)
Root candidate: none
Where: plugins/os-sdlc/agents/test-writer.md
Session: 26783407-6911-48d5-a818-55fbfbc70108
Transcript: /home/jared/.claude/projects/-home-jared-dev-cc-os/26783407-6911-48d5-a818-55fbfbc70108.jsonl

VERDICT: CREATE

## Problem `test-writer` does not record the lens classification that its prompt now requires. The test-reviewer cannot check a classification that no handoff carries. ## Observed Commit b1db4ffe added a step to `plugins/os-sdlc/agents/test-writer.md`: name the lens-testing rule and lens-taxonomy-tests kind per test, and record both in the summary line. In implementation 65 (dispatches 555, 559, 564, 567) no writer handoff summary carried a rule or a kind. The transcript shows the writer reading the lens. Open question: is the summary line the wrong field (the handoff YAML has no per-test slot), or did the instruction not bind? ## Reproduce n/a: design gap; see implementation 65 dispatches 555, 559, 564, 567. ## Approach Add a per-test field (rule, kind) to the writer handoff schema, readable by the test-reviewer. Add a gate or reviewer check that rejects a test with no classification before review. Required work: none beyond the acceptance criteria. ## Acceptance criteria 1. Given a writer handoff, when it lists a test, then the entry carries a rule and a kind. 2. Given a writer handoff with a test that has no rule or kind, when the gate or reviewer checks it, then the handoff is rejected before review. 3. Given a classified test, when the test-reviewer reads the handoff, then it can read the rule and the kind. ## Origin - Trigger: implementation 65 of #1105, writer dispatches 555, 559, 564, 567 - Improvised this session: none - Chain: no classification in summaries ← handoff YAML has no per-test slot, or instruction did not bind (unresolved, DESIGN) - Root candidate: none - Where: plugins/os-sdlc/agents/test-writer.md - Session: 26783407-6911-48d5-a818-55fbfbc70108 - Transcript: /home/jared/.claude/projects/-home-jared-dev-cc-os/26783407-6911-48d5-a818-55fbfbc70108.jsonl VERDICT: CREATE

jared added the

plugin/os-sdlc

filed-by/user

category/code-change

labels

2026-10-18 16:38:39 +00:00

jared referenced this issue

2026-10-18 16:52:59 +00:00

Add category/structure and an os-backlog categorize gate #1105