Check every subject of a multi-subject collaborator-pass recipe #1101

New issue

Open

opened 2026-10-18 14:53:30 +00:00 by jared · 0 comments

jared commented

2026-10-18 14:53:30 +00:00

Owner

Problem

A collaborator-pass recipe with several subjects is checked only against its main finding. expected_delta and names_leaving (DeltaRules and TargetRules in recipe_check) read only finding. So do ticket_draft, delta-check and ticket-body. A recipe that resolves three clumps cannot list the names that leave from the other subjects. Its ticket and delta do not show them.

Reproduce

n/a: design gap. Read plugins/os-sdlc/lib/os_sdlc/collaborator_pass/recipe_check/*.rb.

Approach

Check and render every subject of a recipe, not only the main finding.

Required work:

Make DeltaRules and TargetRules in recipe_check read the names that leave from every subject.
Make the ticket_body and delta_check commands show the names from every subject.

Acceptance criteria

Given a recipe with three subjects that each list names that leave, when the recipe is checked, then all names are accepted.
Given the same recipe, when ticket-body and delta-check run, then the output lists the names from all three subjects.

Origin

Trigger: Follow-up from #1094 (implementation 63, hand-finish commit 17d4c688), session 6f78b932-f117-4bd7-bbed-524776dbb719.
Improvised this session: none
Chain: ticket and delta omit names <- checks read only finding <- recipe model has one main finding
Where: plugins/os-sdlc/lib/os_sdlc/collaborator_pass/recipe_check/*.rb
Session: 6f78b932-f117-4bd7-bbed-524776dbb719
Transcript: /home/jared/.claude/projects/-home-jared-dev-cc-os/6f78b932-f117-4bd7-bbed-524776dbb719.jsonl

## Problem A collaborator-pass recipe with several subjects is checked only against its main `finding`. `expected_delta` and `names_leaving` (DeltaRules and TargetRules in recipe_check) read only `finding`. So do `ticket_draft`, `delta-check` and `ticket-body`. A recipe that resolves three clumps cannot list the names that leave from the other subjects. Its ticket and delta do not show them. ## Reproduce n/a: design gap. Read plugins/os-sdlc/lib/os_sdlc/collaborator_pass/recipe_check/*.rb. ## Approach Check and render every subject of a recipe, not only the main `finding`. Required work: 1. Make DeltaRules and TargetRules in recipe_check read the names that leave from every subject. 2. Make the ticket_body and delta_check commands show the names from every subject. ## Acceptance criteria 1. Given a recipe with three subjects that each list names that leave, when the recipe is checked, then all names are accepted. 2. Given the same recipe, when ticket-body and delta-check run, then the output lists the names from all three subjects. ## Origin - Trigger: Follow-up from #1094 (implementation 63, hand-finish commit 17d4c688), session 6f78b932-f117-4bd7-bbed-524776dbb719. - Improvised this session: none - Chain: ticket and delta omit names <- checks read only finding <- recipe model has one main finding - Where: plugins/os-sdlc/lib/os_sdlc/collaborator_pass/recipe_check/*.rb - Session: 6f78b932-f117-4bd7-bbed-524776dbb719 - Transcript: /home/jared/.claude/projects/-home-jared-dev-cc-os/6f78b932-f117-4bd7-bbed-524776dbb719.jsonl

jared added the

plugin/os-sdlc

filed-by/user

category/code-change

labels

2026-10-18 14:53:30 +00:00

jared referenced this issue

2026-10-18 14:54:51 +00:00

collaborator-pass: prescribe per concept with an owners-that-exist list #1094