CRC wave 4: apply Agent, Crc, Project, Suite renames and moves #1099
Labels
No labels
P0
P1
P2
P3
bug
category/code-change
category/cross-repo
category/eval-run
category/investigation
category/no-test-target
category/owner-ruling
category/prose-artifact
category/recurring-chore
category/structure
category/umbrella
crc-refactor
create
delete
enhancement
filed-by/agent
filed-by/user
frozen
lint-rule
needs-info
needs-triage
next
plugin/cc-architect
plugin/os
plugin/os-adr
plugin/os-aidd-lint
plugin/os-backlog
plugin/os-context
plugin/os-doc-hygiene
plugin/os-sdlc
plugin/os-vault
project/cc-os
ready-for-agent
ready-for-human
recurring
review
rule-proposal
update
waiting
wayfinder:grilling
wayfinder:map
wayfinder:map
wayfinder:research
wayfinder:task
wayfinder:task
wontfix
worklist/deviations
worklist/lint-rule
worklist/new-implement-build
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
jared/cc-os#1099
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Problem
Apply 14 ledger rows (rename and move) for Agent, Crc, Project, Suite. Each row's path, constant, and test path change as listed in Approach.
Reproduce
n/a: structure-only refactor, no behavior change.
Approach
plugins/os-sdlc/lib/os_sdlc/agent_type.rb->plugins/os-sdlc/lib/os_sdlc/agent/type.rbOsSdlc::AgentType->OsSdlc::Agent::Typeplugins/os-sdlc/tests/agent_type_test.rb->plugins/os-sdlc/tests/agent/type_test.rbplugins/os-sdlc/lib/os_sdlc/agent_type/unknown_error.rb->plugins/os-sdlc/lib/os_sdlc/agent/type/unknown_error.rbOsSdlc::AgentType::UnknownError->OsSdlc::Agent::Type::UnknownErrorplugins/os-sdlc/lib/os_sdlc/crc_file.rb->plugins/os-sdlc/lib/os_sdlc/crc/filing.rbOsSdlc::CrcFile->OsSdlc::Crc::Filingplugins/os-sdlc/tests/crc_file/crc_file_bin_test.rb->plugins/os-sdlc/tests/crc/filing_bin_test.rbplugins/os-sdlc/lib/os_sdlc/crc_file/backlog_client.rb->plugins/os-sdlc/lib/os_sdlc/crc/filing/backlog_client.rbOsSdlc::CrcFile::BacklogClient->OsSdlc::Crc::Filing::BacklogClientplugins/os-sdlc/lib/os_sdlc/crc_file/plan.rb->plugins/os-sdlc/lib/os_sdlc/crc/filing/plan.rbOsSdlc::CrcFile::Plan->OsSdlc::Crc::Filing::Planplugins/os-sdlc/lib/os_sdlc/crc_file/read_back_check.rb->plugins/os-sdlc/lib/os_sdlc/crc/filing/read_back_check.rbOsSdlc::CrcFile::ReadBackCheck->OsSdlc::Crc::Filing::ReadBackCheckplugins/os-sdlc/lib/os_sdlc/crc_file/run.rb->plugins/os-sdlc/lib/os_sdlc/crc/filing/run.rbOsSdlc::CrcFile::Run->OsSdlc::Crc::Filing::Runplugins/os-sdlc/lib/os_sdlc/project/codebase/lib_root_error.rb->plugins/os-sdlc/lib/os_sdlc/project/codebase/namespace_root_error.rbOsSdlc::Project::Codebase::LibRootError->OsSdlc::Project::Codebase::NamespaceRootErrorplugins/os-sdlc/tests/project/codebase_lib_root_test.rb->plugins/os-sdlc/tests/project/codebase_namespace_root_test.rbplugins/os-sdlc/lib/os_sdlc/project/test/candidates.rb->plugins/os-sdlc/lib/os_sdlc/suite/candidates.rbOsSdlc::Project::Test::Candidates->OsSdlc::Suite::Candidatesplugins/os-sdlc/lib/os_sdlc/retired_test.rb->plugins/os-sdlc/lib/os_sdlc/suite/retired_test.rbOsSdlc::RetiredTest->OsSdlc::Suite::RetiredTestplugins/os-sdlc/tests/retired_test_test.rb->plugins/os-sdlc/tests/suite/retired_test_test.rbplugins/os-sdlc/lib/os_sdlc/diff_test_plan.rb->plugins/os-sdlc/lib/os_sdlc/suite/diff_plan.rbOsSdlc::DiffTestPlan->OsSdlc::Suite::DiffPlanplugins/os-sdlc/tests/diff_test_plan_test.rb->plugins/os-sdlc/tests/suite/diff_plan_test.rbplugins/os-sdlc/lib/os_sdlc/project/test.rb->plugins/os-sdlc/lib/os_sdlc/suite.rbOsSdlc::Project::Test->OsSdlc::Suiteplugins/os-sdlc/lib/os_sdlc/test_output/summary.rb->plugins/os-sdlc/lib/os_sdlc/suite/output/summary.rbOsSdlc::TestOutput::Summary->OsSdlc::Suite::Output::Summaryplugins/os-sdlc/lib/os_sdlc/test_output.rb->plugins/os-sdlc/lib/os_sdlc/suite/output.rbOsSdlc::TestOutput->OsSdlc::Suite::Outputplugins/os-sdlc/tests/test_output_test.rb->plugins/os-sdlc/tests/suite/output_test.rbBefore you finish, grep the repository for each old file path and each old constant, not only the constant. Config and docs keep old paths (for example .rubocop.yml, loader collapse lists).
Acceptance criteria
ruby plugins/os-sdlc/tests/all.rb0 failures.ruby -e 'require "./plugins/os-sdlc/lib/os_sdlc"; OsSdlc::Db.connect!(":memory:"); OsSdlc.loader.eager_load'silent.Owner sketch
Each constant matches its new path; callers follow the new name.
Non-goals
Origin
item 2
8ad0f302; item 31a01c579(+ style832099bb); item 4e61dc448(+ style3939b520); item 1 (R135) cancelled and undone before commit; rows applied 13/14; deviated 0; blocked 0 (R135 cancelled by Jared)Resolution
Done: Applied 13 of 13 rows after Jared cancelled R135 (lib_root rename): R136 crc_file -> Crc::Filing; R137 pre-bind agent name read moved to PluginRoot::AGENT_NAMES/AGENT_PREFIX and Event::UnknownAgentError, then agent_type -> Agent::Type; R138 suite files -> Suite, Suite::Output, Suite::Output::Summary, Suite::RetiredTest, Suite::DiffPlan, Suite::Candidates.
Evidence:
8ad0f302,1a01c579(+832099bbstyle),e61dc448(+3939b520style), recordsdacec83d; suite 2085 runs, 0 failures, 0 errors; eager load silent; lint-sweep 1432 files, 201 offenses; bin/crc-placement --target os-sdlc: header only, exit 0Follow-ups: Ledger rows for boot/inputs/crc_argv.rb, boot/inputs/usage.rb, collaborator_pass/run.rb, collaborator_pass/subcommand.rb (#1093 files, unmapped in the inward lint); gone: notes for the 8 deleted crc command rows