CRC wave 4: apply Agent, Crc, Project, Suite renames and moves #1099

Closed
opened 2026-10-17 22:50:35 +00:00 by jared · 2 comments
Owner

Problem

Apply 14 ledger rows (rename and move) for Agent, Crc, Project, Suite. Each row's path, constant, and test path change as listed in Approach.

Reproduce

n/a: structure-only refactor, no behavior change.

Approach

  1. Required work, in order:
    1. plugins/os-sdlc/lib/os_sdlc/agent_type.rb -> plugins/os-sdlc/lib/os_sdlc/agent/type.rb
      • constant: OsSdlc::AgentType -> OsSdlc::Agent::Type
      • test: plugins/os-sdlc/tests/agent_type_test.rb -> plugins/os-sdlc/tests/agent/type_test.rb
    2. plugins/os-sdlc/lib/os_sdlc/agent_type/unknown_error.rb -> plugins/os-sdlc/lib/os_sdlc/agent/type/unknown_error.rb
      • constant: OsSdlc::AgentType::UnknownError -> OsSdlc::Agent::Type::UnknownError
      • test: no test file
    3. plugins/os-sdlc/lib/os_sdlc/crc_file.rb -> plugins/os-sdlc/lib/os_sdlc/crc/filing.rb
      • constant: OsSdlc::CrcFile -> OsSdlc::Crc::Filing
      • test: plugins/os-sdlc/tests/crc_file/crc_file_bin_test.rb -> plugins/os-sdlc/tests/crc/filing_bin_test.rb
    4. plugins/os-sdlc/lib/os_sdlc/crc_file/backlog_client.rb -> plugins/os-sdlc/lib/os_sdlc/crc/filing/backlog_client.rb
      • constant: OsSdlc::CrcFile::BacklogClient -> OsSdlc::Crc::Filing::BacklogClient
      • test: no test file
    5. plugins/os-sdlc/lib/os_sdlc/crc_file/plan.rb -> plugins/os-sdlc/lib/os_sdlc/crc/filing/plan.rb
      • constant: OsSdlc::CrcFile::Plan -> OsSdlc::Crc::Filing::Plan
      • test: no test file
    6. plugins/os-sdlc/lib/os_sdlc/crc_file/read_back_check.rb -> plugins/os-sdlc/lib/os_sdlc/crc/filing/read_back_check.rb
      • constant: OsSdlc::CrcFile::ReadBackCheck -> OsSdlc::Crc::Filing::ReadBackCheck
      • test: no test file
    7. plugins/os-sdlc/lib/os_sdlc/crc_file/run.rb -> plugins/os-sdlc/lib/os_sdlc/crc/filing/run.rb
      • constant: OsSdlc::CrcFile::Run -> OsSdlc::Crc::Filing::Run
      • test: no test file
    8. plugins/os-sdlc/lib/os_sdlc/project/codebase/lib_root_error.rb -> plugins/os-sdlc/lib/os_sdlc/project/codebase/namespace_root_error.rb
      • constant: OsSdlc::Project::Codebase::LibRootError -> OsSdlc::Project::Codebase::NamespaceRootError
      • test: plugins/os-sdlc/tests/project/codebase_lib_root_test.rb -> plugins/os-sdlc/tests/project/codebase_namespace_root_test.rb
    9. plugins/os-sdlc/lib/os_sdlc/project/test/candidates.rb -> plugins/os-sdlc/lib/os_sdlc/suite/candidates.rb
      • constant: OsSdlc::Project::Test::Candidates -> OsSdlc::Suite::Candidates
      • test: no test file
    10. plugins/os-sdlc/lib/os_sdlc/retired_test.rb -> plugins/os-sdlc/lib/os_sdlc/suite/retired_test.rb
    • constant: OsSdlc::RetiredTest -> OsSdlc::Suite::RetiredTest
    • test: plugins/os-sdlc/tests/retired_test_test.rb -> plugins/os-sdlc/tests/suite/retired_test_test.rb
    1. plugins/os-sdlc/lib/os_sdlc/diff_test_plan.rb -> plugins/os-sdlc/lib/os_sdlc/suite/diff_plan.rb
    • constant: OsSdlc::DiffTestPlan -> OsSdlc::Suite::DiffPlan
    • test: plugins/os-sdlc/tests/diff_test_plan_test.rb -> plugins/os-sdlc/tests/suite/diff_plan_test.rb
    1. plugins/os-sdlc/lib/os_sdlc/project/test.rb -> plugins/os-sdlc/lib/os_sdlc/suite.rb
    • constant: OsSdlc::Project::Test -> OsSdlc::Suite
    • test: no test file
    1. plugins/os-sdlc/lib/os_sdlc/test_output/summary.rb -> plugins/os-sdlc/lib/os_sdlc/suite/output/summary.rb
    • constant: OsSdlc::TestOutput::Summary -> OsSdlc::Suite::Output::Summary
    • test: no test file
    1. plugins/os-sdlc/lib/os_sdlc/test_output.rb -> plugins/os-sdlc/lib/os_sdlc/suite/output.rb
    • constant: OsSdlc::TestOutput -> OsSdlc::Suite::Output
    • test: plugins/os-sdlc/tests/test_output_test.rb -> plugins/os-sdlc/tests/suite/output_test.rb
      Before you finish, grep the repository for each old file path and each old constant, not only the constant. Config and docs keep old paths (for example .rubocop.yml, loader collapse lists).
  2. Governing rulings:
    • R1
    • R3
    • R8
    • R16
    • R25
    • R38
    • R39
    • R48
    • R63
    • R65
    • R102
    • R133
    • R135
    • R136
    • R137
    • R138

Acceptance criteria

  • Every named ledger row is applied, or logged in deviations.md, or reported blocked.
  • ruby plugins/os-sdlc/tests/all.rb 0 failures.
  • ruby -e 'require "./plugins/os-sdlc/lib/os_sdlc"; OsSdlc::Db.connect!(":memory:"); OsSdlc.loader.eager_load' silent.

Owner sketch

Each constant matches its new path; callers follow the new name.

Non-goals

  • No behavior change.
  • No new tests.
  • No deletion of code that has callers.

Origin

  • Session: 629ed31a-21f2-4ddb-8f68-bc053959bd30
  • Transcript: /home/jared/.claude/projects/-home-jared-dev-cc-os/629ed31a-21f2-4ddb-8f68-bc053959bd30.jsonl
  • Where: plugins/os-sdlc/lib/os_sdlc/agent_type.rb, plugins/os-sdlc/lib/os_sdlc/agent_type/unknown_error.rb, plugins/os-sdlc/lib/os_sdlc/crc_file.rb, plugins/os-sdlc/lib/os_sdlc/crc_file/backlog_client.rb, plugins/os-sdlc/lib/os_sdlc/crc_file/plan.rb, plugins/os-sdlc/lib/os_sdlc/crc_file/read_back_check.rb, plugins/os-sdlc/lib/os_sdlc/crc_file/run.rb, plugins/os-sdlc/lib/os_sdlc/project/codebase/lib_root_error.rb, plugins/os-sdlc/lib/os_sdlc/project/test/candidates.rb, plugins/os-sdlc/lib/os_sdlc/retired_test.rb, plugins/os-sdlc/lib/os_sdlc/diff_test_plan.rb, plugins/os-sdlc/lib/os_sdlc/project/test.rb, plugins/os-sdlc/lib/os_sdlc/test_output/summary.rb, plugins/os-sdlc/lib/os_sdlc/test_output.rb
  • CRC refactor run: docs/crc/os-sdlc.
  • Ledger: docs/crc/os-sdlc/ledger.tsv
  • Wave: 4.
## Problem Apply 14 ledger rows (rename and move) for Agent, Crc, Project, Suite. Each row's path, constant, and test path change as listed in Approach. ## Reproduce n/a: structure-only refactor, no behavior change. ## Approach 1. Required work, in order: 1. `plugins/os-sdlc/lib/os_sdlc/agent_type.rb` -> `plugins/os-sdlc/lib/os_sdlc/agent/type.rb` - constant: `OsSdlc::AgentType` -> `OsSdlc::Agent::Type` - test: `plugins/os-sdlc/tests/agent_type_test.rb` -> `plugins/os-sdlc/tests/agent/type_test.rb` 2. `plugins/os-sdlc/lib/os_sdlc/agent_type/unknown_error.rb` -> `plugins/os-sdlc/lib/os_sdlc/agent/type/unknown_error.rb` - constant: `OsSdlc::AgentType::UnknownError` -> `OsSdlc::Agent::Type::UnknownError` - test: no test file 3. `plugins/os-sdlc/lib/os_sdlc/crc_file.rb` -> `plugins/os-sdlc/lib/os_sdlc/crc/filing.rb` - constant: `OsSdlc::CrcFile` -> `OsSdlc::Crc::Filing` - test: `plugins/os-sdlc/tests/crc_file/crc_file_bin_test.rb` -> `plugins/os-sdlc/tests/crc/filing_bin_test.rb` 4. `plugins/os-sdlc/lib/os_sdlc/crc_file/backlog_client.rb` -> `plugins/os-sdlc/lib/os_sdlc/crc/filing/backlog_client.rb` - constant: `OsSdlc::CrcFile::BacklogClient` -> `OsSdlc::Crc::Filing::BacklogClient` - test: no test file 5. `plugins/os-sdlc/lib/os_sdlc/crc_file/plan.rb` -> `plugins/os-sdlc/lib/os_sdlc/crc/filing/plan.rb` - constant: `OsSdlc::CrcFile::Plan` -> `OsSdlc::Crc::Filing::Plan` - test: no test file 6. `plugins/os-sdlc/lib/os_sdlc/crc_file/read_back_check.rb` -> `plugins/os-sdlc/lib/os_sdlc/crc/filing/read_back_check.rb` - constant: `OsSdlc::CrcFile::ReadBackCheck` -> `OsSdlc::Crc::Filing::ReadBackCheck` - test: no test file 7. `plugins/os-sdlc/lib/os_sdlc/crc_file/run.rb` -> `plugins/os-sdlc/lib/os_sdlc/crc/filing/run.rb` - constant: `OsSdlc::CrcFile::Run` -> `OsSdlc::Crc::Filing::Run` - test: no test file 8. `plugins/os-sdlc/lib/os_sdlc/project/codebase/lib_root_error.rb` -> `plugins/os-sdlc/lib/os_sdlc/project/codebase/namespace_root_error.rb` - constant: `OsSdlc::Project::Codebase::LibRootError` -> `OsSdlc::Project::Codebase::NamespaceRootError` - test: `plugins/os-sdlc/tests/project/codebase_lib_root_test.rb` -> `plugins/os-sdlc/tests/project/codebase_namespace_root_test.rb` 9. `plugins/os-sdlc/lib/os_sdlc/project/test/candidates.rb` -> `plugins/os-sdlc/lib/os_sdlc/suite/candidates.rb` - constant: `OsSdlc::Project::Test::Candidates` -> `OsSdlc::Suite::Candidates` - test: no test file 10. `plugins/os-sdlc/lib/os_sdlc/retired_test.rb` -> `plugins/os-sdlc/lib/os_sdlc/suite/retired_test.rb` - constant: `OsSdlc::RetiredTest` -> `OsSdlc::Suite::RetiredTest` - test: `plugins/os-sdlc/tests/retired_test_test.rb` -> `plugins/os-sdlc/tests/suite/retired_test_test.rb` 11. `plugins/os-sdlc/lib/os_sdlc/diff_test_plan.rb` -> `plugins/os-sdlc/lib/os_sdlc/suite/diff_plan.rb` - constant: `OsSdlc::DiffTestPlan` -> `OsSdlc::Suite::DiffPlan` - test: `plugins/os-sdlc/tests/diff_test_plan_test.rb` -> `plugins/os-sdlc/tests/suite/diff_plan_test.rb` 12. `plugins/os-sdlc/lib/os_sdlc/project/test.rb` -> `plugins/os-sdlc/lib/os_sdlc/suite.rb` - constant: `OsSdlc::Project::Test` -> `OsSdlc::Suite` - test: no test file 13. `plugins/os-sdlc/lib/os_sdlc/test_output/summary.rb` -> `plugins/os-sdlc/lib/os_sdlc/suite/output/summary.rb` - constant: `OsSdlc::TestOutput::Summary` -> `OsSdlc::Suite::Output::Summary` - test: no test file 14. `plugins/os-sdlc/lib/os_sdlc/test_output.rb` -> `plugins/os-sdlc/lib/os_sdlc/suite/output.rb` - constant: `OsSdlc::TestOutput` -> `OsSdlc::Suite::Output` - test: `plugins/os-sdlc/tests/test_output_test.rb` -> `plugins/os-sdlc/tests/suite/output_test.rb` Before you finish, grep the repository for each old file path and each old constant, not only the constant. Config and docs keep old paths (for example .rubocop.yml, loader collapse lists). 2. Governing rulings: - R1 - R3 - R8 - R16 - R25 - R38 - R39 - R48 - R63 - R65 - R102 - R133 - R135 - R136 - R137 - R138 ## Acceptance criteria - Every named ledger row is applied, or logged in deviations.md, or reported blocked. - `ruby plugins/os-sdlc/tests/all.rb` 0 failures. - `ruby -e 'require "./plugins/os-sdlc/lib/os_sdlc"; OsSdlc::Db.connect!(":memory:"); OsSdlc.loader.eager_load'` silent. ## Owner sketch Each constant matches its new path; callers follow the new name. ## Non-goals - No behavior change. - No new tests. - No deletion of code that has callers. ## Origin - Session: 629ed31a-21f2-4ddb-8f68-bc053959bd30 - Transcript: /home/jared/.claude/projects/-home-jared-dev-cc-os/629ed31a-21f2-4ddb-8f68-bc053959bd30.jsonl - Where: plugins/os-sdlc/lib/os_sdlc/agent_type.rb, plugins/os-sdlc/lib/os_sdlc/agent_type/unknown_error.rb, plugins/os-sdlc/lib/os_sdlc/crc_file.rb, plugins/os-sdlc/lib/os_sdlc/crc_file/backlog_client.rb, plugins/os-sdlc/lib/os_sdlc/crc_file/plan.rb, plugins/os-sdlc/lib/os_sdlc/crc_file/read_back_check.rb, plugins/os-sdlc/lib/os_sdlc/crc_file/run.rb, plugins/os-sdlc/lib/os_sdlc/project/codebase/lib_root_error.rb, plugins/os-sdlc/lib/os_sdlc/project/test/candidates.rb, plugins/os-sdlc/lib/os_sdlc/retired_test.rb, plugins/os-sdlc/lib/os_sdlc/diff_test_plan.rb, plugins/os-sdlc/lib/os_sdlc/project/test.rb, plugins/os-sdlc/lib/os_sdlc/test_output/summary.rb, plugins/os-sdlc/lib/os_sdlc/test_output.rb - CRC refactor run: docs/crc/os-sdlc. - Ledger: docs/crc/os-sdlc/ledger.tsv - Wave: 4.
Author
Owner

item 2 8ad0f302; item 3 1a01c579 (+ style 832099bb); item 4 e61dc448 (+ style 3939b520); item 1 (R135) cancelled and undone before commit; rows applied 13/14; deviated 0; blocked 0 (R135 cancelled by Jared)

item 2 8ad0f302; item 3 1a01c579 (+ style 832099bb); item 4 e61dc448 (+ style 3939b520); item 1 (R135) cancelled and undone before commit; rows applied 13/14; deviated 0; blocked 0 (R135 cancelled by Jared)
Author
Owner

Resolution

Done: Applied 13 of 13 rows after Jared cancelled R135 (lib_root rename): R136 crc_file -> Crc::Filing; R137 pre-bind agent name read moved to PluginRoot::AGENT_NAMES/AGENT_PREFIX and Event::UnknownAgentError, then agent_type -> Agent::Type; R138 suite files -> Suite, Suite::Output, Suite::Output::Summary, Suite::RetiredTest, Suite::DiffPlan, Suite::Candidates.

Evidence: 8ad0f302, 1a01c579 (+832099bb style), e61dc448 (+3939b520 style), records dacec83d; suite 2085 runs, 0 failures, 0 errors; eager load silent; lint-sweep 1432 files, 201 offenses; bin/crc-placement --target os-sdlc: header only, exit 0

Follow-ups: Ledger rows for boot/inputs/crc_argv.rb, boot/inputs/usage.rb, collaborator_pass/run.rb, collaborator_pass/subcommand.rb (#1093 files, unmapped in the inward lint); gone: notes for the 8 deleted crc command rows

## Resolution **Done:** Applied 13 of 13 rows after Jared cancelled R135 (lib_root rename): R136 crc_file -> Crc::Filing; R137 pre-bind agent name read moved to PluginRoot::AGENT_NAMES/AGENT_PREFIX and Event::UnknownAgentError, then agent_type -> Agent::Type; R138 suite files -> Suite, Suite::Output, Suite::Output::Summary, Suite::RetiredTest, Suite::DiffPlan, Suite::Candidates. **Evidence:** 8ad0f302, 1a01c579 (+832099bb style), e61dc448 (+3939b520 style), records dacec83d; suite 2085 runs, 0 failures, 0 errors; eager load silent; lint-sweep 1432 files, 201 offenses; bin/crc-placement --target os-sdlc: header only, exit 0 **Follow-ups:** Ledger rows for boot/inputs/crc_argv.rb, boot/inputs/usage.rb, collaborator_pass/run.rb, collaborator_pass/subcommand.rb (#1093 files, unmapped in the inward lint); gone: notes for the 8 deleted crc command rows
jared closed this issue 2026-10-17 22:59:10 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
jared/cc-os#1099
No description provided.