Let takedown polish correct lint offenses in failing_tests files #1082

New issue

Open

opened 2026-10-17 13:54:38 +00:00 by jared · 0 comments

jared commented

2026-10-17 13:54:38 +00:00

Owner

Problem

A takedown polish round cannot correct a lint offense in a failing_tests file. The green-suite step lints the failing tests, but the polish step accepts changes to code_files only. A design that is correct except for a lint offense in its test fails the whole run.

Observed

Run docs/takedown/1079-20261017-094730 (#1079). The first green-suite step reported three offenses. polish-1 corrected the two production offenses. The offense in the test file stayed. polish-2 returned the test file plugins/os-me/test/review_log_backfill_test.rb as a code_files entry. The step rejected the round, and the run fell back to design-1.

FAILED green-suite: final design design-1: lint offenses: Lint/AmbiguousBlockAssociation plugins/os-me/test/review_log_backfill_test.rb:45

Reproduce

n/a: one live run shows it; the run record above holds every step reply.

Origin

Trigger: takedown-run --live 1079 on 2026-10-17
Improvised this session: #1079 was built on the poodr-ticket-implementation map from the ticket's own Approach
Chain: run fails green-suite ← polish cannot change a failing_tests entry ← polish step and card accept code_files only. DESIGN (plugins/os-sdlc/eval/ticket-takedown/lib/takedown/command/polish_step.rb, polish card)
Root candidate: this ticket
Where: plugins/os-sdlc/eval/ticket-takedown/lib/takedown/command/polish_step.rb
Session: 1922cc29-0ce5-4463-948a-193db0b573f3
Transcript: /home/jared/.claude/projects/-home-jared-dev-cc-os/1922cc29-0ce5-4463-948a-193db0b573f3.jsonl

VERDICT: CREATE
REASON: A complete live takedown run (#1079) failed in green-suite because polish accepts only code_files, so it cannot correct a lint offense in a failing_tests file. The Origin chain ends in DESIGN in polish_step.rb; the ticket is the root.

## Problem A takedown polish round cannot correct a lint offense in a `failing_tests` file. The green-suite step lints the failing tests, but the polish step accepts changes to `code_files` only. A design that is correct except for a lint offense in its test fails the whole run. ## Observed Run `docs/takedown/1079-20261017-094730` (#1079). The first green-suite step reported three offenses. polish-1 corrected the two production offenses. The offense in the test file stayed. polish-2 returned the test file `plugins/os-me/test/review_log_backfill_test.rb` as a `code_files` entry. The step rejected the round, and the run fell back to design-1. ``` FAILED green-suite: final design design-1: lint offenses: Lint/AmbiguousBlockAssociation plugins/os-me/test/review_log_backfill_test.rb:45 ``` ## Reproduce n/a: one live run shows it; the run record above holds every step reply. ## Origin - Trigger: `takedown-run --live 1079` on 2026-10-17 - Improvised this session: #1079 was built on the `poodr-ticket-implementation` map from the ticket's own Approach - Chain: run fails green-suite ← polish cannot change a `failing_tests` entry ← polish step and card accept `code_files` only. DESIGN (`plugins/os-sdlc/eval/ticket-takedown/lib/takedown/command/polish_step.rb`, polish card) - Root candidate: this ticket - Where: plugins/os-sdlc/eval/ticket-takedown/lib/takedown/command/polish_step.rb - Session: 1922cc29-0ce5-4463-948a-193db0b573f3 - Transcript: /home/jared/.claude/projects/-home-jared-dev-cc-os/1922cc29-0ce5-4463-948a-193db0b573f3.jsonl VERDICT: CREATE REASON: A complete live takedown run (#1079) failed in green-suite because polish accepts only `code_files`, so it cannot correct a lint offense in a `failing_tests` file. The Origin chain ends in DESIGN in `polish_step.rb`; the ticket is the root.

jared added the

plugin/os-sdlc

filed-by/agent

category/code-change

labels

2026-10-17 13:54:38 +00:00

jared referenced this issue

2026-11-03 00:03:06 +00:00

Takedown: give the reviser the green-suite failure, and name the test in a polish rejection #1521