Pass PATH into Inspector::ExecutablePath from the wiring instead of reading ENV in a default argument #1041

New issue

Open

opened 2026-10-16 19:24:36 +00:00 by jared · 0 comments

jared commented

2026-10-16 19:24:36 +00:00

Owner

Problem

Backlog::Inspector::ExecutablePath#initialize(path = ENV.fetch("PATH", "")) reads the environment inside a library object (lens A6: the entry layer reads ENV, the library receives values).

Observed

Evidence: lib/backlog/inspector/executable_path.rb:5; lib/backlog/inspector/command.rb:7 builds ExecutablePath.new as a default; tests already inject a path (tests/support/inspect_command_sandbox.rb:11, tests/inspector/command_executable_path_test.rb:37). Ruling R29, follow-up 6.

Reproduce

n/a: ENV read found in a crc-refactor tuning run; the defect is structural, not a runtime failure.

Acceptance criteria

ExecutablePath#initialize takes path as required with no ENV reference; Inspector::Command takes executables: with no default; cli_command_wiring.rb builds ExecutablePath.new(ENV.fetch("PATH", "")); inspect tests pass; grep finds no ENV under lib/backlog/inspector/.

Skeptic: VERDICT: CREATE — the ENV default is real; ruling R29 recorded it as a lens A6 gap.

Origin

Trigger: crc-refactor tuning run on plugins/os-backlog, branch crc-os-backlog-2026-10-16 (ledger docs/crc/os-backlog/ledger.tsv, rulings docs/crc/os-backlog/rulings.md).
Improvised this session: none
Chain: ENV read inside a library object in plugins/os-backlog ← ruling R29 recorded it as a lens A6 gap (docs/crc/os-backlog/rulings.md) ← DESIGN
Root candidate: none beyond this ticket
Where: plugins/os-backlog/lib/backlog/inspector/executable_path.rb
Session: a5e278ab-89aa-4ed6-adb4-b70820788f0c
Transcript: /home/jared/.claude/projects/-home-jared-dev-cc-os--claude-worktrees-crc-os-backlog-2026-10-16/a5e278ab-89aa-4ed6-adb4-b70820788f0c.jsonl

## Problem `Backlog::Inspector::ExecutablePath#initialize(path = ENV.fetch("PATH", ""))` reads the environment inside a library object (lens A6: the entry layer reads ENV, the library receives values). ## Observed Evidence: lib/backlog/inspector/executable_path.rb:5; lib/backlog/inspector/command.rb:7 builds `ExecutablePath.new` as a default; tests already inject a path (tests/support/inspect_command_sandbox.rb:11, tests/inspector/command_executable_path_test.rb:37). Ruling R29, follow-up 6. ## Reproduce n/a: ENV read found in a crc-refactor tuning run; the defect is structural, not a runtime failure. ## Acceptance criteria 1. `ExecutablePath#initialize` takes `path` as required with no ENV reference; `Inspector::Command` takes `executables:` with no default; cli_command_wiring.rb builds `ExecutablePath.new(ENV.fetch("PATH", ""))`; inspect tests pass; grep finds no `ENV` under lib/backlog/inspector/. Skeptic: VERDICT: CREATE — the ENV default is real; ruling R29 recorded it as a lens A6 gap. ## Origin - Trigger: crc-refactor tuning run on plugins/os-backlog, branch crc-os-backlog-2026-10-16 (ledger docs/crc/os-backlog/ledger.tsv, rulings docs/crc/os-backlog/rulings.md). - Improvised this session: none - Chain: ENV read inside a library object in plugins/os-backlog ← ruling R29 recorded it as a lens A6 gap (docs/crc/os-backlog/rulings.md) ← DESIGN - Root candidate: none beyond this ticket - Where: plugins/os-backlog/lib/backlog/inspector/executable_path.rb - Session: a5e278ab-89aa-4ed6-adb4-b70820788f0c - Transcript: /home/jared/.claude/projects/-home-jared-dev-cc-os--claude-worktrees-crc-os-backlog-2026-10-16/a5e278ab-89aa-4ed6-adb4-b70820788f0c.jsonl

jared added the

plugin/os-backlog

filed-by/agent

category/code-change

labels

2026-10-16 19:24:36 +00:00

jared referenced this issue

2026-10-16 19:26:10 +00:00

CRC wave 5: split Backlog::Inspector #1030

jared referenced this issue

2026-11-02 16:01:01 +00:00

Add a cop for ENV reads in library code (A6) #1506