From 5c18ba696f71f19497e0fa5cfb6c170f4d6ea09d Mon Sep 17 00:00:00 2001 From: jared Date: Thu, 16 Jul 2026 16:18:28 -0400 Subject: [PATCH] os-sdlc: reviewer is a named agent with hook-assembled context packet Co-Authored-By: Claude Fable 5 Claude-Session: https://claude.ai/code/session_01VgG2g9ooqbnBiZYGAonGYG --- plugins/os-sdlc/reference/pipeline-stages.md | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/plugins/os-sdlc/reference/pipeline-stages.md b/plugins/os-sdlc/reference/pipeline-stages.md index e05131c..3f1443e 100644 --- a/plugins/os-sdlc/reference/pipeline-stages.md +++ b/plugins/os-sdlc/reference/pipeline-stages.md @@ -25,9 +25,18 @@ Manually triggered by `/implement `. Stages, in order: 5. **Green-assert gate** (deterministic hook) — suite + lint must pass. Failures are auto-fed back into the same programmer's next turn; a max-iterations cap escalates to the human rather than looping forever. -6. **Reviewer agent** — two ordered checks: first tests align with the spec/ticket, then code - aligns with both tests and spec. Order matters — misaligned tests invalidate a "code passes - tests" result. +6. **Reviewer agent** — a *named agent* (not a skill), so its tool surface is minimal and + its context never leaks into the orchestrator's (see + [agent-design-principles](agent-design-principles.md)). It reads only a hook-assembled + context packet — test status from the green-assert gate (passing, unless max-iterations + escalated), a mechanically generated diff, and the spec/ticket — gathered into one + document by a code-actor hook before the agent is invoked; the reviewer runs nothing + itself. Two ordered checks: first tests align with the spec/ticket, then code aligns + with both tests and spec. Order matters — misaligned tests invalidate a "code passes + tests" result. ADR-0037's `/os-sdlc:review` (standards-conformance + spec-fidelity + + Fowler refactor smells) is satisfied by this same agent; if standalone review of an + arbitrary diff is wanted outside a pipeline run, a thin skill wrapper dispatches the + agent with a hand-assembled packet — one reviewer, two entry points. 7. **Cleanup & report** (agent/code mix) — trims scratch artifacts, produces a summary for the human. What gets written, where, and for how long is defined in [pipeline-observability](pipeline-observability.md).